Re: [PATCH] sh: kprobes: remove unused variables in kprobe_exceptions_notify()

[Mike Rapoport <rppt@kernel.org>]

On Mon, May 19, 2025 at 10:48:20AM +0200, Geert Uytterhoeven wrote:
> Hi Mike,
> 
> On Sat, 17 May 2025 at 11:30, Mike Rapoport <rppt@kernel.org> wrote:
> > From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
> >
> > kbuild reports the following warning:
> >
> >    arch/sh/kernel/kprobes.c: In function 'kprobe_exceptions_notify':
> > >> arch/sh/kernel/kprobes.c:412:24: warning: variable 'p' set but not used [-Wunused-but-set-variable]
> >      412 |         struct kprobe *p = NULL;
> >          |                        ^
> >
> > The variable 'p' is indeed unused since the commit fa5a24b16f94
> > ("sh/kprobes: Don't call the ->break_handler() in SH kprobes code")
> >
> > Remove that variable along with 'kprobe_opcode_t *addr' which also
> > becomes unused after 'p' is removed.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202505151341.EuRFR22l-lkp@intel.com/
> > Fixes: fa5a24b16f94 ("sh/kprobes: Don't call the ->break_handler() in SH kprobes code")
> > Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> 
> Thanks for your patch!
> 
> "p" and "addr" are definitely unused (besides side-effects?), so
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> > --- a/arch/sh/kernel/kprobes.c
> > +++ b/arch/sh/kernel/kprobes.c
> > @@ -404,13 +404,10 @@ int __kprobes kprobe_fault_handler(struct pt_regs *regs, int trapnr)
> >  int __kprobes kprobe_exceptions_notify(struct notifier_block *self,
> >                                        unsigned long val, void *data)
> >  {
> > -       struct kprobe *p = NULL;
> >         struct die_args *args = (struct die_args *)data;
> >         int ret = NOTIFY_DONE;
> > -       kprobe_opcode_t *addr = NULL;
> >         struct kprobe_ctlblk *kcb = get_kprobe_ctlblk();
> >
> > -       addr = (kprobe_opcode_t *) (args->regs->pc);
> >         if (val == DIE_TRAP &&
> >             args->trapnr == (BREAKPOINT_INSTRUCTION & 0xff)) {
> >                 if (!kprobe_running()) {
> > @@ -421,7 +418,6 @@ int __kprobes kprobe_exceptions_notify(struct notifier_block *self,
> >                                 ret = NOTIFY_DONE;
> >                         }
> >                 } else {
> > -                       p = get_kprobe(addr);
> >                         if ((kcb->kprobe_status == KPROBE_HIT_SS) ||
> >                             (kcb->kprobe_status == KPROBE_REENTER)) {
> >                                 if (post_kprobe_handler(args->regs))
> 
> I have no idea what this code is supposed to do, and if it actually
> works.  Red flags are that the assigned "p" was never used at all
> since the inception of this function.

"p" was used before fa5a24b16f94 ("sh/kprobes: Don't call the
->break_handler() in SH kprobes code"), but I can't say I understand that
code either :)

CC'ing Masami, he probably knows what this code does.
 
> Gr{oetje,eeting}s,
> 
>                         Geert

-- 
Sincerely yours,
Mike.