From: Magnus Damm <magnus.damm@gmail.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: mach-ecovec24: Enable SPU2 clock when boot
Date: Thu, 05 Nov 2009 08:42:38 +0000 [thread overview]
Message-ID: <aec7e5c30911050042n3e7df043m37d46eafbb3cd1b1@mail.gmail.com> (raw)
In-Reply-To: <uocnifuik.wl%morimoto.kuninori@renesas.com>
Hey Morimoto-san,
On Thu, Nov 5, 2009 at 5:01 PM, Kuninori Morimoto
<morimoto.kuninori@renesas.com> wrote:
>> This is just doing an enable on init, so it's better to just flag this in
>> the CPU code. ie:
> (snip)
>> Although this is going to be a nuisance for power management.
>
> I'm 100% not sure about power management.
> Is spu clock operation unnecessary if there is following ?
>
> + .archdata = {
> + .hwblk_id = HWBLK_SPU,
> + },
>
> If so, please throw away this patch.
No, your code is correct. And Paul has a nicer solution for the spu_clk.
At this point you need to enable the parent clock and use hwblk_id for
module stop bits.
Cheers,
/ magnus
prev parent reply other threads:[~2009-11-05 8:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 10:34 [PATCH] sh: mach-ecovec24: Enable SPU2 clock when boot Kuninori Morimoto
2009-11-05 5:02 ` Paul Mundt
2009-11-05 8:01 ` Kuninori Morimoto
2009-11-05 8:42 ` Magnus Damm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aec7e5c30911050042n3e7df043m37d46eafbb3cd1b1@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox