From mboxrd@z Thu Jan 1 00:00:00 1970 From: Magnus Damm Date: Wed, 10 Feb 2010 04:13:37 +0000 Subject: Re: [PATCH] input: bitmap update for sh_keysc V2 Message-Id: List-Id: References: <20100209091609.1262.66929.sendpatchset@rxone.opensource.se> <20100209093954.GC12642@core.coreip.homeip.net> In-Reply-To: <20100209093954.GC12642@core.coreip.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, lethal@linux-sh.org, linux-sh@vger.kernel.org On Tue, Feb 9, 2010 at 6:39 PM, Dmitry Torokhov wrote: > On Tue, Feb 09, 2010 at 06:16:09PM +0900, Magnus Damm wrote: >> From: Magnus Damm >> >> Update the sh_keysc driver with proper bitmap support V2. >> This instead of using a fixed 32-bit integer to keep track >> for the key states. With this change in place the driver >> supports key pads with more than 32 keys. >> >> Signed-off-by: Magnus Damm >> --- >> >> =A0Changes since V1: >> =A0- ditched the wrapping macros >> =A0- use __set_bit() and __clear_bit() > > Thank you for making the change. It indeed is easier to read than the > original since one does not have to go and look up what wrappers are > doing. Yeah, I initially disliked the SH_KEYSC_MAXKEYS that now are sprinkled all over the place, but I have to admit that not using wrappers made me realize that I should use __set_bit() and __clear_bit() instead of the atomic ones. So all good. Thanks! / magnus