Re: [PATCH] ARM: mach-shmobile: ap4evb SDHI0 platform data

[Magnus Damm <magnus.damm@gmail.com>]

On Wed, Mar 10, 2010 at 4:36 PM, Paul Mundt <lethal@linux-sh.org> wrote:
> On Wed, Mar 10, 2010 at 04:15:28PM +0900, Magnus Damm wrote:
>> @@ -206,10 +207,38 @@ static struct platform_device keysc_devi
>>       },
>>  };
>>
>> +/* SDHI0 */
>> +static struct sh_mobile_sdhi_info sdhi0_info = {
>> +};
>> +
> Try again?

The sh_mobile_sdhi driver allows omitting the platform data, so
perhaps that's a better idea.

>> +static struct resource sdhi0_resources[] = {
>> +     [0] = {
>> +             .name   = "SDHI0",
>> +             .start  = 0xe6850000,
>> +             .end    = 0xe68501ff,
>> +             .flags  = IORESOURCE_MEM,
>
> If you aren't going to use a useful name for the resource, then the
> name can just be left unset, this will ensure that the driver core
> assigns the resource a name matching the device name/id pair.

The data sheet refers to this hardware block as SDHI0.

> So if left unset you would end up with "sh_mobile_sdhi.0" in /proc/iomem,
> which could be more intuitive.

Sure, that's also an option. For sh7724 (and perhaps earlier
SH-Mobile) most resources use the data sheet name for /proc/iomem.

/ magnus