From: Magnus Damm <magnus.damm@gmail.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 04/05] dmaengine: shdma: Introduce include/linux/sh_dma.h
Date: Fri, 19 Mar 2010 07:54:56 +0000 [thread overview]
Message-ID: <aec7e5c31003190054x65cc33f9r324fb4843fa24937@mail.gmail.com> (raw)
In-Reply-To: <20100319044710.17051.98259.sendpatchset@t400s>
On Fri, Mar 19, 2010 at 4:46 PM, Guennadi Liakhovetski
<g.liakhovetski@gmx.de> wrote:
> On Fri, 19 Mar 2010, Magnus Damm wrote:
>> --- 0004/arch/sh/include/asm/dmaengine.h
>> +++ work/arch/sh/include/asm/dmaengine.h 2010-03-18 23:25:04.000000000 +0900
>> @@ -10,12 +10,7 @@
>> #ifndef ASM_DMAENGINE_H
>> #define ASM_DMAENGINE_H
>>
>> -#include <linux/dmaengine.h>
>> -#include <linux/list.h>
>> -
>> -#include <asm/dma-register.h>
>
> include/linux/sh_dma_register.h? (see below)
> I am still not sure it is a good idea to duplicate these from legacy SH
> DMA driver, maybe we could just move them in a
> include/linux/sh_dma_register.h if they are indeed common?
Nah, no point in adding another header file. The legacy driver should
just die and we're not going to do any more development there. So
duplicating them is fine IMO.
> Ok, I might be lazy on a Friday morning, but could you maybe regenerate
> this one with "-M -C --find-copies-harder" or whatever it takes to make
> git use "git rename" for this? This should work if we don't duplicate
> register names, not sure otherwise...
I don't think that will help if we have two copies of the register names.
Thanks for your help!
/ magnus
prev parent reply other threads:[~2010-03-19 7:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 4:47 [PATCH 04/05] dmaengine: shdma: Introduce include/linux/sh_dma.h Magnus Damm
2010-03-19 7:46 ` Guennadi Liakhovetski
2010-03-19 7:54 ` Magnus Damm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aec7e5c31003190054x65cc33f9r324fb4843fa24937@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).