From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DE822749DC for ; Thu, 4 Jun 2026 20:58:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780606720; cv=none; b=dSpv7dE/f9wsUHCSnQEhGVrZSC7X0CW4FKGv2DnkjfnqPlI3UxatJ+eZtMr6U+nrxUlLsc2COepB7qzBH3kf1E0Ok6gf+/AFyIzC8sDTyS2KMSh8Y5zlGUYitZTJTHG8vhHf11rZGQ2ewVfT1EYp588TooR0n/39cmEiXS2yRQ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780606720; c=relaxed/simple; bh=DQTkf1lHMIqbwK47/czYzHj+glOCSShwPoAIlDnSnRw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Oh1KDElVQs4G9MMeRsR84G7A773wD8HDOKCp8OdhDXkKe/Z4gCia7lwHbrwXAbW3tYT8FYy4wp7DBG32dcs8Fu0r7tqTkhVsycB/Jq1wNqvAdG1+03jHX8mxlCA8Qe+fDNOnHUOqvsHIxFGeCoR5EBZlP5Y6L6a6aOb9D2I2Nuo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iknnO2pz; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iknnO2pz" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-490ac357c55so13938015e9.1 for ; Thu, 04 Jun 2026 13:58:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780606718; x=1781211518; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DQTkf1lHMIqbwK47/czYzHj+glOCSShwPoAIlDnSnRw=; b=iknnO2pzYAxVBr5i32I5mNFlyUF4hG16k08qD4F71/MXpgO41aPReHIyqAUUCJV6RS ViihSrIEddeu0NhEUPgs9lB8hDS+Ep36XfsjybRB+5GMugVp4FyZhL9U0kHhkOduxGbT maWotG0ZImKwZF7omJlhECYYrhgdvXilFsiefRidN5gYZPFckPzFPAR/C47NAPfVGjps 7RHYlODTmTQhgbviG7ZVGmzhgRzv7pF5ksNClaagSXvoSSJmfCcX2whiiZxpwoscAXQB snl2pwk1CGqeCMF2Foq66rJF/MxGmx74R8cuKe5FYm1qsjt5qmQ8p4H7Ao3iwKimMlol 8Jkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780606718; x=1781211518; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DQTkf1lHMIqbwK47/czYzHj+glOCSShwPoAIlDnSnRw=; b=EbQ0EfiC9nGJMLhoQMmZYCreKZESkh8vJ8HFpaYOfeHG+rI1IDJW9ycqkC4ewjkuVr 7vAxaYBIWGb8F31QSQwK0SO44n8IfF3AccdJOq0uSJzR5eaObRXV0fdJzswa9UBx5xYa en74fGRl/TDD0olPA9+O3lCRlIHh7C0NzkEcH4vpDdx6MgqoAEGJ9SM0Q09+GiPvF8JC 1aEjCEaMn8XR9WU9OqhwOIIOAiFp7ZzuB5wId7g6uYb4vj7QKwoJ5KDR0XO/Mji0Q0DN BeJS/EvgOO6qZNAodhb4Z2HefG2EAmysOKZ0n5Wsrh4Chx7MBien7f4NoUpUvr/H8vsf pwZw== X-Forwarded-Encrypted: i=1; AFNElJ/1mkQRy7gwKe2wstUXcYJy/yN+z9dS5L2QsUTiGB1SJ5ClavEVWJYp2icciGVVkaAm4XCNavRfoA==@vger.kernel.org X-Gm-Message-State: AOJu0YyYDX2F3mlMduswgYsCIIOWzOIa5r/VXwqV+I46wJvH8WA+e6fE SsBncNie4PDmGKwiDEn9YBOBPjC/c/u8IKBKUFurTqImuLtAqcUyZbIo3+NV2vPv X-Gm-Gg: Acq92OFc6zxvv/0Tcg3ebJe6L05BYKzNxdV6+xRpiET7JOsfKRwS91qgRIGtYNpUnZz LRMaxOcxt1dMQA3j9kNq9Qj/VrdmEm7fgthLyIh+NugTNI5sZSR3+GDB0LoJpcQhZi1OhkqDypi 18WfCb6m8AhqdacuXT6Nex0SU2AAHn7/ZsUj2i5uTwt9n5xscDrFeiFWzwxkfAKjJbMzY2DhHkK kf+fl/TELRKYYl3Kxgd7fjESR+QBfLrGbcYCZBOlENBdm7qTluVbXu5+TB6ihNqmBtfHPBPslzS w5He7IM4XwAvEGVbo+lS/NacWXXEQ0IbGGaFozbRObKNXyuTryVgC6cUl8CRvUdyMbpQR5UNF6/ RKxP/z+d9T5CFD3QffYasLqB78mw227KCqGg3DocRRSvDEkGoq9n40AMv+Dl72pvmpPkJDalF67 F6pWlMWSXPr3OeDt5RArxDKIAur/7Fhp3h X-Received: by 2002:a05:600c:83c3:b0:48f:d612:3c59 with SMTP id 5b1f17b1804b1-490c25a21a9mr4351475e9.9.1780606717742; Thu, 04 Jun 2026 13:58:37 -0700 (PDT) Received: from localhost ([94.53.77.213]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc413adbsm100278155e9.15.2026.06.04.13.58.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 13:58:36 -0700 (PDT) Date: Thu, 4 Jun 2026 23:59:21 +0300 From: Catalin Iacob To: Bart Van Assche Cc: Thomas Bogendoerfer , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , "James E.J. Bottomley" , "Martin K. Petersen" , Jens Axboe , Yoshinori Sato , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH v3 0/6] Remove remaining references to the pktcdvd driver Message-ID: References: <20260530-remove-pktcdvd-references-v1-1-aa56941d4315@gmail.com> <20260604-remove-pktcdvd-references-v3-0-e2f06fb4eef4@gmail.com> <96a48e65-6ee2-4b81-91f8-821a2de707db@acm.org> Precedence: bulk X-Mailing-List: linux-sh@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <96a48e65-6ee2-4b81-91f8-821a2de707db@acm.org> On Thu, Jun 04, 2026 at 08:50:22AM -0700, Bart Van Assche wrote: > If this series is reposted, please combine patches 1/6 and 2/6. Anyway, > this series looks good to me. Thanks for taking a look. I will repost in a few days when back to a computer to fix the subject of patch 2 since you are right, it does wrongly suggest that the implementation is moved. For learning purposes, do you mind quickly sharing your rationale for combining 1 and 2? To me they are in the same area but still separate things: one removes dead code, the other increases encapsulation. Each is a small but worthwhile cleanup, they can be applied in any order and each can be applied without the other. It's true that, while patch 2 without patch 1 works, it would increase confusion but I find that an argument to order 2 after 1, not to say they are one thing. I'd also find it hard to describe what that combined patch does except by calling out two things: "remove dead code and move the declaration". Your suggested "unexport" seems more confusing than clarifying, I'd argue that today the symbol is not exported since that ifdef always compiles the export out.