From: Thomas Gleixner <tglx@linutronix.de>
To: Rich Felker <dalias@libc.org>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH] irqchip/jcore: fix lost per-cpu interrupts
Date: Sun, 09 Oct 2016 23:27:56 +0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1610100125200.7166@nanos> (raw)
In-Reply-To: <20161009220616.GD19318@brightrain.aerifal.cx>
On Sun, 9 Oct 2016, Rich Felker wrote:
> On Sun, Oct 09, 2016 at 09:23:58PM +0200, Thomas Gleixner wrote:
> > Well, you can use handle_percpu_irq() for your device interrupts if you
> > guarantee at the hardware level that there is no reentrancy.
>
> Reentrancy is possible of course if the kernel enables irqs during the
> irq handler. Is not doing so a stable part of the kernel irq
> subsystem? My understanding is that modern kernels keep irqs disabled
> for the full duration of (hard) irq handlers.
If you enable lockdep then it will yell at offenders which enable irqs in
the interrupt handler. So yes, hard irq handlers are not allowed to
reenable interrupts.
> > Once you make
> > the hardware capable of delivering them on either core the picture changes.
>
> *nod* Perhaps if/when we do that, the path of least resistence would
> be to adjust the irq numbering so that percpu (i.e., hard-routed to a
> particular cpu) and global irqs (deliverable on any core) are in
> different ranges and the existing kernel frameworks work.
That's very much what ARM and others do.
Thanks,
tglx
next prev parent reply other threads:[~2016-10-09 23:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 5:59 [PATCH] irqchip/jcore: fix lost per-cpu interrupts Rich Felker
2016-10-09 11:03 ` Thomas Gleixner
2016-10-09 14:47 ` Rich Felker
2016-10-09 19:23 ` Thomas Gleixner
2016-10-09 22:06 ` Rich Felker
2016-10-09 23:27 ` Thomas Gleixner [this message]
2016-10-11 15:21 ` Rich Felker
2016-10-12 8:18 ` Thomas Gleixner
2016-10-12 16:35 ` Rich Felker
2016-10-12 20:34 ` Paul E. McKenney
2016-10-12 22:19 ` Rich Felker
2016-10-13 7:30 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610100125200.7166@nanos \
--to=tglx@linutronix.de \
--cc=dalias@libc.org \
--cc=daniel.lezcano@linaro.org \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).