* [PATCH] SH: No need to explicitly include <linux/rwlock.h>.
@ 2010-02-27 18:35 Robert P. J. Day
0 siblings, 0 replies; 2+ messages in thread
From: Robert P. J. Day @ 2010-02-27 18:35 UTC (permalink / raw)
To: linux-sh
Since <linux/spinlock.h> already includes <linux/rwlock.h>, and the
latter file will warn about not having included the former file
anyway, there is no value in including rwlock.h explicitly.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
diff --git a/arch/sh/mm/pmb.c b/arch/sh/mm/pmb.c
index 198bcff..35b364f 100644
--- a/arch/sh/mm/pmb.c
+++ b/arch/sh/mm/pmb.c
@@ -23,7 +23,6 @@
#include <linux/err.h>
#include <linux/io.h>
#include <linux/spinlock.h>
-#include <linux/rwlock.h>
#include <asm/sizes.h>
#include <asm/system.h>
#include <asm/uaccess.h>
====================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
====================================
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] SH: No need to explicitly include <linux/rwlock.h>.
@ 2010-03-02 3:13 Paul Mundt
0 siblings, 0 replies; 2+ messages in thread
From: Paul Mundt @ 2010-03-02 3:13 UTC (permalink / raw)
To: linux-sh
On Sat, Feb 27, 2010 at 01:35:08PM -0500, Robert P. J. Day wrote:
>
> Since <linux/spinlock.h> already includes <linux/rwlock.h>, and the
> latter file will warn about not having included the former file
> anyway, there is no value in including rwlock.h explicitly.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-02 3:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-27 18:35 [PATCH] SH: No need to explicitly include <linux/rwlock.h> Robert P. J. Day
-- strict thread matches above, loose matches on Subject: below --
2010-03-02 3:13 Paul Mundt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).