From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2794430BBE for ; Tue, 3 Mar 2026 14:52:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772549564; cv=none; b=S6cLXcL3EspwDrwcGTTUz3O5mR4vQVUnFaVKE0NjausyfgLruFu7HGA12q0W69R6Vz9HKqWepgYvHZVam4rbAf/Ag66SVNFH+CEFcoek7T/T8QKLM+8eBcAjbX5BmM939aKnKlTGI3Zi+yL3S6ded5FR3mPzd+QO/UyHLbgT75k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772549564; c=relaxed/simple; bh=mSRQ1eMomHCwVtqBWfZCdjiyysv7g8iYFUzJOGWZess=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=hyHa94eT6UYdDqqiy0cU7Z79S6kiklr/IXUyDbwwNufsV4X4AfQ0vC7CzEcQzlIeCyyE2Q0ADtM2HywSCVp+yfhg6JGX7VqsNVcMEBb43Yo2aQYeE/GRyo8NyRkyWDo6uxxn+BEeP+kpAejZYwhbR36PN8LvPVAdtv4ZJtxRPsU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DIeDQHi0; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DIeDQHi0" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-439b2965d4bso2398524f8f.2 for ; Tue, 03 Mar 2026 06:52:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772549561; x=1773154361; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=h+8QbcRC2pjzuahdlMd9N/WzqWRbPt5M/XdWso0LY5g=; b=DIeDQHi0AAP91R6YbGWauz2eMg14tui6twbk5qs60s0DoQ+1m4sNZYPu4gM/D9DH1t hNmg2wPiCPvmc55Y13z7FQ6XbJB5Tou0H+GOL3lB5aw7HmnYKeMv0+mwUBic/58SF7oZ wihlcPIH4+FqRGqWqn04EyiWDXuZmM1k0zPviKdcBcgND8M5aRd1aWRm2fS16xL1pjoh boqcDFZv3MptHnPpOhCbOZnxFpV+yeIZ36XKxIy48p8jJ7CGYar4mNBW6FIPHgKRrOj7 U+jozLWw9ItdmiDZTQQvdptl4UqQuTo626xTP3rk0nf+6jVzTUnnvm4a9kMDiVnUZHyJ yaYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772549561; x=1773154361; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h+8QbcRC2pjzuahdlMd9N/WzqWRbPt5M/XdWso0LY5g=; b=iFuwp7iQ79TbJcETVuR+QCN/hPmewlEygTUMMJNXV+s90OUvdFNGD6IQnGDsUKRHk9 iyFJ6HjT/XVVaTjyW/tY8DkOojCNq7EemLoiCyO22FgyZYlFZfc0Y90gjjo+9I3khnqr u0MrXQP9hzGTjxa8kGx2G8mER7Q11yJj+9XWeZv4N6kBg9fAg2Wx3kRIwoB2L2PXxage YlXXPeugvjXAFKYf+7XPSlvHeAtU7FrEIFUpnYALL7HyODVyI3BSobmO+wEkWnZkIE5B o8D3/C6Wwy0wjj+m2pXbt81zDjAhP01Eb80raoZmNiKh3RY1ll69Od29AJbHlDqwYsNP rDMw== X-Forwarded-Encrypted: i=1; AJvYcCWDaavhiMEVt8i/dIh/xvQY2VeKmXgDeDTQ2qPeobF08mh3D6+Z8QxV1civXnyr6Uz262YNvjB/6w==@vger.kernel.org X-Gm-Message-State: AOJu0Yxkl0ROdH1bGWWpgKgdbHcBY+1rf6kXnpjWZDonKSGBhCv8HUKV LwpzisQOJgpotjzKkYGEKt0rQKrE5CDvJPwtb2Nw7aT3njn4cy9XRpf2 X-Gm-Gg: ATEYQzyEaA+ENJmhuTI88bEvJA44f4aBgnXZnYPlWyykNKBEcC7+JGkAADu/oHUI/Ec TdkCjCE3Kr7dSfgcqRyBbYo34PNM0yiY6R9ViGlPh7xpbCfDZTt8sgWwgL1E+QVka1nhslm1+py ojmoOTbfTKiqJQ8I91kEbQFPstk7NT7xjnbV+nq5IUzwBpGfKgMMfD9g+spD4dv//pkM6RhtYPO BKCWFSMH7Bj6VqA+pPRB32EhcYVOem9mQqP1e/w8+SW9RjPcP+/6hXGRQ9bbwXoAwytuN+IDupr aA1t9CC8yiUedW67YDbDT8s0UwMqCzbAENVba2taerwCHTt3EXWzNUaE+gVhm040nxl99VR9HcK GSzyAI3chmvTsjpyGE3NH5pzVwjvDKcetfnZGAdUOYdd+id6xJfG1mTHNaqBq5ynUnHQSjbJCpg 7DNIO8z5podyFawCODUN18u3/FGWbGcn0= X-Received: by 2002:a05:6000:4387:b0:439:c279:32ea with SMTP id ffacd0b85a97d-439c27935b1mr3280566f8f.39.1772549560930; Tue, 03 Mar 2026 06:52:40 -0800 (PST) Received: from [192.168.1.187] ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b03db76bsm20531779f8f.18.2026.03.03.06.52.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 06:52:40 -0800 (PST) Message-ID: Subject: Re: [PATCH v2 3/4] hwmon: axi-fan: don't use driver_override as IRQ name From: Nuno =?ISO-8859-1?Q?S=E1?= To: Danilo Krummrich , gregkh@linuxfoundation.org, rafael@kernel.org, hanguidong02@gmail.com, ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, abelvesa@kernel.org, srini@kernel.org, s.nawrocki@samsung.com, nuno.sa@analog.com Cc: driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-hwmon@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, linux-sh@vger.kernel.org Date: Tue, 03 Mar 2026 14:53:24 +0000 In-Reply-To: <20260303115720.48783-4-dakr@kernel.org> References: <20260303115720.48783-1-dakr@kernel.org> <20260303115720.48783-4-dakr@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 Precedence: bulk X-Mailing-List: linux-sh@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-03-03 at 12:53 +0100, Danilo Krummrich wrote: > Do not use driver_override as IRQ name, as it is not guaranteed to point > to a valid string; use NULL instead (which makes the devm IRQ helpers > use dev_name()). >=20 > Fixes: 8412b410fa5e ("hwmon: Support ADI Fan Control IP") > Signed-off-by: Danilo Krummrich > --- Reviewed-by: Nuno S=C3=A1 > =C2=A0drivers/hwmon/axi-fan-control.c | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/hwmon/axi-fan-control.c b/drivers/hwmon/axi-fan-cont= rol.c > index b7bb325c3ad9..01590dfa55e6 100644 > --- a/drivers/hwmon/axi-fan-control.c > +++ b/drivers/hwmon/axi-fan-control.c > @@ -507,7 +507,7 @@ static int axi_fan_control_probe(struct platform_devi= ce *pdev) > =C2=A0 ret =3D devm_request_threaded_irq(&pdev->dev, ctl->irq, NULL, > =C2=A0 axi_fan_control_irq_handler, > =C2=A0 IRQF_ONESHOT | IRQF_TRIGGER_HIGH, > - pdev->driver_override, ctl); > + NULL, ctl); > =C2=A0 if (ret) > =C2=A0 return dev_err_probe(&pdev->dev, ret, > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 "failed to request an irq\n");