From: David Hildenbrand <david@redhat.com>
To: Logan Gunthorpe <logang@deltatee.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-mm@kvack.org, Dan Williams <dan.j.williams@intel.com>,
Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Eric Badger <ebadger@gigaio.com>,
Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Andy Lutomirski <luto@kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 1/8] mm/memory_hotplug: Drop the flags field from struct mhp_restrictions
Date: Wed, 08 Jan 2020 12:27:14 +0000 [thread overview]
Message-ID: <c3c3c475-f828-13f7-b5c9-f691ef0fe1ff@redhat.com> (raw)
In-Reply-To: <20200107205959.7575-2-logang@deltatee.com>
On 07.01.20 21:59, Logan Gunthorpe wrote:
> This variable is not used anywhere and should therefore be removed
> from the structure.
>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> ---
> include/linux/memory_hotplug.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h
> index ba0dca6aac6e..e47a29761088 100644
> --- a/include/linux/memory_hotplug.h
> +++ b/include/linux/memory_hotplug.h
> @@ -55,11 +55,9 @@ enum {
>
> /*
> * Restrictions for the memory hotplug:
> - * flags: MHP_ flags
> * altmap: alternative allocator for memmap array
> */
> struct mhp_restrictions {
> - unsigned long flags;
> struct vmem_altmap *altmap;
> };
We wanted to use that for the "vmemmap on added memory" config knob. But
that might still take some time and we might actually realize it using
the altmap instead (hopefully :) ).
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-01-08 12:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 20:59 [PATCH v2 0/8] Allow setting caching mode in arch_add_memory() for P2PDMA Logan Gunthorpe
2020-01-07 20:59 ` [PATCH v2 1/8] mm/memory_hotplug: Drop the flags field from struct mhp_restrictions Logan Gunthorpe
2020-01-08 12:27 ` David Hildenbrand [this message]
2020-01-07 20:59 ` [PATCH v2 2/8] mm/memory_hotplug: Rename mhp_restrictions to mhp_modifiers Logan Gunthorpe
2020-01-08 12:28 ` David Hildenbrand
2020-01-08 17:16 ` Logan Gunthorpe
2020-01-08 18:59 ` Dan Williams
2020-01-08 19:08 ` David Hildenbrand
2020-01-08 19:13 ` Dan Williams
2020-01-08 19:29 ` Logan Gunthorpe
2020-01-07 20:59 ` [PATCH v2 3/8] x86/mm: Thread pgprot_t through init_memory_mapping() Logan Gunthorpe
2020-01-07 20:59 ` [PATCH v2 4/8] x86/mm: Introduce _set_memory_prot() Logan Gunthorpe
2020-01-07 20:59 ` [PATCH v2 5/8] powerpc/mm: Thread pgprot_t through create_section_mapping() Logan Gunthorpe
2020-01-07 20:59 ` [PATCH v2 6/8] s390/mm: Thread pgprot_t through vmem_add_mapping() Logan Gunthorpe
2020-01-08 12:43 ` David Hildenbrand
2020-01-08 17:20 ` Logan Gunthorpe
2020-01-07 20:59 ` [PATCH v2 7/8] mm/memory_hotplug: Add pgprot_t to mhp_modifiers Logan Gunthorpe
2020-01-08 12:39 ` David Hildenbrand
2020-01-08 17:17 ` Logan Gunthorpe
2020-01-08 12:42 ` Michal Hocko
2020-01-08 17:18 ` Logan Gunthorpe
2020-01-07 20:59 ` [PATCH v2 8/8] mm/memremap: Set caching mode for PCI P2PDMA memory to WC Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3c3c475-f828-13f7-b5c9-f691ef0fe1ff@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=ebadger@gigaio.com \
--cc=hch@lst.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=logang@deltatee.com \
--cc=luto@kernel.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).