public inbox for linux-sh@vger.kernel.org
 help / color / mirror / Atom feed
From: Artur Rojek <contact@artur-rojek.eu>
To: Johan Hovold <johan@kernel.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] maple: switch to dynamic root device
Date: Fri, 24 Apr 2026 21:08:31 +0200	[thread overview]
Message-ID: <c67bd8df5fbfc357dc20ad7973eb5adb@artur-rojek.eu> (raw)
In-Reply-To: <20260424104142.2617115-1-johan@kernel.org>

On 2026-04-24 12:41, Johan Hovold wrote:
> Driver core expects devices to be dynamically allocated and will, for
> example, complain loudly when no release function has been provided.
> 
> Use root_device_register() to allocate and register the root device
> instead of open coding using a static device.
> 
> Note that this also fixes a reference leak in case device_register()
> fails which may be flagged by static checkers.
> 
> Signed-off-by: Johan Hovold <johan@kernel.org>

Hi Johan,

thanks for the patch. Verified on real hardware. LGTM:

Acked-by: Artur Rojek <contact@artur-rojek.eu>

  reply	other threads:[~2026-04-24 19:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-24 10:41 [PATCH] maple: switch to dynamic root device Johan Hovold
2026-04-24 19:08 ` Artur Rojek [this message]
2026-04-24 19:59   ` John Paul Adrian Glaubitz
2026-04-24 21:09     ` Artur Rojek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c67bd8df5fbfc357dc20ad7973eb5adb@artur-rojek.eu \
    --to=contact@artur-rojek.eu \
    --cc=dalias@libc.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox