From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Date: Thu, 09 Jul 2020 09:10:29 +0000 Subject: Re: [PATCH v3 2/6] arm64/mm: use default dummy memory_add_physaddr_to_nid() Message-Id: List-Id: References: <20200709020629.91671-1-justin.he@arm.com> <20200709020629.91671-3-justin.he@arm.com> In-Reply-To: <20200709020629.91671-3-justin.he@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jia He , Catalin Marinas , Will Deacon , Tony Luck , Fenghua Yu , Yoshinori Sato , Rich Felker , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov Cc: Kaly Xin , Michal Hocko , Dave Jiang , Baoquan He , linux-sh@vger.kernel.org, Vishal Verma , Masahiro Yamada , x86@kernel.org, Chuhong Yuan , linux-kernel@vger.kernel.org, Mike Rapoport , linux-mm@kvack.org, linux-nvdimm@lists.01.org, Jonathan Cameron , "H. Peter Anvin" , linux-ia64@vger.kernel.org, Dan Williams , Logan Gunthorpe , Andrew Morton , linux-arm-kernel@lists.infradead.org On 09.07.20 04:06, Jia He wrote: > After making default memory_add_physaddr_to_nid() in mm/memory_hotplug, > it is no use defining a similar one in arch specific directory. > > Signed-off-by: Jia He > --- > arch/arm64/mm/numa.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c > index aafcee3e3f7e..73f8b49d485c 100644 > --- a/arch/arm64/mm/numa.c > +++ b/arch/arm64/mm/numa.c > @@ -461,13 +461,3 @@ void __init arm64_numa_init(void) > > numa_init(dummy_numa_init); > } > - > -/* > - * We hope that we will be hotplugging memory on nodes we already know about, > - * such that acpi_get_node() succeeds and we never fall back to this... > - */ > -int memory_add_physaddr_to_nid(u64 addr) > -{ > - pr_warn("Unknown node for memory at 0x%llx, assuming node 0\n", addr); > - return 0; > -} > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb