From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Rob Herring <robh+dt@kernel.org>,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
Chris Brandt <chris.brandt@renesas.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Linux I2C <linux-i2c@vger.kernel.org>,
linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Prabhakar <prabhakar.csengg@gmail.com>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt
Date: Wed, 9 Feb 2022 18:11:35 +0300 [thread overview]
Message-ID: <d74ab454-9337-d168-9b21-842569431b4a@gmail.com> (raw)
In-Reply-To: <CAK8P3a3owi7YWmq-tckD-C7NK5HaX+swGNW-QBkWQuQgVsVWrA@mail.gmail.com>
On 2/8/22 3:31 PM, Arnd Bergmann wrote:
[...]
>>> I might have missed something, but it seems the only user of IRQ 0 on
>>> SuperH is smsc911x Ethernet in arch/sh/boards/board-apsh4a3a.c and
>>> arch/sh/boards/board-apsh4ad0a.c, which use evt2irq(0x200).
>>> These should have been seeing the "0 is an invalid IRQ number"
>>> warning splat since it was introduced in commit a85a6c86c25be2d2
>>> ("driver core: platform: Clarify that IRQ 0 is invalid"). Or not:
>>
>> Warning or no warning, 0 is still returned. :-/
>> My attempt to put an end to this has stuck waiting a review from the IRQ
>> people...
>
> I had another look at this after you asked about it on IRC. I don't
> know much SH assembly, but I suspect IRQ 0 has not been delivered
> since 2009 after 1e1030dccb10 ("sh: nmi_debug support."). On a
Mhm... this commit changes the SH3 code while SH778x are SH4A, no?
[...]
>
> Arnd
MBR, Sergey
next prev parent reply other threads:[~2022-02-09 15:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211218165258.16716-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
[not found] ` <20211218165258.16716-3-prabhakar.mahadev-lad.rj@bp.renesas.com>
2021-12-20 10:17 ` [PATCH 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt Geert Uytterhoeven
2021-12-20 11:53 ` Sergei Shtylyov
2022-02-08 12:31 ` Arnd Bergmann
2022-02-09 15:11 ` Sergei Shtylyov [this message]
2022-02-09 15:18 ` Arnd Bergmann
2022-02-09 15:48 ` Sergei Shtylyov
2022-02-09 16:02 ` Arnd Bergmann
2022-02-09 16:08 ` Sergei Shtylyov
2022-02-09 22:56 ` Arnd Bergmann
2022-02-10 8:54 ` Geert Uytterhoeven
2022-02-10 9:32 ` Geert Uytterhoeven
2022-02-10 9:46 ` Sergei Shtylyov
2021-12-20 11:55 ` Lad, Prabhakar
2021-12-20 12:54 ` Geert Uytterhoeven
2021-12-20 13:00 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d74ab454-9337-d168-9b21-842569431b4a@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=chris.brandt@renesas.com \
--cc=f.fainelli@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=nsaenz@kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox