From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Artur Rojek <contact@artur-rojek.eu>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rafael Ignacio Zurita <rafaelignacio.zurita@gmail.com>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] sh: dma: Drop incorrect SH_DMAC_BASE1 for SH4
Date: Tue, 04 Jul 2023 22:32:10 +0200 [thread overview]
Message-ID: <d9f6fdf1ba8a3c57e80da0582a6dd8b83b1373df.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <20230527164452.64797-3-contact@artur-rojek.eu>
On Sat, 2023-05-27 at 18:44 +0200, Artur Rojek wrote:
> None of the supported SH4 family SoCs features a second DMAC module. As
> this define negatively impacts DMA channel calculation for the above
> targets, remove it from the code.
>
> Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
> ---
>
> v2: new patch
>
> arch/sh/include/cpu-sh4/cpu/dma.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/sh/include/cpu-sh4/cpu/dma.h b/arch/sh/include/cpu-sh4/cpu/dma.h
> index 38187d06b234..e97fb2c79177 100644
> --- a/arch/sh/include/cpu-sh4/cpu/dma.h
> +++ b/arch/sh/include/cpu-sh4/cpu/dma.h
> @@ -13,6 +13,5 @@
> #define DMAE0_IRQ evt2irq(0x6c0)
>
> #define SH_DMAC_BASE0 0xffa00000
> -#define SH_DMAC_BASE1 0xffa00070
>
> #endif /* __ASM_CPU_SH4_DMA_H */
Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
next prev parent reply other threads:[~2023-07-04 20:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-27 16:44 [PATCH v2 0/3] SuperH DMAC fixes Artur Rojek
2023-05-27 16:44 ` [PATCH v2 1/3] sh: dma: Fix dma channel offset calculation Artur Rojek
2023-06-07 9:04 ` Geert Uytterhoeven
2023-07-04 20:30 ` John Paul Adrian Glaubitz
2023-05-27 16:44 ` [PATCH v2 2/3] sh: dma: Drop incorrect SH_DMAC_BASE1 for SH4 Artur Rojek
2023-06-07 9:05 ` Geert Uytterhoeven
2023-07-04 20:32 ` John Paul Adrian Glaubitz [this message]
2023-05-27 16:44 ` [PATCH v2 3/3] sh: dma: Correct the number of DMA channels in SH7709 Artur Rojek
2023-06-07 9:16 ` Geert Uytterhoeven
2023-06-08 9:54 ` John Paul Adrian Glaubitz
2023-06-08 9:58 ` Geert Uytterhoeven
2023-06-08 10:03 ` John Paul Adrian Glaubitz
2023-06-17 7:31 ` John Paul Adrian Glaubitz
2023-06-17 11:09 ` Geert Uytterhoeven
2023-07-04 5:45 ` John Paul Adrian Glaubitz
2023-07-04 7:32 ` Geert Uytterhoeven
2023-07-04 7:43 ` John Paul Adrian Glaubitz
2023-07-04 7:54 ` Geert Uytterhoeven
2023-07-04 20:35 ` John Paul Adrian Glaubitz
2023-07-05 17:08 ` [PATCH v2 0/3] SuperH DMAC fixes John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9f6fdf1ba8a3c57e80da0582a6dd8b83b1373df.camel@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=contact@artur-rojek.eu \
--cc=dalias@libc.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=rafaelignacio.zurita@gmail.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).