From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E71BEB64D9 for ; Tue, 4 Jul 2023 20:32:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231179AbjGDUcS convert rfc822-to-8bit (ORCPT ); Tue, 4 Jul 2023 16:32:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230246AbjGDUcR (ORCPT ); Tue, 4 Jul 2023 16:32:17 -0400 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD934E76; Tue, 4 Jul 2023 13:32:16 -0700 (PDT) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1qGmh1-001suX-Qh; Tue, 04 Jul 2023 22:32:11 +0200 Received: from p5b13a7a5.dip0.t-ipconnect.de ([91.19.167.165] helo=[192.168.178.81]) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1qGmh1-003X2y-JE; Tue, 04 Jul 2023 22:32:11 +0200 Message-ID: Subject: Re: [PATCH v2 2/3] sh: dma: Drop incorrect SH_DMAC_BASE1 for SH4 From: John Paul Adrian Glaubitz To: Artur Rojek , Yoshinori Sato , Rich Felker , Geert Uytterhoeven Cc: Rafael Ignacio Zurita , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 04 Jul 2023 22:32:10 +0200 In-Reply-To: <20230527164452.64797-3-contact@artur-rojek.eu> References: <20230527164452.64797-1-contact@artur-rojek.eu> <20230527164452.64797-3-contact@artur-rojek.eu> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.48.3 MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 91.19.167.165 X-ZEDAT-Hint: PO Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On Sat, 2023-05-27 at 18:44 +0200, Artur Rojek wrote: > None of the supported SH4 family SoCs features a second DMAC module. As > this define negatively impacts DMA channel calculation for the above > targets, remove it from the code. > > Signed-off-by: Artur Rojek > --- > > v2: new patch > > arch/sh/include/cpu-sh4/cpu/dma.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/sh/include/cpu-sh4/cpu/dma.h b/arch/sh/include/cpu-sh4/cpu/dma.h > index 38187d06b234..e97fb2c79177 100644 > --- a/arch/sh/include/cpu-sh4/cpu/dma.h > +++ b/arch/sh/include/cpu-sh4/cpu/dma.h > @@ -13,6 +13,5 @@ > #define DMAE0_IRQ evt2irq(0x6c0) > > #define SH_DMAC_BASE0 0xffa00000 > -#define SH_DMAC_BASE1 0xffa00070 > > #endif /* __ASM_CPU_SH4_DMA_H */ Reviewed-by: John Paul Adrian Glaubitz -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913