[PATCH] sh: j2: drop incorrect SPI controller max frequency property

[PATCH] sh: j2: drop incorrect SPI controller max frequency property

[Krzysztof Kozlowski]

The J2 SPI controller bindings never allowed spi-max-frequency property
in the controller node.  Neither old spi-bus.txt bindings, nor new DT
schema allows it.  Linux driver does not parse that property from
controller node, thus drop it from DTS as incorrect hardware
description.  The SPI child device has already the same property with
the same value, so functionality should not be affected.

Cc: Kousik Sanagavarapu <five231003@gmail.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/sh/boot/dts/j2_mimas_v2.dts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/sh/boot/dts/j2_mimas_v2.dts b/arch/sh/boot/dts/j2_mimas_v2.dts
index fa9562f78d53..faf884f53804 100644
--- a/arch/sh/boot/dts/j2_mimas_v2.dts
+++ b/arch/sh/boot/dts/j2_mimas_v2.dts
@@ -71,8 +71,6 @@ spi0: spi@40 {
 			#address-cells = <1>;
 			#size-cells = <0>;
 
-			spi-max-frequency = <25000000>;
-
 			reg = <0x40 0x8>;
 
 			sdcard@0 {
-- 
2.34.1

Re: [PATCH] sh: j2: drop incorrect SPI controller max frequency property

[Rob Landley]

On 3/22/24 01:42, Krzysztof Kozlowski wrote:
> The J2 SPI controller bindings never allowed spi-max-frequency property
> in the controller node.  Neither old spi-bus.txt bindings, nor new DT
> schema allows it.  Linux driver does not parse that property from
> controller node, thus drop it from DTS as incorrect hardware
> description.  The SPI child device has already the same property with
> the same value, so functionality should not be affected.
> 
> Cc: Kousik Sanagavarapu <five231003@gmail.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Tested-by: Rob Landley <rob@landley.net>

(By which I mean a 6.8 kernel with this patch applied booted to a shell prompt
on my J2 turtle board.)

Rob

Re: [PATCH] sh: j2: drop incorrect SPI controller max frequency property

[Krzysztof Kozlowski]

On Fri, 22 Mar 2024 07:42:21 +0100, Krzysztof Kozlowski wrote:
> The J2 SPI controller bindings never allowed spi-max-frequency property
> in the controller node.  Neither old spi-bus.txt bindings, nor new DT
> schema allows it.  Linux driver does not parse that property from
> controller node, thus drop it from DTS as incorrect hardware
> description.  The SPI child device has already the same property with
> the same value, so functionality should not be affected.
> 
> [...]

Month passed, no replies from maintainers about picking it up. Dunno, looks
abandoned, so let me grab this. If anyone else wants to pick it up, let me
know.

Applied, thanks!

[1/1] sh: j2: drop incorrect SPI controller max frequency property
      https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-dt.git/commit/?h=next/dt&id=cc92bf017f7c66c8a4050c61a7d11ddfd43f5cee

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Re: [PATCH] sh: j2: drop incorrect SPI controller max frequency property

[D. Jeff Dionne]

Adrian,

IMHO, this driver should go through the SH tree.  Thanks Rob, for testing the patch.

J.

> On Apr 24, 2024, at 3:48 PM, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> 
> 
> On Fri, 22 Mar 2024 07:42:21 +0100, Krzysztof Kozlowski wrote:
>> The J2 SPI controller bindings never allowed spi-max-frequency property
>> in the controller node.  Neither old spi-bus.txt bindings, nor new DT
>> schema allows it.  Linux driver does not parse that property from
>> controller node, thus drop it from DTS as incorrect hardware
>> description.  The SPI child device has already the same property with
>> the same value, so functionality should not be affected.
>> 
>> [...]
> 
> Month passed, no replies from maintainers about picking it up. Dunno, looks
> abandoned, so let me grab this. If anyone else wants to pick it up, let me
> know.
> 
> Applied, thanks!
> 
> [1/1] sh: j2: drop incorrect SPI controller max frequency property
>      https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-dt.git/commit/?h=next/dt&id=cc92bf017f7c66c8a4050c61a7d11ddfd43f5cee
> 
> Best regards,
> -- 
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 

Re: [PATCH] sh: j2: drop incorrect SPI controller max frequency property

[John Paul Adrian Glaubitz]

On Wed, 2024-04-24 at 08:48 +0200, Krzysztof Kozlowski wrote:
> On Fri, 22 Mar 2024 07:42:21 +0100, Krzysztof Kozlowski wrote:
> > The J2 SPI controller bindings never allowed spi-max-frequency property
> > in the controller node.  Neither old spi-bus.txt bindings, nor new DT
> > schema allows it.  Linux driver does not parse that property from
> > controller node, thus drop it from DTS as incorrect hardware
> > description.  The SPI child device has already the same property with
> > the same value, so functionality should not be affected.
> > 
> > [...]
> 
> Month passed, no replies from maintainers about picking it up. Dunno, looks
> abandoned, so let me grab this. If anyone else wants to pick it up, let me
> know.

I'll pick it up this weekend.

Sorry, I have been quite busy the past weeks with my dayjob.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Re: [PATCH] sh: j2: drop incorrect SPI controller max frequency property

[Krzysztof Kozlowski]

On 24/04/2024 08:59, D. Jeff Dionne wrote:
> Adrian,
> 
> IMHO, this driver should go through the SH tree.  Thanks Rob, for testing the patch.

Of course it should go via SH tree, that's not the point here. I don't
want to take sh patches.

Best regards,
Krzysztof

Re: [PATCH] sh: j2: drop incorrect SPI controller max frequency property

[Krzysztof Kozlowski]

On 24/04/2024 08:48, Krzysztof Kozlowski wrote:
> 
> On Fri, 22 Mar 2024 07:42:21 +0100, Krzysztof Kozlowski wrote:
>> The J2 SPI controller bindings never allowed spi-max-frequency property
>> in the controller node.  Neither old spi-bus.txt bindings, nor new DT
>> schema allows it.  Linux driver does not parse that property from
>> controller node, thus drop it from DTS as incorrect hardware
>> description.  The SPI child device has already the same property with
>> the same value, so functionality should not be affected.
>>
>> [...]
> 
> Month passed, no replies from maintainers about picking it up. Dunno, looks
> abandoned, so let me grab this. If anyone else wants to pick it up, let me
> know.

Dropped now.

Best regards,
Krzysztof

Re: [PATCH] sh: j2: drop incorrect SPI controller max frequency property

[John Paul Adrian Glaubitz]

On Fri, 2024-03-22 at 07:42 +0100, Krzysztof Kozlowski wrote:
> The J2 SPI controller bindings never allowed spi-max-frequency property
> in the controller node.  Neither old spi-bus.txt bindings, nor new DT
> schema allows it.  Linux driver does not parse that property from
> controller node, thus drop it from DTS as incorrect hardware
> description.  The SPI child device has already the same property with
> the same value, so functionality should not be affected.
> 
> Cc: Kousik Sanagavarapu <five231003@gmail.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/sh/boot/dts/j2_mimas_v2.dts | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/sh/boot/dts/j2_mimas_v2.dts b/arch/sh/boot/dts/j2_mimas_v2.dts
> index fa9562f78d53..faf884f53804 100644
> --- a/arch/sh/boot/dts/j2_mimas_v2.dts
> +++ b/arch/sh/boot/dts/j2_mimas_v2.dts
> @@ -71,8 +71,6 @@ spi0: spi@40 {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  
> -			spi-max-frequency = <25000000>;
> -
>  			reg = <0x40 0x8>;
>  
>  			sdcard@0 {

It seems that spi-bus.txt has been replaced by spi-controller.yaml now, so
I think we should update the filename in the commit message, shouldn't we?

Besides that, I agree with the changes.

Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Re: [PATCH] sh: j2: drop incorrect SPI controller max frequency property

[Krzysztof Kozlowski]

On 29/04/2024 10:16, John Paul Adrian Glaubitz wrote:
> On Fri, 2024-03-22 at 07:42 +0100, Krzysztof Kozlowski wrote:
>> The J2 SPI controller bindings never allowed spi-max-frequency property
>> in the controller node.  Neither old spi-bus.txt bindings, nor new DT
>> schema allows it.  Linux driver does not parse that property from
>> controller node, thus drop it from DTS as incorrect hardware
>> description.  The SPI child device has already the same property with
>> the same value, so functionality should not be affected.
>>
>> Cc: Kousik Sanagavarapu <five231003@gmail.com>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  arch/sh/boot/dts/j2_mimas_v2.dts | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/sh/boot/dts/j2_mimas_v2.dts b/arch/sh/boot/dts/j2_mimas_v2.dts
>> index fa9562f78d53..faf884f53804 100644
>> --- a/arch/sh/boot/dts/j2_mimas_v2.dts
>> +++ b/arch/sh/boot/dts/j2_mimas_v2.dts
>> @@ -71,8 +71,6 @@ spi0: spi@40 {
>>  			#address-cells = <1>;
>>  			#size-cells = <0>;
>>  
>> -			spi-max-frequency = <25000000>;
>> -
>>  			reg = <0x40 0x8>;
>>  
>>  			sdcard@0 {
> 
> It seems that spi-bus.txt has been replaced by spi-controller.yaml now, so
> I think we should update the filename in the commit message, shouldn't we?

I think commit msg properly says what is old and what is new....

Best regards,
Krzysztof

Re: [PATCH] sh: j2: drop incorrect SPI controller max frequency property

[John Paul Adrian Glaubitz]

On Fri, 2024-03-22 at 07:42 +0100, Krzysztof Kozlowski wrote:
> The J2 SPI controller bindings never allowed spi-max-frequency property
> in the controller node.  Neither old spi-bus.txt bindings, nor new DT
> schema allows it.  Linux driver does not parse that property from
> controller node, thus drop it from DTS as incorrect hardware
> description.  The SPI child device has already the same property with
> the same value, so functionality should not be affected.
> 
> Cc: Kousik Sanagavarapu <five231003@gmail.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/sh/boot/dts/j2_mimas_v2.dts | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/sh/boot/dts/j2_mimas_v2.dts b/arch/sh/boot/dts/j2_mimas_v2.dts
> index fa9562f78d53..faf884f53804 100644
> --- a/arch/sh/boot/dts/j2_mimas_v2.dts
> +++ b/arch/sh/boot/dts/j2_mimas_v2.dts
> @@ -71,8 +71,6 @@ spi0: spi@40 {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  
> -			spi-max-frequency = <25000000>;
> -
>  			reg = <0x40 0x8>;
>  
>  			sdcard@0 {

Applied to my sh-linux tree in the for-next branch.

Thanks,
Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913