From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793158587; b=XQfH/487jg0oJAGVqFNzBOGyK8PVafpU5JL1OasI6NAveeAa51gRnRl7xrJqSM8lALOy Qn+NvUxD7xXdJwTw1oHSw/uoi8nLGhOC+arab0f4E6CR6euwOdcqc0pMqpqnrqC6nG45D pvYCrSvLxzJuDmu3Q2mWkerQq4QjaHahORAukoMQInjsqo8+Elpnf1rTbZvrdMqqKgw3m gpv/rodrfVpcxoJ4SS92SJYLa0ifyK3DVzwesNnkLT1V6ykLN6+fzom95YZsG7JLExZZU y81dvWRwWvKNWAe/8oS7mr55jGV3gDMFQXC7GqDNMWWRLm4L2yCqpb+DvDAcsAdJBDQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793158587; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-Spam-Details-Enc: X-Proofpoint-ORIG-GUID:X-Proofpoint-GUID:X-Proofpoint-Spam-Info: X-Authority-Analysis:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=/wKdshZSDdNYlVlGGww1CWjddpjIdb7CUnZ1PObkTB4=; b=DY/2fQ0YXMiPc64nZCnzGkcCLkkvFjnmmoQCo8BXPfIrXTTUv483XPCjbyDhXzwxksYS iCF36r48GVd3ofJVhRDV0guLctLevT4iHeWtwrcSYSUiXSZjPgtYSkp3Xc2YVCOBcCXxP DCNMSrVdAZwqAcXQkgicO+2BZMmGgHY9qH1xv1/cplkWONK9AEYCNxr6cv6z2xfeZ5bXA G3QaHmTSlIFAnbkXtH3X6jcDCQ2S2bwVnihiYtP3dZqKrFYW1HFfugldfYh+zyf2Fairi Vqebke1qUw+gY48yWnRhHg0RNff8mN8mVHOE2EjVeWfiw7+tErghjAk3+FM54fTwu7A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=Jve2qMQH; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=BBE0FowR; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DE0F606A31A for ; Wed, 28 Oct 2026 03:36:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8DE0F606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=Jve2qMQH; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=BBE0FowR Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69S0jAkl657952 for ; Wed, 28 Oct 2026 03:36:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /wKdshZSDdNYlVlGGww1CWjddpjIdb7CUnZ1PObkTB4=; b=Jve2qMQHUqrEssgK LflW6/l7KZ234zJVmm5v4avWWbV1TcUiioz11IU7xNAS3yhP+6JpgpsoOMhZWZvJ IPei/BNfJ7ExWg/tShStITm6QZsRQXDRsGswXFZFnq+o9ga6nmbSa33m3OhRLXWT jNycF1Ub6eUUeiAVgYu5ZaX6svI7KSL3EU6+K53Rnc/d554YMUVQJALzktVCxxiV q+Kz86xf3mp9SK5/sBZk8qiecR2lpX8aT+GhaHVmok95F2t7X+5DAAukw34dJtRr PnVGLMYR/XaeQ9zEg45sqiPgK2kxAakvx9jugL9konNgiu/4GNvqT3B3MXccU96s aGnIQQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hjyjpt5b8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 28 Oct 2026 03:36:25 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3acc98e3b3cso447323a91.3 for ; Tue, 27 Oct 2026 20:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793158585; x=1793763385; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/wKdshZSDdNYlVlGGww1CWjddpjIdb7CUnZ1PObkTB4=; b=BBE0FowRfn7sN6MDFhJ7FmlNiB3uKdW4e+cRAtWrblI7hD+YFhxqnPOU7tpzisVisJ fmEeD90BQvftfZDOccNtAFeLrBTZKfsyegXHwyV0wKlVgLTtCjMFc6HwG5NhJjm3k/C+ ad5+gAf9zgyISIfOxIIRVunXhv207IDJQjB94mq7+VI9MJMYMNRfO7jOns7wsvAz4bM9 5ba3tSHhD20XqsJaFz3v6Bl7rN6ldLh2ubAgecoEHWvl0MLS0obmwycPGmr2w1CBLAOI eJGZP1D+i5UMtAu5I0NHNr4aAyku+DE5UMfSHnXgokB2sdHVO6EIN0G+P9MH7O/MCHCQ 6nMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793158585; x=1793763385; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/wKdshZSDdNYlVlGGww1CWjddpjIdb7CUnZ1PObkTB4=; b=oayZ6OjvBCR6SxBDz33S+dOsxbaPWvCCV+28oI4vWLzyKoK0vOuFbP0JKrl2ZItnY1 PoYPTfJuqVIOfFrEm6tYXLorprS8xJ5CGA55hzCtzJKnOd0jOxmDt31bzBuxgm19Fdw3 dw+pVNxI4gavqqM/+j7CNBF7BOBc1BrhcLHo8thUeF9UqP0L5xKjqB9FvDfGZ54IqGhz 3O46e5v7pOKShe91K1gVXlf/NevQNetey0amcEFmcrxBoH4pKof7S8vR1w7yN8KLhw18 zljrLn+ofvBSBPOsNqg660KmJtToHoxKsFSE5BqCJb+NuplnTNMx48YsbLLdENpwjYg2 UUaw== X-Forwarded-Encrypted: i=1; AKwUvBxqe6FKQhCZQn38m9MD7OCdQ7DKIUMzlbSdUROlpY7zsJK8iJxuvhubDHz6rfA7bCiosv/3/PzrCw==@vger.kernel.org X-Gm-Message-State: AFq9FYIxlwrKDhjxQ+W8EpwdfZ2KbddmF5uOAnKXqSXTECu743VAxE2W kpvxFOT3qhp8r3y9CMWwnJdGvoI1pSf5WTWktx8Taa/eV/0F+tidabmpWSpnhW9te43Z6w2D4Di 9oQJoBCaZBt+drrpkmYqeHFdLCKEVhcN7MU410dBRfD74n80uMXMgPDolTT25JQ== X-Gm-Gg: AYBFou1E+gKMC7RWharQFg9MuOvK4aBukMjHpjP23eQY3zeU0j+Fp15d5uatIflnPKB ExqKXCzp/7CRuwXYcYBiPmFYldM2CgKuqjQix+kqJ5x5HPFEOpy1YI24g9GfvFYBvPAQTPZbyeC ySCoRMTmsxiJaySOImdbxJVG7o+x7NjEysZj3uoMSQizlIyNoL0VGVypI1+27Lyga87G6k5SQhI MrenH3Uatn2iGbBX3NxrqsZFUUKw95mcVBEq4oAKIeYCK8fa5gTpMdVB+bZ+rBiOLRvKdTG6hx6 ITvUlLyGSKfi96UI6t6N0V8opo4JwhlbO042Ca2Mi98UMrc63I/6pBJ9CJXSuKPCGY+gEg5BnH+ D7ZzVerPACpvnYHaot9Pw70hnousFNusUWqrN+TQ9y5gGpdDaDkdOgJUpThcyJITeGETF7g9zn7 u6R2BG4c51KpgjRCUWDL0q5fb2LuLdAE/CRJx61c3NrWo= X-Received: by 2002:a17:90b:5863:b0:3ac:b3ff:b476 with SMTP id 98e67ed59e1d1-3ae581836a6mr818157a91.38.1793158584982; Tue, 27 Oct 2026 20:36:24 -0700 (PDT) X-Received: by 2002:a17:90b:5863:b0:3ac:b3ff:b476 with SMTP id 98e67ed59e1d1-3ae581836a6mr818144a91.38.1793158584441; Tue, 27 Oct 2026 20:36:24 -0700 (PDT) Received: from [10.133.33.27] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ae5a48ec90sm899533a91.6.2026.10.27.20.36.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2026 20:36:24 -0700 (PDT) Message-ID: Date: Wed, 28 Oct 2026 11:36:16 +0800 X-Mailing-List: linux-sh@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/9] cpufreq: governor: Initialize kobj_type release callback statically To: Ian Rogers , Kees Cook , Greg Kroah-Hartman , Miguel Ojeda , "Rafael J . Wysocki" , Danilo Krummrich Cc: Nathan Chancellor , Nick Desaulniers , Miguel Ojeda , =?UTF-8?Q?Christian_K=C3=B6nig?= , Zhihao Cheng , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Viresh Kumar , zhongqiu.han@oss.qualcomm.com References: <20261027223847.652884-1-irogers@google.com> <20261027223847.652884-5-irogers@google.com> Content-Language: en-US From: Zhongqiu Han In-Reply-To: <20261027223847.652884-5-irogers@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDI4MDAxNCBTYWx0ZWRfX6r6tb2gTsVC1 0eXcb2ktic+cSM2L3TmTIUHrDb4ocmwAUxMwpE/MkIciQtYIKp2+elB7l3qbrksY50w7KKZG0UH /ay61g8xDrjkEVypAtrn3Qfz/OAichhUYmygORuPxtWNDXgBzmh5bE8YNYDVYmPURqBq8gEQhQL e2QuaPZ2QqY5zscb4JltKOanK+pPEYfhJjGI9lWf1gHNcCM8s4d+FB/nYefIQ4zSlf7dVcWQ/hp c6jiVnSnttsqnnhLGhkll8wr4C6IgT2pW9rlkFPqR2YMYaI5qyHUB7sF40I3oJG+jyJL9wHN4XK rffLbPqKeCea3QRVYRd2U8aQOXoTMiW6jJG0RqPH9avicxFmNGdIlYVKdsbqToHJqx7uMtYISHl uZR8YIyUWSrgIL3JiHN23ZUOKbASfAEuCgT9AJAVI3LRcwXHQQW50rzEG9ClyPntbL5MKdj5F52 wXcD4/P9SqQS32aF5EA== X-Proofpoint-ORIG-GUID: 3gl_7YtcVXqOu9IUxV8SW9dA7HI0-4gL X-Proofpoint-GUID: 3gl_7YtcVXqOu9IUxV8SW9dA7HI0-4gL X-Proofpoint-Spam-Info: AW1haW4tMjYxMDI4MDAxNCBTYWx0ZWRfX4t/yUOfYB4IO gDKanJNXP9Rl3QNVQ8QUuC8cevsr40l2cRsMVNwcoBkheYGb1N5fAr8Zo1x48nMLCJOrUtC9Wee ZyamNLr43FLJWoSoVQNlqijlc4JZrtw= X-Authority-Analysis: v=2.4 cv=JodkP84C c=1 sm=1 tr=0 ts=6ae16db9 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=1XWaLZrsAAAA:8 a=MbyaxBA4Lnn_ULkWIDkA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-28_01,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 malwarescore=0 bulkscore=0 suspectscore=0 priorityscore=1501 spamscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610280014 Hi Ian, Thanks for the update. On 10/28/2026 6:38 AM, Ian Rogers wrote: > Export cpufreq_dbs_data_release() and set .kobj_type.release statically > in the ondemand and conservative governors so their gov_attr_set > kobjects have a valid release callback statically initialized, matching > cpufreq_governor_dbs. Remove the redundant runtime assignment in "matching cpufreq_governor_dbs" is a bit confusing to me (cpufreq_governor_dbs() was removed back in v4.8 by commit e788892ba3cc ("cpufreq: governor: Get rid of governor events")), as it doesn't seem to refer to anything in the tree. Perhaps we could just drop it, e.g.: Export cpufreq_dbs_data_release() and initialize .kobj_type.release statically in the ondemand and conservative governors instead of assigning it at runtime in cpufreq_dbs_governor_init(). The code change itself looks good to me. With the changelog updated (in a respin if the series needs one for other reasons, or when applying): Reviewed-by: Zhongqiu Han > cpufreq_dbs_governor_init(). > > This prepares for annotating struct kobj_type::release with > __must_init. > > Signed-off-by: Ian Rogers > --- > drivers/cpufreq/cpufreq_conservative.c | 5 ++++- > drivers/cpufreq/cpufreq_governor.c | 4 ++-- > drivers/cpufreq/cpufreq_governor.h | 1 + > drivers/cpufreq/cpufreq_ondemand.c | 5 ++++- > 4 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/drivers/cpufreq/cpufreq_conservative.c b/drivers/cpufreq/cpufreq_conservative.c > index 02bfd46543e9..146a2353b1a2 100644 > --- a/drivers/cpufreq/cpufreq_conservative.c > +++ b/drivers/cpufreq/cpufreq_conservative.c > @@ -318,7 +318,10 @@ static void cs_limits(struct cpufreq_policy *policy) > > static struct dbs_governor cs_governor = { > .gov = CPUFREQ_DBS_GOVERNOR_INITIALIZER("conservative"), > - .kobj_type = { .default_groups = cs_groups }, > + .kobj_type = { > + .release = cpufreq_dbs_data_release, > + .default_groups = cs_groups, > + }, > .gov_dbs_update = cs_dbs_update, > .alloc = cs_alloc, > .free = cs_free, > diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c > index f3bd3dbe7c41..f8b5aca09b6b 100644 > --- a/drivers/cpufreq/cpufreq_governor.c > +++ b/drivers/cpufreq/cpufreq_governor.c > @@ -419,7 +419,7 @@ static void free_policy_dbs_info(struct policy_dbs_info *policy_dbs, > gov->free(policy_dbs); > } > > -static void cpufreq_dbs_data_release(struct kobject *kobj) > +void cpufreq_dbs_data_release(struct kobject *kobj) > { > struct dbs_data *dbs_data = to_dbs_data(to_gov_attr_set(kobj)); > struct dbs_governor *gov = dbs_data->gov; > @@ -427,6 +427,7 @@ static void cpufreq_dbs_data_release(struct kobject *kobj) > gov->exit(dbs_data); > kfree(dbs_data); > } > +EXPORT_SYMBOL_GPL(cpufreq_dbs_data_release); > > int cpufreq_dbs_governor_init(struct cpufreq_policy *policy) > { > @@ -488,7 +489,6 @@ int cpufreq_dbs_governor_init(struct cpufreq_policy *policy) > policy->governor_data = policy_dbs; > > gov->kobj_type.sysfs_ops = &governor_sysfs_ops; > - gov->kobj_type.release = cpufreq_dbs_data_release; > ret = kobject_init_and_add(&dbs_data->attr_set.kobj, &gov->kobj_type, > get_governor_parent_kobj(policy), > "%s", gov->gov.name); > diff --git a/drivers/cpufreq/cpufreq_governor.h b/drivers/cpufreq/cpufreq_governor.h > index 806d8fb4dff1..1026712bb79b 100644 > --- a/drivers/cpufreq/cpufreq_governor.h > +++ b/drivers/cpufreq/cpufreq_governor.h > @@ -150,6 +150,7 @@ static inline struct dbs_governor *dbs_governor_of(struct cpufreq_policy *policy > } > > /* Governor callback routines */ > +void cpufreq_dbs_data_release(struct kobject *kobj); > int cpufreq_dbs_governor_init(struct cpufreq_policy *policy); > void cpufreq_dbs_governor_exit(struct cpufreq_policy *policy); > int cpufreq_dbs_governor_start(struct cpufreq_policy *policy); > diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c > index 9942dbb38dae..7386d043c665 100644 > --- a/drivers/cpufreq/cpufreq_ondemand.c > +++ b/drivers/cpufreq/cpufreq_ondemand.c > @@ -374,7 +374,10 @@ static struct od_ops od_ops = { > > static struct dbs_governor od_dbs_gov = { > .gov = CPUFREQ_DBS_GOVERNOR_INITIALIZER("ondemand"), > - .kobj_type = { .default_groups = od_groups }, > + .kobj_type = { > + .release = cpufreq_dbs_data_release, > + .default_groups = od_groups, > + }, > .gov_dbs_update = od_dbs_update, > .alloc = od_alloc, > .free = od_free, -- Thx and BRs, Zhongqiu Han