From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Date: Thu, 09 Jul 2020 09:10:36 +0000 Subject: Re: [PATCH v3 3/6] sh/mm: use default dummy memory_add_physaddr_to_nid() Message-Id: List-Id: References: <20200709020629.91671-1-justin.he@arm.com> <20200709020629.91671-4-justin.he@arm.com> In-Reply-To: <20200709020629.91671-4-justin.he@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jia He , Catalin Marinas , Will Deacon , Tony Luck , Fenghua Yu , Yoshinori Sato , Rich Felker , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov Cc: Kaly Xin , Michal Hocko , Dave Jiang , Baoquan He , linux-sh@vger.kernel.org, Vishal Verma , Masahiro Yamada , x86@kernel.org, Chuhong Yuan , linux-kernel@vger.kernel.org, Mike Rapoport , linux-mm@kvack.org, linux-nvdimm@lists.01.org, Jonathan Cameron , "H. Peter Anvin" , linux-ia64@vger.kernel.org, Dan Williams , Logan Gunthorpe , Andrew Morton , linux-arm-kernel@lists.infradead.org On 09.07.20 04:06, Jia He wrote: > After making default memory_add_physaddr_to_nid in mm/memory_hotplug, > there is no use to define a similar one in arch specific directory. > > Signed-off-by: Jia He > --- > arch/sh/mm/init.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c > index a70ba0fdd0b3..f75932ba87a6 100644 > --- a/arch/sh/mm/init.c > +++ b/arch/sh/mm/init.c > @@ -430,15 +430,6 @@ int arch_add_memory(int nid, u64 start, u64 size, > return ret; > } > > -#ifdef CONFIG_NUMA > -int memory_add_physaddr_to_nid(u64 addr) > -{ > - /* Node 0 for now.. */ > - return 0; > -} > -EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid); > -#endif > - > void arch_remove_memory(int nid, u64 start, u64 size, > struct vmem_altmap *altmap) > { > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb