From: Krzysztof Kozlowski <krzk@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-sh@vger.kernel.org,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Subject: Re: [PATCH v4 09/37] dt-bindings: timer: renesas,tmu: add renesas,tmu-sh7750
Date: Wed, 15 Nov 2023 22:05:45 +0100 [thread overview]
Message-ID: <f5449de0-64d2-47cf-976b-91d305c4f146@kernel.org> (raw)
In-Reply-To: <CAMuHMdV-B1DY2kqSo+J_p8enzQxUkWzhL1x+HEC+52PoKHR33Q@mail.gmail.com>
On 15/11/2023 09:17, Geert Uytterhoeven wrote:
> Hi Krzysztof,
>
> On Tue, Nov 14, 2023 at 10:26 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On 14/11/2023 09:00, Yoshinori Sato wrote:
>>> Add SH7750 TMU entry.
>>>
>>> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
>
>>> diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml
>>> index a67e427a9e7e..925c2a691b25 100644
>>> --- a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml
>>> +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml
>>> @@ -21,6 +21,7 @@ properties:
>>> compatible:
>>> items:
>>> - enum:
>>> + - renesas,tmu-sh7750 # SH7750
>>> - renesas,tmu-r8a7740 # R-Mobile A1
>>> - renesas,tmu-r8a774a1 # RZ/G2M
>>> - renesas,tmu-r8a774b1 # RZ/G2N
>>> @@ -46,7 +47,14 @@ properties:
>>>
>>> interrupts:
>>> minItems: 2
>>> - maxItems: 3
>>> + maxItems: 4
>>> +
>>> + interrupt-names:
>>> + items:
>>> + - const: tuni0
>>> + - const: tuni1
>>> + - const: tuni2
>>> + - const: ticpi2
>>
>> Other variants should be constrained to three items.
>
> Actually that is not true: the number of interrupts depends on the
> instance, not on the SoC. The fourth interrupt is present on some
> instances on other SoCs, too, but was never described before, as the
> driver doesn't support it yet (I know this is not a good reason).
> Of course none of this is obvious to the casual reviewer if it is
> not mentioned in the patch description...
>
> I'm working on making this more clear, and adding support for missing
> variants.
OK, thanks for explanation.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-15 21:06 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 7:59 [PATCH v4 00/37] Device Tree support for SH7751 based board Yoshinori Sato
2023-11-14 7:59 ` [PATCH v4 01/37] sh: passing FDT address to kernel startup Yoshinori Sato
2023-11-14 8:44 ` Sergei Shtylyov
2023-11-14 7:59 ` [PATCH v4 02/37] sh: Kconfig unified OF supported targets Yoshinori Sato
2023-11-14 12:46 ` Arnd Bergmann
2023-11-14 7:59 ` [PATCH v4 03/37] sh: Enable OF support for build and configuration Yoshinori Sato
2023-11-14 7:59 ` [PATCH v4 04/37] dt-bindings: interrupt-controller: Add header for Renesas SH3/4 INTC Yoshinori Sato
2023-11-14 21:25 ` Krzysztof Kozlowski
2023-11-14 7:59 ` [PATCH v4 05/37] sh: GENERIC_IRQ_CHIP support for CONFIG_OF=y Yoshinori Sato
2023-11-14 7:59 ` [PATCH v4 06/37] sh: kernel/setup Update DT support Yoshinori Sato
2023-11-14 7:59 ` [PATCH v4 07/37] sh: Fix COMMON_CLK support in CONFIG_OF=y Yoshinori Sato
2023-11-14 7:59 ` [PATCH v4 08/37] clocksource: sh_tmu: CLOCKSOURCE support Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 09/37] dt-bindings: timer: renesas,tmu: add renesas,tmu-sh7750 Yoshinori Sato
2023-11-14 21:26 ` Krzysztof Kozlowski
2023-11-15 8:17 ` Geert Uytterhoeven
2023-11-15 21:05 ` Krzysztof Kozlowski [this message]
2023-11-14 8:00 ` [PATCH v4 10/37] sh: Common PCI framework support Yoshinori Sato
2023-11-14 13:03 ` Arnd Bergmann
2023-11-14 8:00 ` [PATCH v4 11/37] sh: Add old PCI drivers compatible stub Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 12/37] pci: pci-sh7751: Add SH7751 PCI driver Yoshinori Sato
2023-11-20 18:16 ` Bjorn Helgaas
2023-11-14 8:00 ` [PATCH v4 13/37] dt-bindings: pci: pci-sh7751: Add SH7751 PCI Yoshinori Sato
2023-11-14 21:27 ` Krzysztof Kozlowski
2023-11-14 8:00 ` [PATCH v4 14/37] dt-bindings: clock: sh7750-cpg: Add renesas,sh7750-cpg header Yoshinori Sato
2023-11-14 21:29 ` Krzysztof Kozlowski
2023-11-14 8:00 ` [PATCH v4 15/37] clk: Compatible with narrow registers Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 16/37] clk: renesas: Add SH7750/7751 CPG Driver Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 17/37] irqchip: Add SH7751 INTC driver Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 18/37] dt-bindings: interrupt-controller: renesas,sh7751-intc: Add json-schema Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 19/37] irqchip: SH7751 IRL external encoder with enable gate Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 20/37] dt-bindings: interrupt-controller: renesas,sh7751-irl-ext: Add json-schema Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 21/37] serial: sh-sci: fix SH4 OF support Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 22/37] dt-bindings: serial: renesas,scif: Add scif-sh7751 Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 23/37] dt-bindings: display: smi,sm501: SMI SM501 binding json-schema Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 24/37] mfd: sm501: Convert platform_data to OF property Yoshinori Sato
2023-11-23 13:59 ` Lee Jones
2023-11-14 8:00 ` [PATCH v4 25/37] dt-binding: sh: cpus: Add SH CPUs json-schema Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 26/37] dt-bindings: vendor-prefix: Add new vendor iodata and smi Yoshinori Sato
2023-11-14 16:35 ` Geert Uytterhoeven
2023-11-14 8:00 ` [PATCH v4 27/37] dt-bindings: ata: ata-generic: Add new targets Yoshinori Sato
2023-11-14 18:19 ` Rob Herring
2023-11-14 8:00 ` [PATCH v4 28/37] dt-bindings: soc: renesas: sh: Add SH7751 based target Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 29/37] sh: SH7751R SoC Internal peripheral definition dtsi Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 30/37] sh: add RTS7751R2D Plus DTS Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 31/37] sh: Add IO DATA LANDISK dts Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 32/37] sh: Add IO DATA USL-5P dts Yoshinori Sato
2023-11-14 9:02 ` Sergei Shtylyov
2023-11-14 9:04 ` Sergei Shtylyov
2023-11-14 8:00 ` [PATCH v4 33/37] sh: j2_mimas_v2.dts update Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 34/37] sh: Add dtbs target support Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 35/37] sh: RTS7751R2D Plus OF defconfig Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 36/37] sh: LANDISK " Yoshinori Sato
2023-11-14 8:00 ` [PATCH v4 37/37] sh: j2_defconfig: update Yoshinori Sato
2023-11-14 8:58 ` [PATCH v4 00/37] Device Tree support for SH7751 based board John Paul Adrian Glaubitz
2023-11-14 18:39 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5449de0-64d2-47cf-976b-91d305c4f146@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox