Re: [PATCH 2/8] SH: add DMA slave IDs for two SDHI controllers, add

[Magnus Damm <magnus.damm@gmail.com>]

Hi Guennadi,

On Wed, Apr 21, 2010 at 11:36 AM, Guennadi Liakhovetski
<g.liakhovetski@gmx.de> wrote:
> SuperH SDHI controllers can use DMA, add slave IDs to the header and slave
> definitions to sh7722.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
>  arch/sh/include/asm/dmaengine.h        |    4 ++++
>  arch/sh/kernel/cpu/sh4a/setup-sh7722.c |   10 ++++++++++
>  2 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/arch/sh/include/asm/dmaengine.h b/arch/sh/include/asm/dmaengine.h
> index 2a02b61..876e601 100644
> --- a/arch/sh/include/asm/dmaengine.h
> +++ b/arch/sh/include/asm/dmaengine.h
> @@ -29,6 +29,10 @@ enum {
>        SHDMA_SLAVE_SIUA_RX,
>        SHDMA_SLAVE_SIUB_TX,
>        SHDMA_SLAVE_SIUB_RX,
> +       SHDMA_SLAVE_SDHI0_RX,
> +       SHDMA_SLAVE_SDHI0_TX,
> +       SHDMA_SLAVE_SDHI1_RX,
> +       SHDMA_SLAVE_SDHI1_TX,
>  };
>
>  #endif

Thanks for your work on this. Two SDHIs may be enough for most
processor types, but I think the G3 processor actually has three. With
that in mind, I think it makes more sense to keep the slave ids
together with the processor specific bits in for instance
arch/sh/include/cpu-sh4/cpu/sh7722.h.

If you have time, can you please make a patch that moves the slave ids
into the processor specific header files? This on top of the other
code in the sh/dmaengine topic branch.

With that in place it will be easy to extend each processor type by
itself without having to tie in dependencies on a single asm file.

Thanks,

/ magnus