* [PATCH] mmc: SDHI should depend on SUPERH || ARCH_SHMOBILE [not found] <20110328131018.96742ebb.sfr@canb.auug.org.au> @ 2011-03-28 7:16 ` Guennadi Liakhovetski 2011-03-28 13:39 ` Chris Ball 0 siblings, 1 reply; 2+ messages in thread From: Guennadi Liakhovetski @ 2011-03-28 7:16 UTC (permalink / raw) To: Stephen Rothwell Cc: Chris Ball, linux-next, linux-kernel, linux-sh, linux-mmc Fix build breakage on platforms, not providing readsw and writesw functions, e.g., on x86(_64). Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> --- Subject: Re: linux-next: build failure after merge of the mmc tree On Mon, 28 Mar 2011, Stephen Rothwell wrote: > Hi Chris, > > After merging the mmc tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > drivers/mmc/host/tmio_mmc_pio.c: In function 'sd_ctrl_read16_rep': > drivers/mmc/host/tmio_mmc_pio.c:56: error: implicit declaration of function 'readsw' > drivers/mmc/host/tmio_mmc_pio.c: In function 'sd_ctrl_write16_rep': > drivers/mmc/host/tmio_mmc_pio.c:73: error: implicit declaration of function 'writesw' > > Presumably caused by commit b6147490e6aa ("mmc: tmio: split core > functionality, DMA and MFD glue"). > > I have used the mmc tree from next-20110325 for tdoay. Stephen, please verify, that this fixes your problem. drivers/mmc/host/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index 0b03cee..94df405 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig @@ -452,6 +452,7 @@ config MMC_TMIO config MMC_SDHI tristate "SH-Mobile SDHI SD/SDIO controller support" + depends on SUPERH || ARCH_SHMOBILE select MMC_TMIO_CORE help This provides support for the SDHI SD/SDIO controller found in -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: SDHI should depend on SUPERH || ARCH_SHMOBILE 2011-03-28 7:16 ` [PATCH] mmc: SDHI should depend on SUPERH || ARCH_SHMOBILE Guennadi Liakhovetski @ 2011-03-28 13:39 ` Chris Ball 0 siblings, 0 replies; 2+ messages in thread From: Chris Ball @ 2011-03-28 13:39 UTC (permalink / raw) To: Guennadi Liakhovetski Cc: Stephen Rothwell, linux-next, linux-kernel, linux-sh, linux-mmc Hi, On Mon, Mar 28 2011, Guennadi Liakhovetski wrote: > Fix build breakage on platforms, not providing readsw and writesw > functions, e.g., on x86(_64). > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > --- > > Subject: Re: linux-next: build failure after merge of the mmc tree > > On Mon, 28 Mar 2011, Stephen Rothwell wrote: > >> Hi Chris, >> >> After merging the mmc tree, today's linux-next build (x86_64 allmodconfig) >> failed like this: >> >> drivers/mmc/host/tmio_mmc_pio.c: In function 'sd_ctrl_read16_rep': >> drivers/mmc/host/tmio_mmc_pio.c:56: error: implicit declaration of function 'readsw' >> drivers/mmc/host/tmio_mmc_pio.c: In function 'sd_ctrl_write16_rep': >> drivers/mmc/host/tmio_mmc_pio.c:73: error: implicit declaration of function 'writesw' >> >> Presumably caused by commit b6147490e6aa ("mmc: tmio: split core >> functionality, DMA and MFD glue"). >> >> I have used the mmc tree from next-20110325 for tdoay. > > Stephen, please verify, that this fixes your problem. I've verified the fix and pushed it to mmc-next, so this should be fixed tomorrow. Thanks! - Chris. -- Chris Ball <cjb@laptop.org> <http://printf.net/> One Laptop Per Child ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-28 13:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20110328131018.96742ebb.sfr@canb.auug.org.au>
2011-03-28 7:16 ` [PATCH] mmc: SDHI should depend on SUPERH || ARCH_SHMOBILE Guennadi Liakhovetski
2011-03-28 13:39 ` Chris Ball
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).