* Re: [PATCH v3 29/81] ARM: shmobile: sh73a0: Add pin control resources
From: Simon Horman @ 2012-12-18 2:16 UTC (permalink / raw)
To: linux-sh
In-Reply-To: <1355611915-25060-30-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Sat, Dec 15, 2012 at 11:51:03PM +0100, Laurent Pinchart wrote:
> Add memory resources for the pin control platform device to let the
> sh-pfc driver ioremap() registers properly instead of evily casting
> register physical addresses to virtual addresses.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Acked-by: Paul Mundt <lethal@linux-sh.org>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply
* Re: [PATCH v3 28/81] ARM: shmobile: sh7372: Add pin control resources
From: Simon Horman @ 2012-12-18 2:16 UTC (permalink / raw)
To: linux-sh
In-Reply-To: <1355611915-25060-29-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Sat, Dec 15, 2012 at 11:51:02PM +0100, Laurent Pinchart wrote:
> Add memory resources for the pin control platform device to let the
> sh-pfc driver ioremap() registers properly instead of evily casting
> register physical addresses to virtual addresses.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Acked-by: Paul Mundt <lethal@linux-sh.org>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply
* Re: [PATCH v3 51/81] ARM: shmobile: r8a7740: Use driver-provided pinmux info
From: Simon Horman @ 2012-12-18 2:18 UTC (permalink / raw)
To: linux-sh
In-Reply-To: <1355611915-25060-52-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Sat, Dec 15, 2012 at 11:51:25PM +0100, Laurent Pinchart wrote:
> Pinmux info for the r8a7740 is now provided by pinmux drivers. Remove
> the duplicate copy in arch code.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm/mach-shmobile/Makefile | 1 -
> arch/arm/mach-shmobile/pfc-r8a7740.c | 2643 --------------------------------
> arch/arm/mach-shmobile/setup-r8a7740.c | 26 +
> 3 files changed, 26 insertions(+), 2644 deletions(-)
> delete mode 100644 arch/arm/mach-shmobile/pfc-r8a7740.c
Code reduction, excellent!
Acked-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply
* Re: [PATCH v3 53/81] ARM: shmobile: sh7372: Use driver-provided pinmux info
From: Simon Horman @ 2012-12-18 2:18 UTC (permalink / raw)
To: linux-sh
In-Reply-To: <1355611915-25060-54-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Sat, Dec 15, 2012 at 11:51:27PM +0100, Laurent Pinchart wrote:
> Pinmux info for the sh7372 is now provided by pinmux drivers. Remove the
> duplicate copy in arch code.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm/mach-shmobile/Makefile | 1 -
> arch/arm/mach-shmobile/pfc-sh7372.c | 1689 ---------------------------------
> arch/arm/mach-shmobile/setup-sh7372.c | 26 +
> 3 files changed, 26 insertions(+), 1690 deletions(-)
> delete mode 100644 arch/arm/mach-shmobile/pfc-sh7372.c
Acked-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply
* Re: [PATCH v3 54/81] ARM: shmobile: sh73a0: Use driver-provided pinmux info
From: Simon Horman @ 2012-12-18 2:18 UTC (permalink / raw)
To: linux-sh
In-Reply-To: <1355611915-25060-55-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Sat, Dec 15, 2012 at 11:51:28PM +0100, Laurent Pinchart wrote:
> Pinmux info for the sh73a0 is now provided by pinmux drivers. Remove the
> duplicate copy in arch code.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm/mach-shmobile/Makefile | 5 -
> arch/arm/mach-shmobile/pfc-sh73a0.c | 2829 ---------------------------------
> arch/arm/mach-shmobile/setup-sh73a0.c | 25 +
> 3 files changed, 25 insertions(+), 2834 deletions(-)
> delete mode 100644 arch/arm/mach-shmobile/pfc-sh73a0.c
Acked-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply
* Re: [PATCH v3 52/81] ARM: shmobile: r8a7779: Use driver-provided pinmux info
From: Simon Horman @ 2012-12-18 2:19 UTC (permalink / raw)
To: linux-sh
On Sat, Dec 15, 2012 at 11:51:26PM +0100, Laurent Pinchart wrote:
> Pinmux info for the r8a7779 is now provided by pinmux drivers. Remove
> the duplicate copy in arch code.
Acked-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply
* Re: [PATCH v3 48/81] sh-pfc: Add r8a7779 pinmux support
From: Simon Horman @ 2012-12-18 2:21 UTC (permalink / raw)
To: linux-sh
On Sat, Dec 15, 2012 at 11:51:22PM +0100, Laurent Pinchart wrote:
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Acked-by: Paul Mundt <lethal@linux-sh.org>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply
* Re: [PATCH v3 50/81] sh-pfc: Add sh73a0 pinmux support
From: Simon Horman @ 2012-12-18 2:22 UTC (permalink / raw)
To: linux-sh
In-Reply-To: <1355611915-25060-51-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Sat, Dec 15, 2012 at 11:51:24PM +0100, Laurent Pinchart wrote:
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Acked-by: Paul Mundt <lethal@linux-sh.org>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply
* Re: [PATCH v3 49/81] sh-pfc: Add sh7372 pinmux support
From: Simon Horman @ 2012-12-18 2:23 UTC (permalink / raw)
To: linux-sh
In-Reply-To: <1355611915-25060-50-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Sat, Dec 15, 2012 at 11:51:23PM +0100, Laurent Pinchart wrote:
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Acked-by: Paul Mundt <lethal@linux-sh.org>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply
* Re: [PATCH v3 47/81] sh-pfc: Add r8a7740 pinmux support
From: Simon Horman @ 2012-12-18 2:23 UTC (permalink / raw)
To: linux-sh
In-Reply-To: <1355611915-25060-48-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Sat, Dec 15, 2012 at 11:51:21PM +0100, Laurent Pinchart wrote:
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Acked-by: Paul Mundt <lethal@linux-sh.org>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply
* Re: [PATCH] ARM: shmobile: r8a7779: Fix PFC - MOD_SEL2 missed an entry
From: Simon Horman @ 2012-12-18 2:36 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <1353601737-21641-1-git-send-email-phil.edworthy@renesas.com>
On Thu, Nov 22, 2012 at 04:28:57PM +0000, Phil Edworthy wrote:
> The list of functions selected by the MOD_SEL2 register was missing
> an entry. This caused all entries after this to modify the MOD_SEL2
> register incorrectly.
Laurent, can you handle this in your series?
I believe it removes this file.
>
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> ---
> arch/arm/mach-shmobile/pfc-r8a7779.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/pfc-r8a7779.c b/arch/arm/mach-shmobile/pfc-r8a7779.c
> index 9fac32e4..15f6a48 100644
> --- a/arch/arm/mach-shmobile/pfc-r8a7779.c
> +++ b/arch/arm/mach-shmobile/pfc-r8a7779.c
> @@ -2525,7 +2525,7 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = {
> /* SEL_SCIF [2] */
> FN_SEL_SCIF_0, FN_SEL_SCIF_1, FN_SEL_SCIF_2, FN_SEL_SCIF_3,
> /* SEL_CANCLK [2] */
> - FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2,
> + FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2, 0,
> /* SEL_CAN0 [1] */
> FN_SEL_CAN0_0, FN_SEL_CAN0_1,
> /* SEL_HSCIF1 [1] */
> --
> 1.7.5.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply
* Re: [PATCH] ARM: shmobile: r8a7779: Fix PFC - MOD_SEL2 missed an entry
From: Simon Horman @ 2012-12-18 3:51 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20121218023610.GV28065@verge.net.au>
On Tue, Dec 18, 2012 at 11:36:10AM +0900, Simon Horman wrote:
> On Thu, Nov 22, 2012 at 04:28:57PM +0000, Phil Edworthy wrote:
> > The list of functions selected by the MOD_SEL2 register was missing
> > an entry. This caused all entries after this to modify the MOD_SEL2
> > register incorrectly.
>
> Laurent, can you handle this in your series?
> I believe it removes this file.
Sorry, I missed the fact that this is for stable.
Laurent, can you handle upstream and I'll handle stable?
> > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> > ---
> > arch/arm/mach-shmobile/pfc-r8a7779.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-shmobile/pfc-r8a7779.c b/arch/arm/mach-shmobile/pfc-r8a7779.c
> > index 9fac32e4..15f6a48 100644
> > --- a/arch/arm/mach-shmobile/pfc-r8a7779.c
> > +++ b/arch/arm/mach-shmobile/pfc-r8a7779.c
> > @@ -2525,7 +2525,7 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = {
> > /* SEL_SCIF [2] */
> > FN_SEL_SCIF_0, FN_SEL_SCIF_1, FN_SEL_SCIF_2, FN_SEL_SCIF_3,
> > /* SEL_CANCLK [2] */
> > - FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2,
> > + FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2, 0,
> > /* SEL_CAN0 [1] */
> > FN_SEL_CAN0_0, FN_SEL_CAN0_1,
> > /* SEL_HSCIF1 [1] */
> > --
> > 1.7.5.4
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply
* Re: [PATCH] ARM: shmobile: r8a7779: Fix PFC - MOD_SEL2 missed an entry
From: Simon Horman @ 2012-12-18 4:28 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20121218035144.GC13353@verge.net.au>
On Tue, Dec 18, 2012 at 12:51:44PM +0900, Simon Horman wrote:
> On Tue, Dec 18, 2012 at 11:36:10AM +0900, Simon Horman wrote:
> > On Thu, Nov 22, 2012 at 04:28:57PM +0000, Phil Edworthy wrote:
> > > The list of functions selected by the MOD_SEL2 register was missing
> > > an entry. This caused all entries after this to modify the MOD_SEL2
> > > register incorrectly.
> >
> > Laurent, can you handle this in your series?
> > I believe it removes this file.
>
> Sorry, I missed the fact that this is for stable.
> Laurent, can you handle upstream and I'll handle stable?
Sorry, yet another thing.
Phil, could you explain what problems manifest at for users without this
change? To be included in stable it is important that it solves a problem
that actually manifests.
> > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> > > ---
> > > arch/arm/mach-shmobile/pfc-r8a7779.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-shmobile/pfc-r8a7779.c b/arch/arm/mach-shmobile/pfc-r8a7779.c
> > > index 9fac32e4..15f6a48 100644
> > > --- a/arch/arm/mach-shmobile/pfc-r8a7779.c
> > > +++ b/arch/arm/mach-shmobile/pfc-r8a7779.c
> > > @@ -2525,7 +2525,7 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = {
> > > /* SEL_SCIF [2] */
> > > FN_SEL_SCIF_0, FN_SEL_SCIF_1, FN_SEL_SCIF_2, FN_SEL_SCIF_3,
> > > /* SEL_CANCLK [2] */
> > > - FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2,
> > > + FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2, 0,
> > > /* SEL_CAN0 [1] */
> > > FN_SEL_CAN0_0, FN_SEL_CAN0_1,
> > > /* SEL_HSCIF1 [1] */
> > > --
> > > 1.7.5.4
> > >
> > >
> > > _______________________________________________
> > > linux-arm-kernel mailing list
> > > linux-arm-kernel@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> > >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply
* Re: [PATCH] ARM: shmobile: r8a7779: Fix PFC - MOD_SEL2 missed an entry
From: Laurent Pinchart @ 2012-12-18 6:50 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20121218042854.GH29354@verge.net.au>
Hi Simon,
On Tuesday 18 December 2012 13:28:54 Simon Horman wrote:
> On Tue, Dec 18, 2012 at 12:51:44PM +0900, Simon Horman wrote:
> > On Tue, Dec 18, 2012 at 11:36:10AM +0900, Simon Horman wrote:
> > > On Thu, Nov 22, 2012 at 04:28:57PM +0000, Phil Edworthy wrote:
> > > > The list of functions selected by the MOD_SEL2 register was missing
> > > > an entry. This caused all entries after this to modify the MOD_SEL2
> > > > register incorrectly.
> > >
> > > Laurent, can you handle this in your series?
> > > I believe it removes this file.
> >
> > Sorry, I missed the fact that this is for stable.
> > Laurent, can you handle upstream and I'll handle stable?
Sure. I've added the patch to my tree.
> Sorry, yet another thing.
>
> Phil, could you explain what problems manifest at for users without this
> change? To be included in stable it is important that it solves a problem
> that actually manifests.
>
> > > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> > > > ---
> > > >
> > > > arch/arm/mach-shmobile/pfc-r8a7779.c | 2 +-
> > > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > > >
> > > > diff --git a/arch/arm/mach-shmobile/pfc-r8a7779.c
> > > > b/arch/arm/mach-shmobile/pfc-r8a7779.c index 9fac32e4..15f6a48 100644
> > > > --- a/arch/arm/mach-shmobile/pfc-r8a7779.c
> > > > +++ b/arch/arm/mach-shmobile/pfc-r8a7779.c
> > > > @@ -2525,7 +2525,7 @@ static struct pinmux_cfg_reg
> > > > pinmux_config_regs[] = {
> > > >
> > > > /* SEL_SCIF [2] */
> > > > FN_SEL_SCIF_0, FN_SEL_SCIF_1, FN_SEL_SCIF_2, FN_SEL_SCIF_3,
> > > > /* SEL_CANCLK [2] */
> > > >
> > > > - FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2,
> > > > + FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2, 0,
> > > >
> > > > /* SEL_CAN0 [1] */
> > > > FN_SEL_CAN0_0, FN_SEL_CAN0_1,
> > > > /* SEL_HSCIF1 [1] */
--
Regards,
Laurent Pinchart
^ permalink raw reply
* Re: [PATCH 05/10] ARM: shmobile: Add DT table of INTC for sh7372
From: Guennadi Liakhovetski @ 2012-12-18 9:34 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20121218003717.GI7146@verge.net.au>
Hi Simon
On Tue, 18 Dec 2012, Simon Horman wrote:
> On Mon, Dec 17, 2012 at 09:44:10AM +0100, Guennadi Liakhovetski wrote:
> > Hi Simon
> >
> > On Sat, 15 Dec 2012, Simon Horman wrote:
> >
> > > From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> > >
> > > Cc: Magnus Damm <damm@opensource.se>
> > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >
> > What happened to intcs support? Why has it been dropped? Without it many
> > important devices cannot be set up from DT, e.g. I2C #0.
>
> INTCS support is still being worked on and doesn't seem to be
> quite ready yet. I am aware that this limits the usefulness of
> this series. But it is a step in the right direction.
What are the problems with it? My patch series uses INTCS support from the
previous version of this patch-set, so, now, without INTCS, I'll have to
remove from .dts I2C0 and all devices on it.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply
* Re: [PATCH] ARM: shmobile: r8a7779: Fix PFC - MOD_SEL2 missed an entry
From: phil.edworthy @ 2012-12-18 9:58 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20121218042854.GH29354@verge.net.au>
Hi Simon,
> On Tue, Dec 18, 2012 at 12:51:44PM +0900, Simon Horman wrote:
> > On Tue, Dec 18, 2012 at 11:36:10AM +0900, Simon Horman wrote:
> > > On Thu, Nov 22, 2012 at 04:28:57PM +0000, Phil Edworthy wrote:
> > > > The list of functions selected by the MOD_SEL2 register was
missing
> > > > an entry. This caused all entries after this to modify the
MOD_SEL2
> > > > register incorrectly.
> > >
> > > Laurent, can you handle this in your series?
> > > I believe it removes this file.
> >
> > Sorry, I missed the fact that this is for stable.
> > Laurent, can you handle upstream and I'll handle stable?
>
> Sorry, yet another thing.
>
> Phil, could you explain what problems manifest at for users without this
> change? To be included in stable it is important that it solves a
problem
> that actually manifests.
If the user requests certain pin functionality (e.g. any HSPI2_B pins such
as GPIO_FN_HSPI_CLK2_B), the MOD_SEL2 register won't be set up correctly,
so it won't work. I am not sure if that warrants going onto stable or not
- your call!
Thanks
Phil
^ permalink raw reply
* Re: [PATCH 01/10] ARM: shmobile: Add support OF for INTC of shmobile
From: Mark Rutland @ 2012-12-18 10:00 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <1355562224-29448-2-git-send-email-horms+renesas@verge.net.au>
Hi,
I have some comments on the devicetree binding.
On Sat, Dec 15, 2012 at 09:03:35AM +0000, Simon Horman wrote:
> From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>
> This provides OF support of SH/INTC.
>
> The SH/INTC driver is used by SuperH and ARM/SH-MOBILE.
> At the moment, SuperH does not have the plan corresponding to DT.
> DT of SH/INTC has taken the form where the table data of the C
> is managed by DT, in order to maintain compatibility.
>
> Cc: Magnus Damm <damm@opensource.se>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> Documentation/devicetree/bindings/sh/intc.txt | 163 +++++++
> drivers/sh/intc/Makefile | 1 +
> drivers/sh/intc/of_intc.c | 647 +++++++++++++++++++++++++
> include/linux/sh_intc.h | 83 ++++
> 4 files changed, 894 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sh/intc.txt
> create mode 100644 drivers/sh/intc/of_intc.c
>
> diff --git a/Documentation/devicetree/bindings/sh/intc.txt b/Documentation/devicetree/bindings/sh/intc.txt
> new file mode 100644
> index 0000000..ebb2398
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sh/intc.txt
> @@ -0,0 +1,163 @@
> +* Renesas SuperH / SH-MOBILE Interrupt Controller
> +
> +The SH/INTC driver is used by SuperH and ARM/SH-MOBILE.
> +At the moment, SuperH does not have the plan corresponding to DT.
> +DT of SH/INTC has taken the form where the table data of the C
> +is managed by DT, in order to maintain compatibility.
> +
> +Main node required properties:
> +
> +- compatible : should be one of:
> + "renesas,sh_intca"
> + "renesas,sh_intcs"
> + "renesas,sh_intca_irq_pins"
Typically compatible strings use '-' rather than '_'.
> +
> +- interrupt-controller : Identifies the node as an interrupt controller
> +- #interrupt-cells : Set already 1.
> +- #address-cells : Set already 1.
> +- #size-cells : Set already 1.
I'm not quite sure what "Set already 1" means. Perhaps these should say "Must be 1" ?
> +- ranges : Non value.
This confused me, but I see it's a standard property. It's probably worth
noting why it's required, e.g. "ranges : empty as we have a 1-1 mapping to
parent's address space".
> +- reg : Specifies base physical address(s) and size of the INTC
> + registers.
Presumably these registers are not identical, and the order is important. This
order should be specified.
> +- intsrc* : This sets up the vector for every device.
I'm not sure what this means. If this has a well-defined meaning for the
device, it may be worth having a link to some additional documentation from the
binding doc.
> +- *_registers : There are vector table, mask, priority, ack, and sense
> + register in INTC. In order to hold these data, it is
> + necessary to set up the following contents.
> +
> + -- intc_vectors: This needs to have vector_table.
> + This specifies phandle which intsrc* defined.
> +
> + -- intc_mask_registers : This specifies the contents of the mask register.
> + This node required properties:
> + * address-cells : Set already 1.
> + * size-cells : Set already 1.
Are #address-cells and #size-cells not inherited from the parent node?
> + * ranges : Non value.
> + * intc_mask* : This has regs and reginfo.
> + ** reg : This specifies the address of mask register. First specifies
> + mask register, and 2nd specifies mask clear register.
> + First cell is address, and 2nd sell is address size. 1 is 8bit.
> + 2 is 16bit, 4 is 32bit.
Saying "address size" here is very confusing, as it sounds like you're
re-inventing the #address-cells property. I assume you mean the register size? If so
just say the size must be 1, 2, or 4 bytes.
Also, s/sell/cell/
> + ** reginfo: This specifies phandle of devices.
Which devices?
> +
> + -- intc_prio_registers : This sets up the contents of the priority register.
> + This node required properties:
> + * address-cells : Set already 1.
> + * size-cells : Set already 1.
> + * ranges : Non value.
> + * intc_prio*: This has regs and reginfo.
> + ** reg : This specifies the address of priority register. First specifies
> + priority set register, and 2nd specifies priority clear register.
> + If there is not priority clear register, specifies 0x00.
> + First cell is address, and 2nd sell is address size. 1 is 8bit.
> + 2 is 16bit, 4 is 32bit.
If there is not a priority clear register, why not only describe the priority
set register?
The absence of a second set of reg cells will tell you it's not present, and
will be easier to spot when reading the dts.
> + ** field-width : Bit size is specified for every device.
> + ** reginfo: This specifies phandle of devices.
> +
> + -- intc_sense_registers : This sets up the contents of the sense register.
> + This node required properties:
> + * address-cells : Set already 1.
> + * size-cells : Set already 1.
> + * ranges : Non value.
> + * intc_sense*: This has regs and reginfo.
> + ** reg : This specifies the address of sense register.
> + First cell is address, and 2nd sell is address size. 1 is 8bit.
> + 2 is 16bit, 4 is 32bit.
> + ** field-width : Bit size is specified for every device.
> + ** reginfo: This specifies phandle of devices.
> +
> +-- intc_ack_registers : This sets up the contents of the ACK register.
> + This node required properties:
> + * address-cells : Set already 1.
> + * size-cells : Set already 1.
> + * ranges : Non value.
> + * intc_ack*: This has regs and reginfo.
> + ** reg : This specifies the address of ack register.
> + First cell is address, and 2nd sell is address size. 1 is 8bit.
> + 2 is 16bit, 4 is 32bit.
> + ** reginfo: This specifies phandle of devices.
> +
> +Optional:
> +
> +- group_size : If this INTC register has Group, set up this value.
What does this specify? The number of intc_group nodes?
If so, can this not be omitted and calculated by counting intc_group nodes?
> +- intc_group* : This needs to have group, If INTC device have group.
> + This node required properties:
> + * group : This specifies the address phandle of group.
> + For example, when TMU1 of priority regisdter is sharing with TMU1_0,
> + TMU1_1 and TMU1_2, it describes like below.
> +
> + TMU1: intc_group2 { group = <&TMU1_0 &TMU1_1 &TMU1_2>; };
> +
> + And the phandle is specified as priority regisdter.
s/regisdter/register/
> +
> + intc_prio11 {
> + reg = <0xffd50030 2>, <0x0 0>;
> + field-width = <4>;
> + reginfo = <&TMU1 0 0 0>;
These 0s at the end of the reginfo property, why are they required? They were
not described in the rest of the binding documentation.
> + };
> +
> +- intc_intevtsa : This set up the contents of INTEVTSA.
> + This node required properties:
> + * vector : This specifies the address phandle of INTCS.
> +
> +Note:
> +- "renesas,sh_intca" needs group_size, intc_group*, intc_vectors,
> + intc_mask_registers and intc_prio_registers.
> +- "renesas,sh_intcs" needs group_size, intc_group*, intc_vectors,
> + intc_mask_registers, intc_prio_registers and intc_intevtsa.
> +- "renesas,sh_intca_irq_pins" needs intc_vectors, intc_mask_registers,
> + intc_prio_registers, intc_sense_registers and intc_ack_registers.
> +
> +Example:
> +
> + intca: interrupt-controller@0 {
> + compatible = "renesas,sh_intca";
> + interrupt-controller;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + #interrupt-cells = <1>;
> + ranges;
> +
> + reg = <0xe6940000 0x200>, <0xe6950000 0x200>;
> + group_size = <19>;
> +
> + DIRC: intsrc1 { vector = <0x0560>; };
> + ATAPI: intsrc2 { vector = <0x05E0>; };
> + ....
> +
> + DMAC1_1: intc_group0 { group = <&DMAC1_1_DEI0 &DMAC1_1_DEI1
> + &DMAC1_1_DEI2 &DMAC1_1_DEI3>; };
> + DMAC1_2: intc_group1 { group = <&DMAC1_2_DEI4 &DMAC1_2_DEI5
> + &DMAC1_2_DADERR>; };
> + ....
> + intc_vectors {
> + vector_table = <&DIRC &ATAPI &IIC1_ALI &IIC1_TACKI &IIC1_WAITI,
> + ....
> + };
> +
> + intc_mask_registers {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + intc_mask0 {
> + reg = <0xe6940080 1>, <0xe69400c0 1>;
> + reginfo = <&DMAC2_1_DEI3 &DMAC2_1_DEI2 &DMAC2_1_DEI1
> + &DMAC2_1_DEI0 0 0 &AP_ARM_COMMTX &AP_ARM_COMMRX>;
> + };
> + ....
> + };
> +
> + intc_prio_registers {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + intc_prio0 {
> + reg = <0xe6940000 2>, <0x0 0>;
> + field-width = <4>;
> + reginfo = <&DMAC3_1 &DMAC3_2 &CMT2 &ICBS0>;
> + };
> + ....
> + };
> + };
[...]
Thanks,
Mark.
^ permalink raw reply
* [PATCH 0/2] Armadillo DT Reference Implementation
From: Bastian Hecht @ 2012-12-18 17:22 UTC (permalink / raw)
To: linux-arm-kernel
This is the design approch of Simon Horman's kzm9g implementation transferred
to the Armadillo board.
It is based on the branch next of
git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git
and was tested on the branch devel/of of
git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git
For the ethernet controller to work the series assumes the patch
net: sh_eth: Add support of device tree probe
http://patchwork.ozlabs.org/patch/191713/ to be applied.
Bastian Hecht (2):
ARM: r8a7740: Add interim sh-eth device name to clocks list
ARM: shmobile: armadillo800eva: Reference DT implementation
arch/arm/boot/dts/Makefile | 1 +
.../boot/dts/r8a7740-armadillo800eva-reference.dts | 33 ++++
arch/arm/mach-shmobile/Kconfig | 10 ++
arch/arm/mach-shmobile/Makefile | 1 +
.../board-armadillo800eva-reference.c | 172 ++++++++++++++++++++
arch/arm/mach-shmobile/clock-r8a7740.c | 1 +
arch/arm/mach-shmobile/include/mach/common.h | 2 +
7 files changed, 220 insertions(+)
create mode 100644 arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
create mode 100644 arch/arm/mach-shmobile/board-armadillo800eva-reference.c
--
1.7.9.5
^ permalink raw reply
* [PATCH 1/2] ARM: r8a7740: Add interim sh-eth device name to clocks list
From: Bastian Hecht @ 2012-12-18 17:22 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <1355851359-8871-1-git-send-email-hechtb+renesas@gmail.com>
When we use the ethernet device via DT setup, we need to add it
to a lookup list until this is properly handled later in a DT-only
fashion.
Signed-off-by: Bastian Hecht <hechtb+renesas@gmail.com>
---
arch/arm/mach-shmobile/clock-r8a7740.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-shmobile/clock-r8a7740.c b/arch/arm/mach-shmobile/clock-r8a7740.c
index 19ce885..8765a76 100644
--- a/arch/arm/mach-shmobile/clock-r8a7740.c
+++ b/arch/arm/mach-shmobile/clock-r8a7740.c
@@ -614,6 +614,7 @@ static struct clk_lookup lookups[] = {
CLKDEV_DEV_ID("sh_mobile_sdhi.1", &mstp_clks[MSTP313]),
CLKDEV_DEV_ID("sh_mmcif", &mstp_clks[MSTP312]),
CLKDEV_DEV_ID("sh-eth", &mstp_clks[MSTP309]),
+ CLKDEV_DEV_ID("e9a00000.sh-eth", &mstp_clks[MSTP309]),
CLKDEV_DEV_ID("sh_mobile_sdhi.2", &mstp_clks[MSTP415]),
--
1.7.9.5
^ permalink raw reply related
* [PATCH 2/2] ARM: shmobile: armadillo800eva: Reference DT implementation
From: Bastian Hecht @ 2012-12-18 17:22 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <1355851359-8871-1-git-send-email-hechtb+renesas@gmail.com>
Provide alternate board code for the Armadillo 800 EVA to
demonstrate how DT may be used given the current state of
driver device tree support. This is intended to act as a
reference for mach-shmobile developers.
This is based on Simon Horman's reference implementation for
the board kzm9g.
Currently only the ethernet controller is brought up.
Signed-off-by: Bastian Hecht <hechtb+renesas@gmail.com>
---
arch/arm/boot/dts/Makefile | 1 +
.../boot/dts/r8a7740-armadillo800eva-reference.dts | 33 ++++
arch/arm/mach-shmobile/Kconfig | 10 ++
arch/arm/mach-shmobile/Makefile | 1 +
.../board-armadillo800eva-reference.c | 172 ++++++++++++++++++++
arch/arm/mach-shmobile/include/mach/common.h | 2 +
6 files changed, 219 insertions(+)
create mode 100644 arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
create mode 100644 arch/arm/mach-shmobile/board-armadillo800eva-reference.c
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 0632239..8338bcc 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -75,6 +75,7 @@ dtb-$(CONFIG_ARCH_PRIMA2) += prima2-evb.dtb
dtb-$(CONFIG_ARCH_U8500) += snowball.dtb
dtb-$(CONFIG_ARCH_SHMOBILE) += emev2-kzm9d.dtb \
r8a7740-armadillo800eva.dtb \
+ r8a7740-armadillo800eva-reference.dtb \
sh73a0-kzm9g.dtb \
sh7372-mackerel.dtb
dtb-$(CONFIG_ARCH_SPEAR13XX) += spear1310-evb.dtb \
diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
new file mode 100644
index 0000000..5b5afd3
--- /dev/null
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
@@ -0,0 +1,33 @@
+/*
+ * Reference Device Tree Source for the armadillo 800 eva board
+ *
+ * Copyright (C) 2012 Renesas Solutions Corp.
+ *
+ * This file is licensed under the terms of the GNU General Public License
+ * version 2. This program is licensed "as is" without any warranty of any
+ * kind, whether express or implied.
+ */
+
+/dts-v1/;
+/include/ "r8a7740.dtsi"
+
+/ {
+ model = "armadillo 800 eva";
+ compatible = "renesas,armadillo800eva-reference", "renesas,r8a7740";
+
+ memory {
+ device_type = "memory";
+ reg = <0x40000000 0x20000000>;
+ };
+
+ sh-eth@e9a00000 {
+ compatible = "renesas,sh-eth";
+ interrupt-parent = <&intca>;
+ reg = <0xe9a00000 0x800>, <0xe9a01800 0x800>;
+ interrupts = <0x500>;
+ phy-mode = "mii";
+ sh-eth,edmac-endian = "little";
+ sh-eth,register-type = "gigabit";
+ sh-eth,phy-id = <0>;
+ };
+};
diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig
index 9255546..6766752 100644
--- a/arch/arm/mach-shmobile/Kconfig
+++ b/arch/arm/mach-shmobile/Kconfig
@@ -96,6 +96,16 @@ config MACH_ARMADILLO800EVA
select SND_SOC_WM8978 if SND_SIMPLE_CARD
select USE_OF
+config MACH_ARMADILLO800EVA_REFERENCE
+ bool "Armadillo-800 EVA board - Reference Device Tree Implementation"
+ depends on MACH_ARMADILLO800EVA
+ ---help---
+ Use reference implementation of Aramdillo800 EVA board support
+ which makes a greater use of device tree at the expense
+ of not supporting a number of devices.
+
+ This is intended to aid developers
+
config MACH_MARZEN
bool "MARZEN board"
depends on ARCH_R8A7779
diff --git a/arch/arm/mach-shmobile/Makefile b/arch/arm/mach-shmobile/Makefile
index 0b71479..87fdc64 100644
--- a/arch/arm/mach-shmobile/Makefile
+++ b/arch/arm/mach-shmobile/Makefile
@@ -46,6 +46,7 @@ obj-$(CONFIG_MACH_KOTA2) += board-kota2.o
obj-$(CONFIG_MACH_BONITO) += board-bonito.o
obj-$(CONFIG_MACH_MARZEN) += board-marzen.o
obj-$(CONFIG_MACH_ARMADILLO800EVA) += board-armadillo800eva.o
+obj-$(CONFIG_MACH_ARMADILLO800EVA_REFERENCE) += board-armadillo800eva-reference.o
obj-$(CONFIG_MACH_KZM9D) += board-kzm9d.o
obj-$(CONFIG_MACH_KZM9G) += board-kzm9g.o
diff --git a/arch/arm/mach-shmobile/board-armadillo800eva-reference.c b/arch/arm/mach-shmobile/board-armadillo800eva-reference.c
new file mode 100644
index 0000000..644f2de
--- /dev/null
+++ b/arch/arm/mach-shmobile/board-armadillo800eva-reference.c
@@ -0,0 +1,172 @@
+/*
+ * armadillo 800 eva board support - Interim Reference Device Tree Implementation
+ * This will be merged to board-armadillo800eva.c when DT support is complete
+ *
+ * Copyright (C) 2012 Bastian Hecht <hechtb+renesas@gmail.com>
+ *
+ * based on the reference implementation of the board kzm9g from Simon Horman
+ * and board-armadilloeva800.c
+ * Copyright (C) 2012 Renesas Solutions Corp.
+ * Copyright (C) 2012 Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+ *
+ */
+
+#include <linux/kernel.h>
+#include <linux/gpio.h>
+#include <linux/io.h>
+#include <linux/irq.h>
+#include <mach/common.h>
+#include <mach/r8a7740.h>
+#include <asm/mach/arch.h>
+#include <asm/hardware/cache-l2x0.h>
+
+/*
+ * CON1 Camera Module
+ * CON2 Extension Bus
+ * CON3 HDMI Output
+ * CON4 Composite Video Output
+ * CON5 H-UDI JTAG
+ * CON6 ARM JTAG
+ * CON7 SD1
+ * CON8 SD2
+ * CON9 RTC BackUp
+ * CON10 Monaural Mic Input
+ * CON11 Stereo Headphone Output
+ * CON12 Audio Line Output(L)
+ * CON13 Audio Line Output(R)
+ * CON14 AWL13 Module
+ * CON15 Extension
+ * CON16 LCD1
+ * CON17 LCD2
+ * CON19 Power Input
+ * CON20 USB1
+ * CON21 USB2
+ * CON22 Serial
+ * CON23 LAN
+ * CON24 USB3
+ * LED1 Camera LED(Yellow)
+ * LED2 Power LED (Green)
+ * ED3-LED6 User LED(Yellow)
+ * LED7 LAN link LED(Green)
+ * LED8 LAN activity LED(Yellow)
+ */
+
+/*
+ * DipSwitch
+ *
+ * SW1
+ *
+ * -12345678-+---------------+----------------------------
+ * 1 | boot | hermit
+ * 0 | boot | OS auto boot
+ * -12345678-+---------------+----------------------------
+ * 00 | boot device | eMMC
+ * 10 | boot device | SDHI0 (CON7)
+ * 01 | boot device | -
+ * 11 | boot device | Extension Buss (CS0)
+ * -12345678-+---------------+----------------------------
+ * 0 | Extension Bus | D8-D15 disable, eMMC enable
+ * 1 | Extension Bus | D8-D15 enable, eMMC disable
+ * -12345678-+---------------+----------------------------
+ * 0 | SDHI1 | COM8 disable, COM14 enable
+ * 1 | SDHI1 | COM8 enable, COM14 disable
+ * -12345678-+---------------+----------------------------
+ * 0 | USB0 | COM20 enable, COM24 disable
+ * 1 | USB0 | COM20 disable, COM24 enable
+ * -12345678-+---------------+----------------------------
+ * 00 | JTAG | SH-X2
+ * 10 | JTAG | ARM
+ * 01 | JTAG | -
+ * 11 | JTAG | Boundary Scan
+ *-----------+---------------+----------------------------
+ */
+
+/*
+ * FSI-WM8978
+ *
+ * this command is required when playback.
+ *
+ * # amixer set "Headphone" 50
+ */
+
+/*
+ * board init
+ */
+static void __init eva_init(void)
+{
+ r8a7740_pinmux_init();
+ r8a7740_meram_workaround();
+
+ /* SCIFA1 */
+ gpio_request(GPIO_FN_SCIFA1_RXD, NULL);
+ gpio_request(GPIO_FN_SCIFA1_TXD, NULL);
+
+ /* GETHER */
+ gpio_request(GPIO_FN_ET_CRS, NULL);
+ gpio_request(GPIO_FN_ET_MDC, NULL);
+ gpio_request(GPIO_FN_ET_MDIO, NULL);
+ gpio_request(GPIO_FN_ET_TX_ER, NULL);
+ gpio_request(GPIO_FN_ET_RX_ER, NULL);
+ gpio_request(GPIO_FN_ET_ERXD0, NULL);
+ gpio_request(GPIO_FN_ET_ERXD1, NULL);
+ gpio_request(GPIO_FN_ET_ERXD2, NULL);
+ gpio_request(GPIO_FN_ET_ERXD3, NULL);
+ gpio_request(GPIO_FN_ET_TX_CLK, NULL);
+ gpio_request(GPIO_FN_ET_TX_EN, NULL);
+ gpio_request(GPIO_FN_ET_ETXD0, NULL);
+ gpio_request(GPIO_FN_ET_ETXD1, NULL);
+ gpio_request(GPIO_FN_ET_ETXD2, NULL);
+ gpio_request(GPIO_FN_ET_ETXD3, NULL);
+ gpio_request(GPIO_FN_ET_PHY_INT, NULL);
+ gpio_request(GPIO_FN_ET_COL, NULL);
+ gpio_request(GPIO_FN_ET_RX_DV, NULL);
+ gpio_request(GPIO_FN_ET_RX_CLK, NULL);
+
+ gpio_request(GPIO_PORT18, NULL); /* PHY_RST */
+ gpio_direction_output(GPIO_PORT18, 1);
+
+#ifdef CONFIG_CACHE_L2X0
+ /* Early BRESP enable, Shared attribute override enable, 32K*8way */
+ l2x0_init(IOMEM(0xf0002000), 0x40440000, 0x82000fff);
+#endif
+
+ r8a7740_add_standard_devices_dt();
+}
+
+#define RESCNT2 IOMEM(0xe6188020)
+static void eva_restart(char mode, const char *cmd)
+{
+ /* Do soft power on reset */
+ writel((1 << 31), RESCNT2);
+}
+
+static const char *eva_boards_compat_dt[] __initdata = {
+ "renesas,armadillo800eva-reference",
+ NULL,
+};
+
+DT_MACHINE_START(ARMADILLO800EVA_DT, "armadillo800eva-reference")
+ .map_io = r8a7740_map_io,
+ .init_early = r8a7740_add_early_devices_dt,
+ .init_irq = r8a7740_init_irq_of,
+ .nr_irqs = NR_IRQS_LEGACY,
+ .handle_irq = shmobile_handle_irq_intc,
+ .init_machine = eva_init,
+ .init_late = shmobile_init_late,
+ .timer = &shmobile_timer,
+ .dt_compat = eva_boards_compat_dt,
+ .restart = eva_restart,
+MACHINE_END
diff --git a/arch/arm/mach-shmobile/include/mach/common.h b/arch/arm/mach-shmobile/include/mach/common.h
index dfeca79..9249459 100644
--- a/arch/arm/mach-shmobile/include/mach/common.h
+++ b/arch/arm/mach-shmobile/include/mach/common.h
@@ -44,7 +44,9 @@ extern struct clk sh73a0_extalr_clk;
extern void r8a7740_init_irq(void);
extern void r8a7740_map_io(void);
extern void r8a7740_add_early_devices(void);
+extern void r8a7740_add_early_devices_dt(void);
extern void r8a7740_add_standard_devices(void);
+extern void r8a7740_add_standard_devices_dt(void);
extern void r8a7740_clock_init(u8 md_ck);
extern void r8a7740_pinmux_init(void);
--
1.7.9.5
^ permalink raw reply related
* Re: [PATCH] ARM: shmobile: r8a7779: Fix PFC - MOD_SEL2 missed an entry
From: Simon Horman @ 2012-12-19 1:49 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <OFBEDBF9C1.A0917823-ON80257AD8.0034C56B-80257AD8.0036CE31@eu.necel.com>
On Tue, Dec 18, 2012 at 09:58:35AM +0000, phil.edworthy@renesas.com wrote:
> Hi Simon,
>
> > On Tue, Dec 18, 2012 at 12:51:44PM +0900, Simon Horman wrote:
> > > On Tue, Dec 18, 2012 at 11:36:10AM +0900, Simon Horman wrote:
> > > > On Thu, Nov 22, 2012 at 04:28:57PM +0000, Phil Edworthy wrote:
> > > > > The list of functions selected by the MOD_SEL2 register was
> missing
> > > > > an entry. This caused all entries after this to modify the
> MOD_SEL2
> > > > > register incorrectly.
> > > >
> > > > Laurent, can you handle this in your series?
> > > > I believe it removes this file.
> > >
> > > Sorry, I missed the fact that this is for stable.
> > > Laurent, can you handle upstream and I'll handle stable?
> >
> > Sorry, yet another thing.
> >
> > Phil, could you explain what problems manifest at for users without this
> > change? To be included in stable it is important that it solves a
> problem
> > that actually manifests.
>
> If the user requests certain pin functionality (e.g. any HSPI2_B pins such
> as GPIO_FN_HSPI_CLK2_B), the MOD_SEL2 register won't be set up correctly,
> so it won't work. I am not sure if that warrants going onto stable or not
> - your call!
Thanks. At this stage I think that it isn't stable material.
Regardless, I will see about getting the fix included in 3.8.
^ permalink raw reply
* Re: [PATCH 1/2] ARM: r8a7740: Add interim sh-eth device name to clocks list
From: Guennadi Liakhovetski @ 2012-12-19 9:10 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <1355851359-8871-2-git-send-email-hechtb+renesas@gmail.com>
Hi Bastian
Thanks for the patch.
On Tue, 18 Dec 2012, Bastian Hecht wrote:
> When we use the ethernet device via DT setup, we need to add it
> to a lookup list until this is properly handled later in a DT-only
> fashion.
>
> Signed-off-by: Bastian Hecht <hechtb+renesas@gmail.com>
> ---
> arch/arm/mach-shmobile/clock-r8a7740.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-shmobile/clock-r8a7740.c b/arch/arm/mach-shmobile/clock-r8a7740.c
> index 19ce885..8765a76 100644
> --- a/arch/arm/mach-shmobile/clock-r8a7740.c
> +++ b/arch/arm/mach-shmobile/clock-r8a7740.c
> @@ -614,6 +614,7 @@ static struct clk_lookup lookups[] = {
> CLKDEV_DEV_ID("sh_mobile_sdhi.1", &mstp_clks[MSTP313]),
> CLKDEV_DEV_ID("sh_mmcif", &mstp_clks[MSTP312]),
> CLKDEV_DEV_ID("sh-eth", &mstp_clks[MSTP309]),
> + CLKDEV_DEV_ID("e9a00000.sh-eth", &mstp_clks[MSTP309]),
In a recent thread
http://thread.gmane.org/gmane.linux.ports.sh.devel/18062/focus\x18057
I've been suggested to use OF_DEV_AUXDATA(), isn't this also a case for
it?
Thanks
Guennadi
>
> CLKDEV_DEV_ID("sh_mobile_sdhi.2", &mstp_clks[MSTP415]),
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply
* Re: [PATCH 1/2] ARM: r8a7740: Add interim sh-eth device name to clocks list
From: Magnus Damm @ 2012-12-19 10:50 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <Pine.LNX.4.64.1212191005280.12389@axis700.grange>
On Wed, Dec 19, 2012 at 6:10 PM, Guennadi Liakhovetski
<g.liakhovetski@gmx.de> wrote:
> Hi Bastian
>
> Thanks for the patch.
>
> On Tue, 18 Dec 2012, Bastian Hecht wrote:
>
>> When we use the ethernet device via DT setup, we need to add it
>> to a lookup list until this is properly handled later in a DT-only
>> fashion.
>>
>> Signed-off-by: Bastian Hecht <hechtb+renesas@gmail.com>
>> ---
>> arch/arm/mach-shmobile/clock-r8a7740.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/mach-shmobile/clock-r8a7740.c b/arch/arm/mach-shmobile/clock-r8a7740.c
>> index 19ce885..8765a76 100644
>> --- a/arch/arm/mach-shmobile/clock-r8a7740.c
>> +++ b/arch/arm/mach-shmobile/clock-r8a7740.c
>> @@ -614,6 +614,7 @@ static struct clk_lookup lookups[] = {
>> CLKDEV_DEV_ID("sh_mobile_sdhi.1", &mstp_clks[MSTP313]),
>> CLKDEV_DEV_ID("sh_mmcif", &mstp_clks[MSTP312]),
>> CLKDEV_DEV_ID("sh-eth", &mstp_clks[MSTP309]),
>> + CLKDEV_DEV_ID("e9a00000.sh-eth", &mstp_clks[MSTP309]),
>
> In a recent thread
>
> http://thread.gmane.org/gmane.linux.ports.sh.devel/18062/focus\x18057
>
> I've been suggested to use OF_DEV_AUXDATA(), isn't this also a case for
> it?
AUXDATA seems to be a great way to add a platform data pointer as a
workaround while implementing DT support, but when it comes to
translate the name based on base address the code becomes very
verbose.
I am all for going with the simplest half-way solution that uses the
least amount of lines of code, but I doubt it can get any simpler than
a single line of CLKDEV_DEV_ID().
Thanks,
/ magnus
^ permalink raw reply
* Re: [PATCH v3 00/81] SH pin control and GPIO rework
From: Linus Walleij @ 2012-12-19 15:31 UTC (permalink / raw)
To: linux-sh
In-Reply-To: <1355611915-25060-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Sat, Dec 15, 2012 at 11:50 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> I would like to push this set to v3.9 independently of the later rework and
> OF-related sets. Linus and Simon, which tree would you like me to push this
> through ?
The pinctrl or sh tree obviously :-)
Basically if you believe there will be colissions with other stuff in
the sh tree
it should go in through that tree. Obviously there is little risk of collissions
in the pinctrl tree as this is a new driver.
You can add my Acked-by: to the entire patch set, since the result at
the end is super-nice.
I think there were review comments of mine that were not fixed yet,
but I trust you to go through that and fix it up as time goes by.
Yours,
Linus Walleij
^ permalink raw reply
* Re: [PATCH 1/4 v2] spi: sh-msiof: Remove unneeded clock name
From: Grant Likely @ 2012-12-19 16:37 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <1355313289-29769-1-git-send-email-hechtb+renesas@gmail.com>
On Wed, 12 Dec 2012 12:54:46 +0100, Bastian Hecht <hechtb@gmail.com> wrote:
> From: Bastian Hecht <hechtb@gmail.com>
>
> clk_get() no longer needs a character string for associating the right
> clock as this is done via the device struct now.
>
> Signed-off-by: Bastian Hecht <hechtb+renesas@gmail.com>
This change is already in mainline.
g.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox