From: Magnus Damm <magnus.damm@gmail.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: "linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
linux-mmc@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Ian Molton <ian@mnementh.co.uk>
Subject: Re: [PATCH 5/8] SH: Add SDHI DMA support to ecovec
Date: Thu, 22 Apr 2010 00:16:29 +0000 [thread overview]
Message-ID: <p2iaec7e5c31004211716z430581dfn9a695537d4d8489a@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1004211734460.5292@axis700.grange>
On Wed, Apr 21, 2010 at 11:37 AM, Guennadi Liakhovetski
<g.liakhovetski@gmx.de> wrote:
> @@ -442,6 +444,8 @@ static void sdhi0_set_pwr(struct platform_device *pdev, int state)
> }
>
> static struct sh_mobile_sdhi_info sdhi0_info = {
> + .dma_slave_tx = SHDMA_SLAVE_SDHI0_TX,
> + .dma_slave_rx = SHDMA_SLAVE_SDHI0_RX,
> .set_pwr = sdhi0_set_pwr,
> };
>
> @@ -478,6 +482,9 @@ static void sdhi1_set_pwr(struct platform_device *pdev, int state)
> }
>
> static struct sh_mobile_sdhi_info sdhi1_info = {
> + .dma_slave_tx = SHDMA_SLAVE_SDHI1_TX,
> + .dma_slave_rx = SHDMA_SLAVE_SDHI1_RX,
> + .tmio_flags = TMIO_DEFER_RX_COMPLETE,
This is a bit odd. How come SDHI1 needs this flag and SDHI0 doesn't?
/ magnus
next prev parent reply other threads:[~2010-04-22 0:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 15:36 [PATCH 0/8] add DMA support to tmio_mmc, using dmaengine API, use Guennadi Liakhovetski
2010-04-21 15:36 ` [PATCH 1/8] SH: constify multiple DMA related objects and references Guennadi Liakhovetski
2010-04-26 7:10 ` [PATCH 1/8] SH: constify multiple DMA related objects and references to them Paul Mundt
2010-04-21 15:36 ` [PATCH 2/8] SH: add DMA slave IDs for two SDHI controllers, add Guennadi Liakhovetski
2010-04-22 0:02 ` Magnus Damm
2010-04-22 6:28 ` Guennadi Liakhovetski
2010-04-22 7:05 ` Magnus Damm
2010-04-22 9:38 ` Guennadi Liakhovetski
2010-04-21 15:36 ` [PATCH 3/8] SH: add DMA slave definitions to sh7724 Guennadi Liakhovetski
2010-04-21 15:37 ` [PATCH 4/8] MMC: add DMA support to tmio_mmc driver, when used on Guennadi Liakhovetski
2010-04-22 0:12 ` Magnus Damm
2010-04-22 9:51 ` [PATCH 4/8] MMC: add DMA support to tmio_mmc driver, when used Guennadi Liakhovetski
2010-04-21 15:37 ` [PATCH 5/8] SH: Add SDHI DMA support to ecovec Guennadi Liakhovetski
2010-04-22 0:16 ` Magnus Damm [this message]
2010-04-21 15:37 ` [PATCH 6/8] SH: Add SDHI DMA support to ms7724se Guennadi Liakhovetski
2010-04-22 0:18 ` Magnus Damm
2010-04-22 6:20 ` Guennadi Liakhovetski
2010-04-21 15:37 ` [PATCH 7/8] SH: Add SDHI DMA support to kfr2r09 Guennadi Liakhovetski
2010-04-21 15:37 ` [PATCH 8/8] SH: Add SDHI DMA support to migor Guennadi Liakhovetski
2010-04-27 10:38 ` [PATCH 0/8] add DMA support to tmio_mmc, using dmaengine API, Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p2iaec7e5c31004211716z430581dfn9a695537d4d8489a@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=g.liakhovetski@gmx.de \
--cc=ian@mnementh.co.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).