From: Takashi Iwai <tiwai@suse.de>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 4/7] ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*
Date: Tue, 06 Aug 2019 06:00:11 +0000 [thread overview]
Message-ID: <s5h5znaq1ec.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190805091159.7826-5-hch@lst.de>
On Tue, 06 Aug 2019 07:29:49 +0200,
Christoph Hellwig wrote:
>
> On Mon, Aug 05, 2019 at 11:22:03AM +0200, Takashi Iwai wrote:
> > This won't work as expected, unfortunately. It's a bit tricky check,
> > since the driver may have its own mmap implementation via
> > substream->ops->mmap, and the dma_buffer.dev.dev might point to
> > another object depending on the dma_buffer.dev.type.
> >
> > So please replace with something like below:
>
> >From my gut feeling I'd reorder it a bit to make it more clear like
> this:
>
> http://git.infradead.org/users/hch/misc.git/commitdiff/958fccf54d00c16740522f818d23f9350498e911
>
> if this is fine it'll be in the next version, waiting for a little more
> feedback on the other patches.
Yes, the new one looks good.
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Thanks!
Takashi
prev parent reply other threads:[~2019-08-06 6:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 9:11 [PATCH 4/7] ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_* Christoph Hellwig
2019-08-05 9:22 ` Takashi Iwai
2019-08-06 5:29 ` Christoph Hellwig
2019-08-06 6:00 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h5znaq1ec.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox