From: Kuninori Morimoto <morimoto.kuninori@renesas.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: sh7724 clock framework rewrite
Date: Wed, 03 Jun 2009 05:04:01 +0000 [thread overview]
Message-ID: <uiqjdj4ce.wl%morimoto.kuninori@renesas.com> (raw)
In-Reply-To: <20090602103459.13411.85023.sendpatchset@rx1.opensource.se>
Dear Magnus
thank you for nice patch.
on new clock-sh7724.c
> +static unsigned long pll_recalc(struct clk *clk)
> +{
> + return clk->parent->rate * (((__raw_readl(FRQCRA) >> 24) & 0x3f) + 1);
> +}
sh7724 needs "* 2" here.
please check old clock-sh7722.c
> -#if defined(CONFIG_CPU_SUBTYPE_SH7724)
> -#define STCPLL(frqcr) ((((frqcr >> 24) & 0x3f) + 1) * 2)
> -#else
> #define STCPLL(frqcr) (((frqcr >> 24) & 0x1f) + 1)
> -#endif
If I add "*2" here, It works =).
Best regards
--
Kuninori Morimoto
next prev parent reply other threads:[~2009-06-03 5:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 10:34 [PATCH] sh: sh7724 clock framework rewrite Magnus Damm
2009-06-03 5:04 ` Kuninori Morimoto [this message]
2009-06-03 8:43 ` [PATCH] sh: sh7724 clock framework rewrite V2 Magnus Damm
2009-06-04 7:53 ` [PATCH] sh: sh7724 clock framework rewrite Magnus Damm
2009-06-04 8:08 ` Kuninori Morimoto
2009-06-08 10:03 ` [PATCH] sh: sh7724 clock framework rewrite V2 Kuninori Morimoto
2009-06-09 8:04 ` Magnus Damm
2009-06-10 11:31 ` [PATCH] sh: sh7724 clock framework rewrite V3 Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uiqjdj4ce.wl%morimoto.kuninori@renesas.com \
--to=morimoto.kuninori@renesas.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox