* [PATCH] fbdev: sh-mobile_hdmi: remove un-necessity settings
@ 2010-08-27 10:15 Kuninori Morimoto
0 siblings, 0 replies; 2+ messages in thread
From: Kuninori Morimoto @ 2010-08-27 10:15 UTC (permalink / raw)
To: linux-sh
Current gamut, acp, isrc1, isrc2 settings are wrong,
and not necessary for now.
Tested-by: Takanari Hayama <taki@igel.co.jp>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
drivers/video/sh_mobile_hdmi.c | 106 ----------------------------------------
1 files changed, 0 insertions(+), 106 deletions(-)
diff --git a/drivers/video/sh_mobile_hdmi.c b/drivers/video/sh_mobile_hdmi.c
index 2fde08c..afebe80 100644
--- a/drivers/video/sh_mobile_hdmi.c
+++ b/drivers/video/sh_mobile_hdmi.c
@@ -519,100 +519,6 @@ static void sh_hdmi_audio_infoframe_setup(struct sh_hdmi *hdmi)
}
/**
- * sh_hdmi_gamut_metadata_setup() - Gamut Metadata Packet of CONTROL PACKET
- */
-static void sh_hdmi_gamut_metadata_setup(struct sh_hdmi *hdmi)
-{
- int i;
-
- /* Gamut Metadata Packet */
- hdmi_write(hdmi, 0x04, HDMI_CTRL_PKT_BUF_INDEX);
-
- /* Packet Type = 0x0A */
- hdmi_write(hdmi, 0x0A, HDMI_CTRL_PKT_BUF_ACCESS_HB0);
- /* Gamut Packet is not used, so default value */
- hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_HB1);
- /* Gamut Packet is not used, so default value */
- hdmi_write(hdmi, 0x10, HDMI_CTRL_PKT_BUF_ACCESS_HB2);
-
- /* GBD bytes 0 through 27 */
- for (i = 0; i <= 27; i++)
- /* HDMI_CTRL_PKT_BUF_ACCESS_PB0_63H - PB27_7EH */
- hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_PB0 + i);
-}
-
-/**
- * sh_hdmi_acp_setup() - Audio Content Protection Packet (ACP)
- */
-static void sh_hdmi_acp_setup(struct sh_hdmi *hdmi)
-{
- int i;
-
- /* Audio Content Protection Packet (ACP) */
- hdmi_write(hdmi, 0x01, HDMI_CTRL_PKT_BUF_INDEX);
-
- /* Packet Type = 0x04 */
- hdmi_write(hdmi, 0x04, HDMI_CTRL_PKT_BUF_ACCESS_HB0);
- /* ACP_Type */
- hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_HB1);
- /* Reserved (0) */
- hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_HB2);
-
- /* GBD bytes 0 through 27 */
- for (i = 0; i <= 27; i++)
- /* HDMI_CTRL_PKT_BUF_ACCESS_PB0 - PB27 */
- hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_PB0 + i);
-}
-
-/**
- * sh_hdmi_isrc1_setup() - ISRC1 Packet
- */
-static void sh_hdmi_isrc1_setup(struct sh_hdmi *hdmi)
-{
- int i;
-
- /* ISRC1 Packet */
- hdmi_write(hdmi, 0x02, HDMI_CTRL_PKT_BUF_INDEX);
-
- /* Packet Type = 0x05 */
- hdmi_write(hdmi, 0x05, HDMI_CTRL_PKT_BUF_ACCESS_HB0);
- /* ISRC_Cont, ISRC_Valid, Reserved (0), ISRC_Status */
- hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_HB1);
- /* Reserved (0) */
- hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_HB2);
-
- /* PB0 UPC_EAN_ISRC_0-15 */
- /* Bytes PB16-PB27 shall be set to a value of 0. */
- for (i = 0; i <= 27; i++)
- /* HDMI_CTRL_PKT_BUF_ACCESS_PB0 - PB27 */
- hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_PB0 + i);
-}
-
-/**
- * sh_hdmi_isrc2_setup() - ISRC2 Packet
- */
-static void sh_hdmi_isrc2_setup(struct sh_hdmi *hdmi)
-{
- int i;
-
- /* ISRC2 Packet */
- hdmi_write(hdmi, 0x03, HDMI_CTRL_PKT_BUF_INDEX);
-
- /* HB0 Packet Type = 0x06 */
- hdmi_write(hdmi, 0x06, HDMI_CTRL_PKT_BUF_ACCESS_HB0);
- /* Reserved (0) */
- hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_HB1);
- /* Reserved (0) */
- hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_HB2);
-
- /* PB0 UPC_EAN_ISRC_16-31 */
- /* Bytes PB16-PB27 shall be set to a value of 0. */
- for (i = 0; i <= 27; i++)
- /* HDMI_CTRL_PKT_BUF_ACCESS_PB0 - PB27 */
- hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_PB0 + i);
-}
-
-/**
* sh_hdmi_configure() - Initialise HDMI for output
*/
static void sh_hdmi_configure(struct sh_hdmi *hdmi)
@@ -632,18 +538,6 @@ static void sh_hdmi_configure(struct sh_hdmi *hdmi)
/* Audio InfoFrame */
sh_hdmi_audio_infoframe_setup(hdmi);
- /* Gamut Metadata packet */
- sh_hdmi_gamut_metadata_setup(hdmi);
-
- /* Audio Content Protection (ACP) Packet */
- sh_hdmi_acp_setup(hdmi);
-
- /* ISRC1 Packet */
- sh_hdmi_isrc1_setup(hdmi);
-
- /* ISRC2 Packet */
- sh_hdmi_isrc2_setup(hdmi);
-
/*
* Control packet auto send with VSYNC control: auto send
* General control, Gamut metadata, ISRC, and ACP packets
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fbdev: sh-mobile_hdmi: remove un-necessity settings
@ 2010-09-03 9:06 Guennadi Liakhovetski
0 siblings, 0 replies; 2+ messages in thread
From: Guennadi Liakhovetski @ 2010-09-03 9:06 UTC (permalink / raw)
To: linux-sh
On Fri, 27 Aug 2010, Kuninori Morimoto wrote:
> Current gamut, acp, isrc1, isrc2 settings are wrong,
> and not necessary for now.
>
> Tested-by: Takanari Hayama <taki@igel.co.jp>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Doesn't seem to break anything here
Tested-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Thanks
Guennadi
> ---
> drivers/video/sh_mobile_hdmi.c | 106 ----------------------------------------
> 1 files changed, 0 insertions(+), 106 deletions(-)
>
> diff --git a/drivers/video/sh_mobile_hdmi.c b/drivers/video/sh_mobile_hdmi.c
> index 2fde08c..afebe80 100644
> --- a/drivers/video/sh_mobile_hdmi.c
> +++ b/drivers/video/sh_mobile_hdmi.c
> @@ -519,100 +519,6 @@ static void sh_hdmi_audio_infoframe_setup(struct sh_hdmi *hdmi)
> }
>
> /**
> - * sh_hdmi_gamut_metadata_setup() - Gamut Metadata Packet of CONTROL PACKET
> - */
> -static void sh_hdmi_gamut_metadata_setup(struct sh_hdmi *hdmi)
> -{
> - int i;
> -
> - /* Gamut Metadata Packet */
> - hdmi_write(hdmi, 0x04, HDMI_CTRL_PKT_BUF_INDEX);
> -
> - /* Packet Type = 0x0A */
> - hdmi_write(hdmi, 0x0A, HDMI_CTRL_PKT_BUF_ACCESS_HB0);
> - /* Gamut Packet is not used, so default value */
> - hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_HB1);
> - /* Gamut Packet is not used, so default value */
> - hdmi_write(hdmi, 0x10, HDMI_CTRL_PKT_BUF_ACCESS_HB2);
> -
> - /* GBD bytes 0 through 27 */
> - for (i = 0; i <= 27; i++)
> - /* HDMI_CTRL_PKT_BUF_ACCESS_PB0_63H - PB27_7EH */
> - hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_PB0 + i);
> -}
> -
> -/**
> - * sh_hdmi_acp_setup() - Audio Content Protection Packet (ACP)
> - */
> -static void sh_hdmi_acp_setup(struct sh_hdmi *hdmi)
> -{
> - int i;
> -
> - /* Audio Content Protection Packet (ACP) */
> - hdmi_write(hdmi, 0x01, HDMI_CTRL_PKT_BUF_INDEX);
> -
> - /* Packet Type = 0x04 */
> - hdmi_write(hdmi, 0x04, HDMI_CTRL_PKT_BUF_ACCESS_HB0);
> - /* ACP_Type */
> - hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_HB1);
> - /* Reserved (0) */
> - hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_HB2);
> -
> - /* GBD bytes 0 through 27 */
> - for (i = 0; i <= 27; i++)
> - /* HDMI_CTRL_PKT_BUF_ACCESS_PB0 - PB27 */
> - hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_PB0 + i);
> -}
> -
> -/**
> - * sh_hdmi_isrc1_setup() - ISRC1 Packet
> - */
> -static void sh_hdmi_isrc1_setup(struct sh_hdmi *hdmi)
> -{
> - int i;
> -
> - /* ISRC1 Packet */
> - hdmi_write(hdmi, 0x02, HDMI_CTRL_PKT_BUF_INDEX);
> -
> - /* Packet Type = 0x05 */
> - hdmi_write(hdmi, 0x05, HDMI_CTRL_PKT_BUF_ACCESS_HB0);
> - /* ISRC_Cont, ISRC_Valid, Reserved (0), ISRC_Status */
> - hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_HB1);
> - /* Reserved (0) */
> - hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_HB2);
> -
> - /* PB0 UPC_EAN_ISRC_0-15 */
> - /* Bytes PB16-PB27 shall be set to a value of 0. */
> - for (i = 0; i <= 27; i++)
> - /* HDMI_CTRL_PKT_BUF_ACCESS_PB0 - PB27 */
> - hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_PB0 + i);
> -}
> -
> -/**
> - * sh_hdmi_isrc2_setup() - ISRC2 Packet
> - */
> -static void sh_hdmi_isrc2_setup(struct sh_hdmi *hdmi)
> -{
> - int i;
> -
> - /* ISRC2 Packet */
> - hdmi_write(hdmi, 0x03, HDMI_CTRL_PKT_BUF_INDEX);
> -
> - /* HB0 Packet Type = 0x06 */
> - hdmi_write(hdmi, 0x06, HDMI_CTRL_PKT_BUF_ACCESS_HB0);
> - /* Reserved (0) */
> - hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_HB1);
> - /* Reserved (0) */
> - hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_HB2);
> -
> - /* PB0 UPC_EAN_ISRC_16-31 */
> - /* Bytes PB16-PB27 shall be set to a value of 0. */
> - for (i = 0; i <= 27; i++)
> - /* HDMI_CTRL_PKT_BUF_ACCESS_PB0 - PB27 */
> - hdmi_write(hdmi, 0x00, HDMI_CTRL_PKT_BUF_ACCESS_PB0 + i);
> -}
> -
> -/**
> * sh_hdmi_configure() - Initialise HDMI for output
> */
> static void sh_hdmi_configure(struct sh_hdmi *hdmi)
> @@ -632,18 +538,6 @@ static void sh_hdmi_configure(struct sh_hdmi *hdmi)
> /* Audio InfoFrame */
> sh_hdmi_audio_infoframe_setup(hdmi);
>
> - /* Gamut Metadata packet */
> - sh_hdmi_gamut_metadata_setup(hdmi);
> -
> - /* Audio Content Protection (ACP) Packet */
> - sh_hdmi_acp_setup(hdmi);
> -
> - /* ISRC1 Packet */
> - sh_hdmi_isrc1_setup(hdmi);
> -
> - /* ISRC2 Packet */
> - sh_hdmi_isrc2_setup(hdmi);
> -
> /*
> * Control packet auto send with VSYNC control: auto send
> * General control, Gamut metadata, ISRC, and ACP packets
> --
> 1.7.0.4
>
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-03 9:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-27 10:15 [PATCH] fbdev: sh-mobile_hdmi: remove un-necessity settings Kuninori Morimoto
-- strict thread matches above, loose matches on Subject: below --
2010-09-03 9:06 Guennadi Liakhovetski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).