From: Vineet.Gupta1@synopsys.com (Vineet Gupta)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 09/17] ARC: dw2 unwind: Use striaght forward code to implement binary lookup
Date: Thu, 3 Dec 2015 18:11:07 +0530 [thread overview]
Message-ID: <1449146475-15335-10-git-send-email-vgupta@synopsys.com> (raw)
In-Reply-To: <1449146475-15335-1-git-send-email-vgupta@synopsys.com>
The {start, pc} entries are already word aligned, no need to use
read_pointer() inefficiency !
Signed-off-by: Vineet Gupta <vgupta at synopsys.com>
---
arch/arc/kernel/unwind.c | 40 +++++++++++++++++-----------------------
1 file changed, 17 insertions(+), 23 deletions(-)
diff --git a/arch/arc/kernel/unwind.c b/arch/arc/kernel/unwind.c
index 9b34038a7582..6a09ffa0b697 100644
--- a/arch/arc/kernel/unwind.c
+++ b/arch/arc/kernel/unwind.c
@@ -866,7 +866,7 @@ int arc_unwind(struct unwind_frame_info *frame)
const u8 *ptr = NULL, *end = NULL;
unsigned long pc = UNW_PC(frame);
unsigned long startLoc = 0, endLoc = 0, cfa;
- unsigned i;
+ unsigned i, s, e;
signed ptrType = -1;
uleb128_t retAddrReg = 0;
const struct unwind_table *table;
@@ -874,7 +874,6 @@ int arc_unwind(struct unwind_frame_info *frame)
unsigned long *fptr;
unsigned long addr;
struct eh_frame_header *hdr;
- unsigned long hdrEntrySz;
unw_debug("\nUNWIND FRAME: -------------------------------------\n");
unw_debug("PC\t\t: 0x%lx %pS\nr31 [BLINK]\t: 0x%lx %pS\nr28 [SP]\t: 0x%lx\nr27 [FP]\t: 0x%lx\n",
@@ -903,28 +902,23 @@ int arc_unwind(struct unwind_frame_info *frame)
if (hdr == NULL)
return -EINVAL;
- hdrEntrySz = sizeof(unsigned long);
- BUILD_BUG_ON(hdrEntrySz != sizeof(hdr->table[0].start));
+ s = i = 0;
+ e = hdr->fde_count - 1;
- ptr = (const u8*)(hdr->table);
- end = (const u8*)(hdr) + table->hdrsz;
- i = hdr->fde_count;
-
- do {
- const u8 *cur = ptr + (i / 2) * (2 * hdrEntrySz);
-
- startLoc = read_pointer(&cur, cur + hdrEntrySz, hdr->table_enc);
- if (pc < startLoc)
- i /= 2;
- else {
- ptr = cur - hdrEntrySz;
- i = (i + 1) / 2;
- }
- } while (startLoc && i > 1);
- if (i == 1
- && (startLoc = read_pointer(&ptr, ptr + hdrEntrySz, hdr->table_enc)) != 0
- && pc >= startLoc)
- fde = (void *)read_pointer(&ptr, ptr + hdrEntrySz, hdr->table_enc);
+ do {
+ if (pc < startLoc)
+ e = i;
+ else
+ s = i;
+ i = s + (e - s) / 2;
+ startLoc = hdr->table[i].start;
+ unw_debug("s %d e %d i %d startLoc %lx\n", s, e, i, startLoc)
+ } while ((e - s) > 1);
+
+ if (pc >= startLoc)
+ fde = (u32 *)hdr->table[i].fde;
+ else
+ return -EINVAL;
if (fde != NULL) {
cie = cie_for_fde(fde, table);
--
1.9.1
next prev parent reply other threads:[~2015-12-03 12:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 12:40 [RFC 00/17] ARC Dwarf unwinder improvements Vineet Gupta
2015-12-03 12:40 ` [PATCH 01/17] ARC: dw2 unwind: Elide generation of const propagated clones Vineet Gupta
2015-12-03 12:41 ` [PATCH 02/17] ARC: dw2 unwind: remove unused cruft Vineet Gupta
2015-12-03 12:41 ` [PATCH 03/17] ARC: dw2 unwind: Remove handling of for signal frame Vineet Gupta
2015-12-03 12:41 ` [PATCH 04/17] ARC: dw2 unwind: Remove FP based unwinding Vineet Gupta
2015-12-03 12:41 ` [PATCH 05/17] ARC: dw2 unwind: Better printing Vineet Gupta
2015-12-03 12:41 ` [PATCH 06/17] ARC: dw2 unwind: Don't verify Main FDE Table size everytime Vineet Gupta
2015-12-03 12:41 ` [PATCH 07/17] ARC: dw2 unwind: Refactor the FDE lookup table (eh_frame_header) code Vineet Gupta
2015-12-03 12:41 ` [PATCH 08/17] ARC: dw2 unwind: Don't verify FDE lookup table metadata Vineet Gupta
2015-12-03 12:41 ` Vineet Gupta [this message]
2015-12-03 12:41 ` [PATCH 10/17] ARC: dw2 unwind: CIE parsing/validation done only once at startup Vineet Gupta
2015-12-03 12:41 ` [PATCH 11/17] ARC: dw2 unwind: Elide REG_INVALID check Vineet Gupta
2015-12-03 12:41 ` [PATCH 12/17] ARC: dw2 unwind: Elide a loop if DW_CFA_register not present Vineet Gupta
2015-12-03 12:41 ` [PATCH 13/17] ARC: dw2 unwind: Assume all regs to be unsigned long Vineet Gupta
2015-12-03 12:41 ` [PATCH 14/17] ARC: dw2 unwind: No need for __get_user Vineet Gupta
2015-12-03 12:41 ` [PATCH 15/17] ARC: dw2 unwind: Single exit point for instrumentation Vineet Gupta
2015-12-03 12:41 ` [PATCH 16/17] ARC: dw2 unwind: skip regs not updated Vineet Gupta
2015-12-03 12:41 ` [PATCH 17/17] xxx: instrument Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449146475-15335-10-git-send-email-vgupta@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).