From: Vineet.Gupta1@synopsys.com (Vineet Gupta)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 11/17] ARC: dw2 unwind: Elide REG_INVALID check
Date: Thu, 3 Dec 2015 18:11:09 +0530 [thread overview]
Message-ID: <1449146475-15335-12-git-send-email-vgupta@synopsys.com> (raw)
In-Reply-To: <1449146475-15335-1-git-send-email-vgupta@synopsys.com>
REG_INVALID checks if reg_info[*].width is zero, which is compile time
contant set to NON zero. No point in checking it.
Signed-off-by: Vineet Gupta <vgupta at synopsys.com>
---
arch/arc/kernel/unwind.c | 20 ++------------------
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git a/arch/arc/kernel/unwind.c b/arch/arc/kernel/unwind.c
index f2a486d9dac2..b1a520afcbcb 100644
--- a/arch/arc/kernel/unwind.c
+++ b/arch/arc/kernel/unwind.c
@@ -48,10 +48,6 @@ static const struct {
unsigned width:BITS_PER_LONG / 2;
} reg_info[] = { UNW_REGISTER_INFO };
-#ifndef REG_INVALID
-#define REG_INVALID(r) (reg_info[r].width == 0)
-#endif
-
#define DW_CFA_nop 0x00
#define DW_CFA_set_loc 0x01
#define DW_CFA_advance_loc1 0x02
@@ -868,9 +864,7 @@ static int cie_validate(const u32 *cie, struct cie *t_cie)
t_cie->fde_pointer_type = ptrType;
if (ptr > end
- || retAddrReg >= ARRAY_SIZE(reg_info)
- || REG_INVALID(retAddrReg)
- || reg_info[retAddrReg].width != sizeof(unsigned long))
+ || retAddrReg >= ARRAY_SIZE(reg_info))
return 0;
unw_debug("\nDwarf Unwinder setup: CIE Info:\n");
@@ -1017,19 +1011,11 @@ int arc_unwind(struct unwind_frame_info *frame)
state.cfa.reg, state.cfa.offs, cfa);
for (i = 0; i < ARRAY_SIZE(state.regs); ++i) {
- if (REG_INVALID(i)) {
- if (state.regs[i].where == Nowhere)
- continue;
- return -EIO;
- }
switch (state.regs[i].where) {
default:
break;
case Register:
- if (state.regs[i].value >= ARRAY_SIZE(reg_info)
- || REG_INVALID(state.regs[i].value)
- || reg_info[i].width >
- reg_info[state.regs[i].value].width)
+ if (state.regs[i].value >= ARRAY_SIZE(reg_info))
return -EIO;
switch (reg_info[state.regs[i].value].width) {
case sizeof(u8):
@@ -1061,8 +1047,6 @@ int arc_unwind(struct unwind_frame_info *frame)
fptr = (unsigned long *)(&frame->regs);
for (i = 0; i < ARRAY_SIZE(state.regs); ++i, fptr++) {
- if (REG_INVALID(i))
- continue;
switch (state.regs[i].where) {
case Nowhere:
if (reg_info[i].width != sizeof(UNW_SP(frame))
--
1.9.1
next prev parent reply other threads:[~2015-12-03 12:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 12:40 [RFC 00/17] ARC Dwarf unwinder improvements Vineet Gupta
2015-12-03 12:40 ` [PATCH 01/17] ARC: dw2 unwind: Elide generation of const propagated clones Vineet Gupta
2015-12-03 12:41 ` [PATCH 02/17] ARC: dw2 unwind: remove unused cruft Vineet Gupta
2015-12-03 12:41 ` [PATCH 03/17] ARC: dw2 unwind: Remove handling of for signal frame Vineet Gupta
2015-12-03 12:41 ` [PATCH 04/17] ARC: dw2 unwind: Remove FP based unwinding Vineet Gupta
2015-12-03 12:41 ` [PATCH 05/17] ARC: dw2 unwind: Better printing Vineet Gupta
2015-12-03 12:41 ` [PATCH 06/17] ARC: dw2 unwind: Don't verify Main FDE Table size everytime Vineet Gupta
2015-12-03 12:41 ` [PATCH 07/17] ARC: dw2 unwind: Refactor the FDE lookup table (eh_frame_header) code Vineet Gupta
2015-12-03 12:41 ` [PATCH 08/17] ARC: dw2 unwind: Don't verify FDE lookup table metadata Vineet Gupta
2015-12-03 12:41 ` [PATCH 09/17] ARC: dw2 unwind: Use striaght forward code to implement binary lookup Vineet Gupta
2015-12-03 12:41 ` [PATCH 10/17] ARC: dw2 unwind: CIE parsing/validation done only once at startup Vineet Gupta
2015-12-03 12:41 ` Vineet Gupta [this message]
2015-12-03 12:41 ` [PATCH 12/17] ARC: dw2 unwind: Elide a loop if DW_CFA_register not present Vineet Gupta
2015-12-03 12:41 ` [PATCH 13/17] ARC: dw2 unwind: Assume all regs to be unsigned long Vineet Gupta
2015-12-03 12:41 ` [PATCH 14/17] ARC: dw2 unwind: No need for __get_user Vineet Gupta
2015-12-03 12:41 ` [PATCH 15/17] ARC: dw2 unwind: Single exit point for instrumentation Vineet Gupta
2015-12-03 12:41 ` [PATCH 16/17] ARC: dw2 unwind: skip regs not updated Vineet Gupta
2015-12-03 12:41 ` [PATCH 17/17] xxx: instrument Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449146475-15335-12-git-send-email-vgupta@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).