linux-snps-arc.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Vineet.Gupta1@synopsys.com (Vineet Gupta)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 08/17] ARC: dw2 unwind: Don't verify FDE lookup table metadata
Date: Thu, 3 Dec 2015 18:11:06 +0530	[thread overview]
Message-ID: <1449146475-15335-9-git-send-email-vgupta@synopsys.com> (raw)
In-Reply-To: <1449146475-15335-1-git-send-email-vgupta@synopsys.com>

FDE Lookup table (eh_frame_header or it's equivalent constructed by hand)
is already setup correctly in setup_unwind_table(). There's no point
to re-parse it's header for every unwind call

Signed-off-by: Vineet Gupta <vgupta at synopsys.com>
---
 arch/arc/kernel/unwind.c | 37 ++++++++-----------------------------
 1 file changed, 8 insertions(+), 29 deletions(-)

diff --git a/arch/arc/kernel/unwind.c b/arch/arc/kernel/unwind.c
index 9f5ed6873c52..9b34038a7582 100644
--- a/arch/arc/kernel/unwind.c
+++ b/arch/arc/kernel/unwind.c
@@ -900,35 +900,16 @@ int arc_unwind(struct unwind_frame_info *frame)
 		return -EINVAL;
 
 	hdr = table->header;
+	if (hdr == NULL)
+		return -EINVAL;
 
-	smp_rmb();
-	if (hdr && hdr->version == 1) {
-		switch (hdr->table_enc & DW_EH_PE_FORM) {
-		case DW_EH_PE_native:
-			hdrEntrySz = sizeof(unsigned long);
-			break;
-		case DW_EH_PE_data2:
-			hdrEntrySz = 2;
-			break;
-		case DW_EH_PE_data4:
-			hdrEntrySz = 4;
-			break;
-		case DW_EH_PE_data8:
-			hdrEntrySz = 8;
-			break;
-		default:
-			hdrEntrySz = 0;
-			break;
-		}
+	hdrEntrySz = sizeof(unsigned long);
+	BUILD_BUG_ON(hdrEntrySz != sizeof(hdr->table[0].start));
+
+	ptr = (const u8*)(hdr->table);
+	end = (const u8*)(hdr) + table->hdrsz;
+	i = hdr->fde_count;
 
-		ptr = (const u8*)(hdr->eh_frame_ptr);
-		end = (const u8*)(hdr) + table->hdrsz;
-		if (hdrEntrySz
-		    && read_pointer(&ptr, end, hdr->eh_frame_ptr_enc) /* eh_frame_ptr */
-		    == (unsigned long)table->address
-		    && (i = read_pointer(&ptr, end, hdr->fde_count_enc)) > 0 /* fde_count */
-		    && i == (end - ptr) / (2 * hdrEntrySz)
-		    && !((end - ptr) % (2 * hdrEntrySz))) {
 			do {
 				const u8 *cur = ptr + (i / 2) * (2 * hdrEntrySz);
 
@@ -944,8 +925,6 @@ int arc_unwind(struct unwind_frame_info *frame)
 			    && (startLoc = read_pointer(&ptr, ptr + hdrEntrySz, hdr->table_enc)) != 0
 			    && pc >= startLoc)
 				fde = (void *)read_pointer(&ptr, ptr + hdrEntrySz, hdr->table_enc);
-		}
-	}
 
 	if (fde != NULL) {
 		cie = cie_for_fde(fde, table);
-- 
1.9.1

  parent reply	other threads:[~2015-12-03 12:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03 12:40 [RFC 00/17] ARC Dwarf unwinder improvements Vineet Gupta
2015-12-03 12:40 ` [PATCH 01/17] ARC: dw2 unwind: Elide generation of const propagated clones Vineet Gupta
2015-12-03 12:41 ` [PATCH 02/17] ARC: dw2 unwind: remove unused cruft Vineet Gupta
2015-12-03 12:41 ` [PATCH 03/17] ARC: dw2 unwind: Remove handling of for signal frame Vineet Gupta
2015-12-03 12:41 ` [PATCH 04/17] ARC: dw2 unwind: Remove FP based unwinding Vineet Gupta
2015-12-03 12:41 ` [PATCH 05/17] ARC: dw2 unwind: Better printing Vineet Gupta
2015-12-03 12:41 ` [PATCH 06/17] ARC: dw2 unwind: Don't verify Main FDE Table size everytime Vineet Gupta
2015-12-03 12:41 ` [PATCH 07/17] ARC: dw2 unwind: Refactor the FDE lookup table (eh_frame_header) code Vineet Gupta
2015-12-03 12:41 ` Vineet Gupta [this message]
2015-12-03 12:41 ` [PATCH 09/17] ARC: dw2 unwind: Use striaght forward code to implement binary lookup Vineet Gupta
2015-12-03 12:41 ` [PATCH 10/17] ARC: dw2 unwind: CIE parsing/validation done only once at startup Vineet Gupta
2015-12-03 12:41 ` [PATCH 11/17] ARC: dw2 unwind: Elide REG_INVALID check Vineet Gupta
2015-12-03 12:41 ` [PATCH 12/17] ARC: dw2 unwind: Elide a loop if DW_CFA_register not present Vineet Gupta
2015-12-03 12:41 ` [PATCH 13/17] ARC: dw2 unwind: Assume all regs to be unsigned long Vineet Gupta
2015-12-03 12:41 ` [PATCH 14/17] ARC: dw2 unwind: No need for __get_user Vineet Gupta
2015-12-03 12:41 ` [PATCH 15/17] ARC: dw2 unwind: Single exit point for instrumentation Vineet Gupta
2015-12-03 12:41 ` [PATCH 16/17] ARC: dw2 unwind: skip regs not updated Vineet Gupta
2015-12-03 12:41 ` [PATCH 17/17] xxx: instrument Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449146475-15335-9-git-send-email-vgupta@synopsys.com \
    --to=vineet.gupta1@synopsys.com \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).