linux-snps-arc.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Alexey.Brodkin@synopsys.com (Alexey Brodkin)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 3/4] ASoC: dwc: Add I2S HDMI audio support using custom platform driver
Date: Mon, 28 Mar 2016 11:55:45 +0000	[thread overview]
Message-ID: <1459166144.4785.77.camel@synopsys.com> (raw)
In-Reply-To: <7aaad0b57652fc724be7b447790c194645321173.1458839710.git.joabreu@synopsys.com>

Hi Jose,

On Mon, 2016-03-28@10:41 +0100, Jose Abreu wrote:
> HDMI audio support was added to the AXS board using an
> I2S cpu driver and a custom platform driver.
> 
> The platform driver supports two channels @ 16 bits with
> rates 32k, 44.1k and 48k. ALSA Simple audio card is used to
> glue the cpu, platform and codec driver (adv7511).
> 
> Signed-off-by: Jose Abreu <joabreu at synopsys.com>
> ---
> ?arch/arc/boot/dts/axs10x_mb.dtsi |??20 +-

You should not mix DT bindings for a particular board with generic driver
fixes or improvements.

I think it makes sense to split this patch in 2:
?1) Driver improvements
?2) .dts update for boards that use this driver

> ?sound/soc/dwc/Kconfig????????????|???1 +
> ?sound/soc/dwc/designware_i2s.c???| 384 +++++++++++++++++++++++++++++++++++++--
> ?3 files changed, 388 insertions(+), 17 deletions(-)

-Alexey

  parent reply	other threads:[~2016-03-28 11:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1458839710.git.joabreu@synopsys.com>
     [not found] ` <88015401488eed4f253f49d5831be13e0007339f.1458839710.git.joabreu@synopsys.com>
2016-03-28 11:48   ` [PATCH 2/4] ARC: axs10x: Update defconfigs so that audio is enabled Alexey Brodkin
     [not found] ` <7aaad0b57652fc724be7b447790c194645321173.1458839710.git.joabreu@synopsys.com>
2016-03-28 11:55   ` Alexey Brodkin [this message]
2016-02-19  9:39 [PATCH 0/4] Add I2S/ADV7511 audio support for ARC AXS10x boards Carlos Palminha
2016-02-19  9:40 ` [PATCH 3/4] ASoC: dwc: Add I2S HDMI audio support using custom platform driver Carlos Palminha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459166144.4785.77.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).