From: Alexey.Brodkin@synopsys.com (Alexey Brodkin)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge
Date: Wed, 2 Nov 2016 12:23:43 +0000 [thread overview]
Message-ID: <1478089382.2710.20.camel@synopsys.com> (raw)
In-Reply-To: <4881796E12491D4BB15146FE0209CE646784BA6F@DE02WEMBXB.internal.synopsys.com>
Hi Daniel, David,
On Mon, 2016-10-24@18:33 +0000, Alexey Brodkin wrote:
> Hi Daniel,
>
> >
> > -----Original Message-----
> > From: linux-snps-arc [mailto:linux-snps-arc-bounces at lists.infradead.org] On Behalf Of Alexey Brodkin
> > Sent: 19 ??????? 2016 ?. 12:33
> > To: dri-devel at lists.freedesktop.org; architt at codeaurora.org; Eugeniy.Paltsev at synopsys.com
> > Cc: linux-snps-arc at lists.infradead.org; linux-kernel at vger.kernel.org
> > Subject: Re: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge
> >
> > Hi Archit, all,
> >
> > On Wed, 2016-10-19@14:43 +0530, Archit Taneja wrote:
> > >
> > >
> > > On 10/19/2016 01:16 PM, Eugeniy Paltsev wrote:
> > > >
> > > >
> > > > ARC PGU driver starts crashing on initialization after
> > > > 'commit e12c2f645557 ("drm/i2c: adv7511: Convert to drm_bridge")'
> > > > This happenes because in "arcpgu_drm_hdmi_init" function we get pointer
> > > > of "drm_i2c_encoder_driver" structure, which doesn't exist after
> > > > adv7511 hdmi encoder interface changed from slave encoder to drm bridge.
> > > > So, when we call "encoder_init" function from this structure driver
> > > > crashes.
> >
> > [snip]
> >
> > >
> > > Looks good now.
> > >
> > > Reviewed-by: Archit Taneja <architt at codeaurora.org>
> >
> > And IMHO it would be really good to get this one back-ported to 4.8
> > because it really fixes kernel crash if ARC PGU driver is used.
> >
> > It might be a bit of a problem because patch itself a little-bit larger
> > than formal requirement for stable backports but let's see if it gets accepted.
>
> Could you please pick this one up?
> I may alternatively send a pull-request to David but not sure if 1 patch worth it.
>
> Also if that's not really too late it would be good to get this one in 4.9 since the patch
> In question fixes a real driver crash on its instantiation.
> Actually driver crash happens since 4.8 but I failed to notice it earlier and given amount
> of changes I think there's barely a chance for it it to be accepted in stable branches...
> which in its turn makes at least 4.9 very desirable.
Any chance this one gets accepted anytime soon?
Regards,
Alexey
next prev parent reply other threads:[~2016-11-02 12:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 7:46 [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge Eugeniy Paltsev
2016-10-19 9:13 ` Archit Taneja
2016-10-19 9:32 ` Alexey Brodkin
2016-10-24 18:33 ` Alexey Brodkin
2016-11-02 12:23 ` Alexey Brodkin [this message]
2016-11-10 11:06 ` Alexey Brodkin
2016-11-10 23:53 ` Dave Airlie
-- strict thread matches above, loose matches on Subject: below --
2016-10-21 14:56 Ramiro Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478089382.2710.20.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox