linux-snps-arc.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Vineet.Gupta1@synopsys.com (Vineet Gupta)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v2 01/10] ARC: timer: rtc: implement read loop in "C" vs. inline asm
Date: Thu, 3 Nov 2016 14:31:32 -0700	[thread overview]
Message-ID: <1478208701-30923-2-git-send-email-vgupta@synopsys.com> (raw)
In-Reply-To: <1478208701-30923-1-git-send-email-vgupta@synopsys.com>

The current code doesn't even compile ....

CC: stable at vger.kernel.org
Signed-off-by: Vineet Gupta <vgupta at synopsys.com>
---
 arch/arc/kernel/time.c | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/arch/arc/kernel/time.c b/arch/arc/kernel/time.c
index f927b8dc6edd..1a117b999c0c 100644
--- a/arch/arc/kernel/time.c
+++ b/arch/arc/kernel/time.c
@@ -152,14 +152,17 @@ static cycle_t arc_read_rtc(struct clocksource *cs)
 		cycle_t  full;
 	} stamp;
 
-
-	__asm__ __volatile(
-	"1:						\n"
-	"	lr		%0, [AUX_RTC_LOW]	\n"
-	"	lr		%1, [AUX_RTC_HIGH]	\n"
-	"	lr		%2, [AUX_RTC_CTRL]	\n"
-	"	bbit0.nt	%2, 31, 1b		\n"
-	: "=r" (stamp.low), "=r" (stamp.high), "=r" (status));
+        /*
+         * hardware has an internal state machine which tracks readout of
+         * low/high and updates the CTRL.status if
+         *  - interrupt/exception taken between the two reads
+         *  - high increments after low has been read
+         */
+	do {
+		stamp.low = read_aux_reg(AUX_RTC_LOW);
+		stamp.high = read_aux_reg(AUX_RTC_HIGH);
+		status = read_aux_reg(AUX_RTC_CTRL);
+	} while (!(status & _BITUL(31)));
 
 	return stamp.full;
 }
-- 
2.7.4

  reply	other threads:[~2016-11-03 21:31 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-03 21:31 [PATCH v2 00/10] Move ARC timer code into drivers/clocksource/ Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta [this message]
2016-11-03 21:52   ` [PATCH v2 01/10] ARC: timer: rtc: implement read loop in "C" vs. inline asm Daniel Lezcano
2016-11-03 22:23     ` Vineet Gupta
2016-11-03 22:35       ` Daniel Lezcano
2016-11-03 22:44         ` Vineet Gupta
2016-11-03 22:46           ` Daniel Lezcano
2016-11-04 17:58   ` Alexey Brodkin
2016-11-03 21:31 ` [PATCH v2 02/10] ARC: timer: gfrc, rtc: deuglify big endian code Vineet Gupta
2016-11-03 21:55   ` Daniel Lezcano
2016-11-03 22:15     ` Vineet Gupta
2016-11-04 18:11   ` Alexey Brodkin
2016-11-03 21:31 ` [PATCH v2 03/10] ARC: timer: gfrc, rtc: Read BCR to detect whether hardware exists Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 04/10] ARC: timer: gfrc: boot print alongside other timers Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 05/10] ARC: time: move time_init() out of the driver Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 06/10] ARC: timer: Build gfrc, rtc under same option (64-bit timers) Vineet Gupta
2016-11-03 22:13   ` Daniel Lezcano
2016-11-03 21:31 ` [PATCH v2 07/10] ARC: breakout aux handling into a separate header Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 08/10] ARC: move mcip.h into include/soc and adjust the includes Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 09/10] ARC: breakout timer include code into separate header Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 10/10] clocksource: import ARC timer driver Vineet Gupta
2016-11-03 22:38   ` Daniel Lezcano
2016-11-03 22:50     ` Vineet Gupta
2016-11-03 23:01       ` Daniel Lezcano
2016-11-03 23:06         ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478208701-30923-2-git-send-email-vgupta@synopsys.com \
    --to=vineet.gupta1@synopsys.com \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).