From: Vineet.Gupta1@synopsys.com (Vineet Gupta)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v2 03/10] ARC: timer: gfrc, rtc: Read BCR to detect whether hardware exists ...
Date: Thu, 3 Nov 2016 14:31:34 -0700 [thread overview]
Message-ID: <1478208701-30923-4-git-send-email-vgupta@synopsys.com> (raw)
In-Reply-To: <1478208701-30923-1-git-send-email-vgupta@synopsys.com>
... don't rely on cpuinfo populated in arc boot code. This paves way for
moving this code in drivers/clocksource/
And while at it, convert the WARN() to pr_warn() as sugested by Daniel
Signed-off-by: Vineet Gupta <vgupta at synopsys.com>
---
arch/arc/kernel/time.c | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/arch/arc/kernel/time.c b/arch/arc/kernel/time.c
index 71bcdc1f9bd0..d2335ca49c80 100644
--- a/arch/arc/kernel/time.c
+++ b/arch/arc/kernel/time.c
@@ -111,11 +111,14 @@ static struct clocksource arc_counter_gfrc = {
static int __init arc_cs_setup_gfrc(struct device_node *node)
{
- int exists = cpuinfo_arc700[0].extn.gfrc;
+ struct mcip_bcr mp;
int ret;
- if (WARN(!exists, "Global-64-bit-Ctr clocksource not detected"))
+ READ_BCR(ARC_REG_MCIP_BCR, mp);
+ if (!mp.gfrc) {
+ pr_warn("Global-64-bit-Ctr clocksource not detected");
return -ENXIO;
+ }
ret = arc_get_timer_clk(node);
if (ret)
@@ -163,15 +166,20 @@ static struct clocksource arc_counter_rtc = {
static int __init arc_cs_setup_rtc(struct device_node *node)
{
- int exists = cpuinfo_arc700[smp_processor_id()].extn.rtc;
+ struct bcr_timer timer;
int ret;
- if (WARN(!exists, "Local-64-bit-Ctr clocksource not detected"))
+ READ_BCR(ARC_REG_TIMERS_BCR, timer);
+ if (!timer.rtc) {
+ pr_warn("Local-64-bit-Ctr clocksource not detected");
return -ENXIO;
+ }
/* Local to CPU hence not usable in SMP */
- if (WARN(IS_ENABLED(CONFIG_SMP), "Local-64-bit-Ctr not usable in SMP"))
+ if (IS_ENABLED(CONFIG_SMP)) {
+ pr_warn("Local-64-bit-Ctr not usable in SMP");
return -EINVAL;
+ }
ret = arc_get_timer_clk(node);
if (ret)
--
2.7.4
next prev parent reply other threads:[~2016-11-03 21:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 21:31 [PATCH v2 00/10] Move ARC timer code into drivers/clocksource/ Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 01/10] ARC: timer: rtc: implement read loop in "C" vs. inline asm Vineet Gupta
2016-11-03 21:52 ` Daniel Lezcano
2016-11-03 22:23 ` Vineet Gupta
2016-11-03 22:35 ` Daniel Lezcano
2016-11-03 22:44 ` Vineet Gupta
2016-11-03 22:46 ` Daniel Lezcano
2016-11-04 17:58 ` Alexey Brodkin
2016-11-03 21:31 ` [PATCH v2 02/10] ARC: timer: gfrc, rtc: deuglify big endian code Vineet Gupta
2016-11-03 21:55 ` Daniel Lezcano
2016-11-03 22:15 ` Vineet Gupta
2016-11-04 18:11 ` Alexey Brodkin
2016-11-03 21:31 ` Vineet Gupta [this message]
2016-11-03 21:31 ` [PATCH v2 04/10] ARC: timer: gfrc: boot print alongside other timers Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 05/10] ARC: time: move time_init() out of the driver Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 06/10] ARC: timer: Build gfrc, rtc under same option (64-bit timers) Vineet Gupta
2016-11-03 22:13 ` Daniel Lezcano
2016-11-03 21:31 ` [PATCH v2 07/10] ARC: breakout aux handling into a separate header Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 08/10] ARC: move mcip.h into include/soc and adjust the includes Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 09/10] ARC: breakout timer include code into separate header Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 10/10] clocksource: import ARC timer driver Vineet Gupta
2016-11-03 22:38 ` Daniel Lezcano
2016-11-03 22:50 ` Vineet Gupta
2016-11-03 23:01 ` Daniel Lezcano
2016-11-03 23:06 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478208701-30923-4-git-send-email-vgupta@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).