From: Alexey.Brodkin@synopsys.com (Alexey Brodkin)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 2/2] arc: axs10x: Fix ARC PGU default clock frequency
Date: Thu, 2 Mar 2017 17:35:52 +0000 [thread overview]
Message-ID: <1488476152.2684.10.camel@synopsys.com> (raw)
In-Reply-To: <16273b3a26ec770f8d169f04f7cb9eb2fac55909.1487787376.git.joabreu@synopsys.com>
Hi Jose,
On Wed, 2017-02-22@18:19 +0000, Jose Abreu wrote:
> Default clock frequency for ARC PGU does not match any
> existing HDMI mode, instead the default value matches a
> DVI mode. Change the clock frequency to 74.25MHz so that
> it matches HDMI mode 1280x720 at 60Hz
>
> Signed-off-by: Jose Abreu <joabreu at synopsys.com>
> Cc: Carlos Palminha <palminha at synopsys.com>
> Cc: Alexey Brodkin <abrodkin at synopsys.com>
> Cc: Rob Herring <robh+dt at kernel.org>
> Cc: Vineet Gupta <vgupta at synopsys.com>
> Cc: devicetree at vger.kernel.org
> Cc: linux-snps-arc at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> ---
> ?arch/arc/boot/dts/axs10x_mb.dtsi | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
> index 9d882b1..41cfb29 100644
> --- a/arch/arc/boot/dts/axs10x_mb.dtsi
> +++ b/arch/arc/boot/dts/axs10x_mb.dtsi
> @@ -51,7 +51,7 @@
> ? pguclk: pguclk {
> ? #clock-cells = <0>;
> ? compatible = "fixed-clock";
> - clock-frequency = <74440000>;
> + clock-frequency = <74250000>;
> ? };
> ? };
Looks good to me but I have to note that with this change in place
monitors that don't report [correct] EDID won't work just because
if EDID is missing Linux kernel calculates pixel clock on its
own and for 1280x720 at 60?it gets 74.40 MHz which obviously differs from
yours 74.25 MHz and so?arc_pgu_crtc_atomic_check() returns?-EINVAL.
But with the fix I just sent, see
http://lists.infradead.org/pipermail/linux-snps-arc/2017-March/002173.html
everything will work again.
And once Vlad's patch for AXS PLLs gets accepted we'll finally get
support of multiple modes on AXS10x boards.
That said...
Acked-by: Alexey Brodkin <abrodkin at synopsys.com>
next prev parent reply other threads:[~2017-03-02 17:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 10:15 [RESEND PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback Jose Abreu
2017-03-02 18:57 ` [PATCH " Alexey Brodkin
2017-03-20 14:02 ` Jose Abreu
2017-03-20 14:05 ` Alexey Brodkin
2017-03-29 13:38 ` Jose Abreu
2017-04-21 10:15 ` [RESEND PATCH 2/2] arc: axs10x: Fix ARC PGU default clock frequency Jose Abreu
2017-03-02 17:35 ` Alexey Brodkin [this message]
2017-04-24 17:36 ` [RESEND PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback Vineet Gupta
2017-04-26 8:55 ` Jose Abreu
2017-04-26 23:31 ` Vineet Gupta
2017-04-27 18:42 ` Jose Abreu
2017-04-27 19:13 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488476152.2684.10.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox