From: Alexey.Brodkin@synopsys.com (Alexey Brodkin)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH] usb: Make sure usb/phy/of gets built-in
Date: Tue, 18 Apr 2017 12:23:20 +0000 [thread overview]
Message-ID: <1492518199.7548.8.camel@synopsys.com> (raw)
In-Reply-To: <58F584C9.3050607@gmail.com>
Hello Frank,
On Mon, 2017-04-17@20:15 -0700, Frank Rowand wrote:
> On 04/13/17 05:33, Alexey Brodkin wrote:
> >
> > DWC3 driver uses of_usb_get_phy_mode() which is
> > implemented in drivers/usb/phy/of.c and in bare minimal
> > configuration it might not be pulled in kernel binary.
> >
> > In case of ARC or ARM this could be easily reproduced with
> > "allnodefconfig" +CONFIG_USB=m +CONFIG_USB_DWC3=m.
> >
> > On building all ends-up with:
> > ---------------------->8------------------
> > ? Kernel: arch/arm/boot/Image is ready
> > ? Kernel: arch/arm/boot/zImage is ready
> > ? Building modules, stage 2.
> > ? MODPOST 5 modules
> > ERROR: "of_usb_get_phy_mode" [drivers/usb/dwc3/dwc3.ko] undefined!
> > make[1]: *** [__modpost] Error 1
> > make: *** [modules] Error 2
> > ---------------------->8------------------
> >
> > Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
> > Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> > Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
> > Cc: Geert Uytterhoeven <geert+renesas at glider.be>
> > Cc: Nicolas Pitre <nicolas.pitre at linaro.org>
> > Cc: Thomas Gleixner <tglx at linutronix.de>
> > Cc: Felipe Balbi <balbi at kernel.org>
> > Cc: Felix Fietkau <nbd at nbd.name>
> > Cc: Jeremy Kerr <jk at ozlabs.org>
> > Cc: linux-snps-arc at lists.infradead.org
> > Cc: stable at vger.kernel.org
> > ---
> > ?drivers/Makefile | 1 +
> > ?1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/Makefile b/drivers/Makefile
> > index 2eced9afba53..8f8bdc9e3d29 100644
> > --- a/drivers/Makefile
> > +++ b/drivers/Makefile
> > @@ -104,6 +104,7 @@ obj-$(CONFIG_USB_PHY) += usb/
> > ?obj-$(CONFIG_USB) += usb/
> > ?obj-$(CONFIG_PCI) += usb/
> > ?obj-$(CONFIG_USB_GADGET) += usb/
>
> >
> > +obj-$(CONFIG_OF) += usb/
>
> Would CONFIG_USB_SUPPORT make more sense? (And does it work?)
Well I'm not really sure here.
The problem was in missing "drivers/usb/phy/of.o" in "drivers/usb/built-in.o".
So I took a look at how components get enabled and saw quite mixed stuff.
In "drivers/usb/phy/Makefile" we see:
------------------------->8---------------------------
obj-$(CONFIG_OF)????????????????????????+= of.o
------------------------->8---------------------------
In "drivers/usb/Makefile" we see:
------------------------->8---------------------------
obj-$(CONFIG_USB_SUPPORT)???????+= phy/
------------------------->8---------------------------
next prev parent reply other threads:[~2017-04-18 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 12:33 [PATCH] usb: Make sure usb/phy/of gets built-in Alexey Brodkin
2017-04-18 3:15 ` Frank Rowand
2017-04-18 12:23 ` Alexey Brodkin [this message]
2017-04-24 12:44 ` Alexey Brodkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492518199.7548.8.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).