linux-snps-arc.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Alexey.Brodkin@synopsys.com (Alexey Brodkin)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 07/10] ARC: [plat-eznps] disabled stall counter due to a HW bug
Date: Thu, 25 May 2017 11:10:20 +0000	[thread overview]
Message-ID: <1495710620.5393.29.camel@synopsys.com> (raw)
In-Reply-To: <1495679660-9598-8-git-send-email-noamca@mellanox.com>

Hi Noam,

On Thu, 2017-05-25@05:34 +0300, Noam Camus wrote:
> From: Noam Camus <noamca at mellanox.com>
> 
> This counter represents threshold for consecutive stall that which
> trigger HW threads scheduling.
> Low values of this counter cause downgrade in performance
> and in the worst case even a livelock.
> 
> Signed-off-by: Noam Camus <noamca at mellanox.com>
> ---
> ?arch/arc/plat-eznps/mtm.c |????2 --
> ?1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arc/plat-eznps/mtm.c b/arch/arc/plat-eznps/mtm.c
> index aaaaffd..e0cb36b 100644
> --- a/arch/arc/plat-eznps/mtm.c
> +++ b/arch/arc/plat-eznps/mtm.c
> @@ -119,8 +119,6 @@ void mtm_enable_core(unsigned int cpu)
> ?	mt_ctrl.value = 0;
> ?	mt_ctrl.hsen = 1;
> ?	mt_ctrl.hs_cnt = MT_CTRL_HS_CNT;
> -	mt_ctrl.sten = 1;
> -	mt_ctrl.st_cnt = MT_CTRL_ST_CNT;

Even though I don't know your architecture this change doesn't
make enough sense to me in absence of better explanation of what is
really done here.

I.e. how removal of those 2 lines above improve your situation.

-Alexey

  reply	other threads:[~2017-05-25 11:10 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25  2:34 [PATCH 00/10] ARC plat-eznps upstream cont Noam Camus
2017-05-25  2:34 ` [PATCH 01/10] ARC: set level of log per CPU during boot to be debug level Noam Camus
2017-05-25 10:55   ` Alexey Brodkin
2017-05-25  2:34 ` [PATCH 02/10] ARC: send ipi to all cpus sharing task mm in case of page fault Noam Camus
2017-05-25 11:36   ` Alexey Brodkin
2017-05-25  2:34 ` [PATCH 03/10] ARC: typo fix in mm/fault.c Noam Camus
2017-05-25 11:04   ` Alexey Brodkin
2017-05-25  2:34 ` [PATCH 04/10] ARC: typos fix in kernel/entry-compact.S Noam Camus
2017-05-25 11:05   ` Alexey Brodkin
2017-05-25  2:34 ` [PATCH 05/10] ARC: [plat-eznps] typo fix at Kconfig Noam Camus
2017-05-25 11:07   ` Alexey Brodkin
2017-05-25  2:34 ` [PATCH 06/10] ARC: [plat-eznps] Fix TLB Errata Noam Camus
2017-05-25 11:00   ` Alexey Brodkin
2017-05-25 11:12     ` Noam Camus
2017-06-01 21:16     ` Vineet Gupta
2017-05-25  2:34 ` [PATCH 07/10] ARC: [plat-eznps] disabled stall counter due to a HW bug Noam Camus
2017-05-25 11:10   ` Alexey Brodkin [this message]
2017-05-25 11:16     ` Noam Camus
2017-05-25  2:34 ` [PATCH 08/10] ARC: [plat-eznps] spinlock aware for MTM Noam Camus
2017-05-25  2:34 ` [PATCH 09/10] ARC: [plat-eznps] use schd.wft instruction instead of sleep at idle task Noam Camus
2017-05-25  2:34 ` [PATCH 10/10] ARC: [plat-eznps] Handle memory error as an exception Noam Camus
2017-05-25 11:14   ` Alexey Brodkin
2017-05-25 11:26     ` Noam Camus
2017-05-25 11:30       ` Alexey Brodkin
2017-05-25 12:03         ` Noam Camus
2017-05-25 12:05           ` Alexey Brodkin
2017-06-06 21:57         ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495710620.5393.29.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).