From: Alexey.Brodkin@synopsys.com (Alexey Brodkin)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v2] arch: define weak abort
Date: Wed, 13 Dec 2017 21:46:26 +0000 [thread overview]
Message-ID: <1513201585.9373.21.camel@synopsys.com> (raw)
In-Reply-To: <1513118956-8718-1-git-send-email-sudipm.mukherjee@gmail.com>
Hi Sudip,
On Tue, 2017-12-12@22:49 +0000, Sudip Mukherjee wrote:
> gcc toggle -fisolate-erroneous-paths-dereference (default at -O2
> onwards) isolates faulty code paths such as null pointer access, divide
> by zero etc. If gcc port doesnt implement __builtin_trap, an abort() is
> generated which causes kernel link error.
>
> In this case, gcc is generating abort due to 'divide by zero' in
> lib/mpi/mpih-div.c.
>
> Currently 'frv' and 'arc' are failing. Previously other arch was also
> broken like m32r was fixed by d22e3d69ee1a ("m32r: fix build failure").
>
> Lets define this weak function which is common for all arch and fix the
> problem permanently. We can even remove the arch specific 'abort' after
> this is done.
>
> Cc: Alexey Brodkin <Alexey.Brodkin at synopsys.com>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee at gmail.com>
> ---
>
> Hi Alexey,
> I was thinking of sending the m32r revert patch in few days. My m32r
> builds are having a little problem and should be fixed by this weekend.
> I can not test m32r before that.
Understood, that's fine by me.
> We can also send a patch to remove the
> same code in arm and unicore32.
Sure that would be really great!
-Alexey
next parent reply other threads:[~2017-12-13 21:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1513118956-8718-1-git-send-email-sudipm.mukherjee@gmail.com>
2017-12-13 21:46 ` Alexey Brodkin [this message]
2017-12-19 21:39 ` [PATCH v2] arch: define weak abort Vineet Gupta
2017-12-19 21:55 ` Andrew Morton
2017-12-21 23:20 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513201585.9373.21.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).