From: vineet.gupta1@synopsys.com (Vineet Gupta)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH] testsuite fix: timezone: failing due to permissions in cross testing
Date: Mon, 17 Dec 2018 15:09:30 -0800 [thread overview]
Message-ID: <1545088170-24103-1-git-send-email-vgupta@synopsys.com> (raw)
timezone test driver "zic" creates testdata directory wuth umask 755, so
only root owner/group has write permissions. However the buildroot
system created has sshd as default user, so sh fails to write to test
results in this folder. Work around by relaxing umask to 777
| /bin/sh: build/glibc-fa3b6cd5bdbc/build/timezone/testdata/America/New_York.test-result: Permission denied
| Makefile:96: recipe for target 'build/glibc-fa3b6cd5bdbc/build/timezone/testdata/America/New_York' failed
| make[2]: *** [build/glibc-fa3b6cd5bdbc/build/timezone/testdata/America/New_York] Error 1
| make[2]: Leaving directory 'build/glibc-fa3b6cd5bdbc/timezone'
| Makefile:258: recipe for target 'timezone/xtests' failed
Signed-off-by: Vineet Gupta <vgupta at synopsys.com>
---
timezone/zic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/timezone/zic.c b/timezone/zic.c
index cb1bf28bfbc8..b7a5b0f6c80c 100644
--- a/timezone/zic.c
+++ b/timezone/zic.c
@@ -39,7 +39,7 @@ typedef int_fast64_t zic_t;
#include <sys/stat.h>
#endif
#ifdef S_IRUSR
-#define MKDIR_UMASK (S_IRUSR|S_IWUSR|S_IXUSR|S_IRGRP|S_IXGRP|S_IROTH|S_IXOTH)
+#define MKDIR_UMASK (S_IRUSR|S_IWUSR|S_IXUSR|S_IRGRP|S_IWGRP|S_IXGRP|S_IROTH|S_IWOTH|S_IXOTH)
#else
#define MKDIR_UMASK 0755
#endif
--
2.7.4
next reply other threads:[~2018-12-17 23:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 23:09 Vineet Gupta [this message]
2018-12-17 23:17 ` [PATCH] testsuite fix: timezone: failing due to permissions in cross testing Paul Eggert
2018-12-17 23:23 ` Vineet Gupta
2018-12-17 23:25 ` Joseph Myers
2018-12-17 23:38 ` Vineet Gupta
2018-12-17 23:42 ` Joseph Myers
2018-12-18 9:12 ` Florian Weimer
2018-12-18 17:17 ` Joseph Myers
2019-01-09 12:15 ` Florian Weimer
2018-12-18 16:53 ` Vineet Gupta
-- strict thread matches above, loose matches on Subject: below --
2018-12-17 23:04 Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1545088170-24103-1-git-send-email-vgupta@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox