* [GIT PULL 0/3] perf/urgent fixes
@ 2016-08-18 20:40 Arnaldo Carvalho de Melo
2016-08-18 20:40 ` [PATCH 2/3] tools lib: Reinstate strlcpy() header guard with __UCLIBC__ Arnaldo Carvalho de Melo
2016-08-18 20:51 ` [GIT PULL 0/3] perf/urgent fixes Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-08-18 20:40 UTC (permalink / raw)
To: linux-snps-arc
Hi Ingo,
Please consider pulling,
- Arnaldo
Build stats at the end of this message.
The following changes since commit 3cace81ea5bb0b3f2b97cab8e2c8e1fae2feb7ed:
Merge tag 'perf-urgent-for-mingo-20160815' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-08-16 20:08:56 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-20160818
for you to fetch changes up to c53412ee8c7ec31373a4176ff7f3a6b79296c05c:
perf evsel: Do not access outside hw cache name arrays (2016-08-18 16:39:46 -0300)
----------------------------------------------------------------
perf/urgent fixes:
- Do not access outside hw cache name arrays (Arnaldo Carvalho de Melo)
- Use addr_location::addr instead of ip for entries when unwinding using
DWARF CFI, fixing the "srcline" information for userspace application
callchains (Milian Wolff)
- Reinstate strlcpy() header guard with __UCLIBC__, fixing the build
with uclibc, detected when building for the ARC architecture (Vineet Gupta)
Signed-off-by: Arnaldo Carvalho de Melo <acme at redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf evsel: Do not access outside hw cache name arrays
Milian Wolff (1):
perf unwind: Use addr_location::addr instead of ip for entries
Vineet Gupta (1):
tools lib: Reinstate strlcpy() header guard with __UCLIBC__
tools/include/linux/string.h | 6 +++++-
tools/perf/util/evsel.c | 6 +++---
tools/perf/util/unwind-libdw.c | 2 +-
tools/perf/util/unwind-libunwind-local.c | 2 +-
4 files changed, 10 insertions(+), 6 deletions(-)
Build stats, now only android-ndk doesn't build with NO_LIBELF=1, as it
doesn't even have libelf to cross build with, and the non-cross builds
build objtool, uClibc and an ARC architecture cross build image are in
the works:
# time dm
1 77.199181517 alpine:3.4: Ok
2 30.215940343 android-ndk:r12b-arm: Ok
3 80.593965325 archlinux:latest: Ok
4 45.102186377 centos:5: Ok
5 67.078635441 centos:6: Ok
6 73.582617061 centos:7: Ok
7 65.462644128 debian:7: Ok
8 69.919139691 debian:8: Ok
9 77.192563446 debian:experimental: Ok
10 80.651363745 fedora:20: Ok
11 85.566954259 fedora:21: Ok
12 87.547437162 fedora:22: Ok
13 94.866327046 fedora:23: Ok
14 93.829320269 fedora:24: Ok
15 94.860933711 fedora:rawhide: Ok
16 88.890456556 mageia:5: Ok
17 85.622890293 opensuse:13.2: Ok
18 87.232034972 opensuse:42.1: Ok
19 94.807172866 opensuse:tumbleweed: Ok
20 72.189153053 ubuntu:12.04.5: Ok
21 86.275708891 ubuntu:14.04.4: Ok
22 90.743742216 ubuntu:15.10: Ok
23 86.931085419 ubuntu:16.04: Ok
24 67.823595709 ubuntu:16.04-x-arm: Ok
25 62.985390761 ubuntu:16.04-x-arm64: Ok
26 64.727635984 ubuntu:16.04-x-powerpc64: Ok
27 63.208264990 ubuntu:16.04-x-powerpc64el: Ok
28 64.685772233 ubuntu:16.04-x-s390: Ok
29 85.089091168 ubuntu:16.10: Ok
2224.88s
real 37m6.200s
user 0m1.830s
sys 0m2.653s
#
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 2/3] tools lib: Reinstate strlcpy() header guard with __UCLIBC__
2016-08-18 20:40 [GIT PULL 0/3] perf/urgent fixes Arnaldo Carvalho de Melo
@ 2016-08-18 20:40 ` Arnaldo Carvalho de Melo
2016-08-18 20:51 ` [GIT PULL 0/3] perf/urgent fixes Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-08-18 20:40 UTC (permalink / raw)
To: linux-snps-arc
From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
perf tools build in recent kernels spews splat when cross compiling with uClibc:
| CC util/alias.o
| In file included from tools/perf/util/../ui/../util/cache.h:8:0,
| from tools/perf/util/../ui/helpline.h:7,
| from tools/perf/util/debug.h:8,
| from arch/../util/cpumap.h:9,
| from arch/../util/env.h:5,
| from arch/common.h:4,
| from arch/common.c:3:
| tools/include/linux/string.h:12:15: warning: redundant redeclaration of ?strlcpy? [-Wredundant-decls]
| extern size_t strlcpy(char *dest, const char *src, size_t size);
^
This is after commit 61a6445e463a31 ("tools lib: Guard the strlcpy() header with
__GLIBC__").
The problem is uClibc also defines __GLIBC__ for exported headers for
applications. So add that specific check to not trip for uClibc.
Signed-off-by: Vineet Gupta <vgupta at synopsys.com>
Cc: Adrian Hunter <adrian.hunter at intel.com>
Cc: Alexey Brodkin <Alexey.Brodkin at synopsys.com>
Cc: David Ahern <dsahern at gmail.com>
Cc: Jiri Olsa <jolsa at kernel.org>
Cc: Josh Poimboeuf <jpoimboe at redhat.com>
Cc: Namhyung Kim <namhyung at kernel.org>
Cc: Peter Zijlstra <peterz at infradead.org>
Cc: Petri Gynther <pgynther at google.com>
Cc: Wang Nan <wangnan0 at huawei.com>
Cc: linux-snps-arc at lists.infradead.org
Link: http://lkml.kernel.org/r/1471537703-16439-1-git-send-email-vgupta at synopsys.com
Signed-off-by: Arnaldo Carvalho de Melo <acme at redhat.com>
---
tools/include/linux/string.h | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/include/linux/string.h b/tools/include/linux/string.h
index b96879477311..f436d2420a18 100644
--- a/tools/include/linux/string.h
+++ b/tools/include/linux/string.h
@@ -8,7 +8,11 @@ void *memdup(const void *src, size_t len);
int strtobool(const char *s, bool *res);
-#ifdef __GLIBC__
+/*
+ * glibc based builds needs the extern while uClibc doesn't.
+ * However uClibc headers also define __GLIBC__ hence the hack below
+ */
+#if defined(__GLIBC__) && !defined(__UCLIBC__)
extern size_t strlcpy(char *dest, const char *src, size_t size);
#endif
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [GIT PULL 0/3] perf/urgent fixes
2016-08-18 20:40 [GIT PULL 0/3] perf/urgent fixes Arnaldo Carvalho de Melo
2016-08-18 20:40 ` [PATCH 2/3] tools lib: Reinstate strlcpy() header guard with __UCLIBC__ Arnaldo Carvalho de Melo
@ 2016-08-18 20:51 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2016-08-18 20:51 UTC (permalink / raw)
To: linux-snps-arc
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Build stats at the end of this message.
>
> The following changes since commit 3cace81ea5bb0b3f2b97cab8e2c8e1fae2feb7ed:
>
> Merge tag 'perf-urgent-for-mingo-20160815' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-08-16 20:08:56 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-20160818
>
> for you to fetch changes up to c53412ee8c7ec31373a4176ff7f3a6b79296c05c:
>
> perf evsel: Do not access outside hw cache name arrays (2016-08-18 16:39:46 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> - Do not access outside hw cache name arrays (Arnaldo Carvalho de Melo)
>
> - Use addr_location::addr instead of ip for entries when unwinding using
> DWARF CFI, fixing the "srcline" information for userspace application
> callchains (Milian Wolff)
>
> - Reinstate strlcpy() header guard with __UCLIBC__, fixing the build
> with uclibc, detected when building for the ARC architecture (Vineet Gupta)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme at redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> perf evsel: Do not access outside hw cache name arrays
>
> Milian Wolff (1):
> perf unwind: Use addr_location::addr instead of ip for entries
>
> Vineet Gupta (1):
> tools lib: Reinstate strlcpy() header guard with __UCLIBC__
>
> tools/include/linux/string.h | 6 +++++-
> tools/perf/util/evsel.c | 6 +++---
> tools/perf/util/unwind-libdw.c | 2 +-
> tools/perf/util/unwind-libunwind-local.c | 2 +-
> 4 files changed, 10 insertions(+), 6 deletions(-)
>
> Build stats, now only android-ndk doesn't build with NO_LIBELF=1, as it
> doesn't even have libelf to cross build with, and the non-cross builds
> build objtool, uClibc and an ARC architecture cross build image are in
> the works:
>
> # time dm
> 1 77.199181517 alpine:3.4: Ok
> 2 30.215940343 android-ndk:r12b-arm: Ok
> 3 80.593965325 archlinux:latest: Ok
> 4 45.102186377 centos:5: Ok
> 5 67.078635441 centos:6: Ok
> 6 73.582617061 centos:7: Ok
> 7 65.462644128 debian:7: Ok
> 8 69.919139691 debian:8: Ok
> 9 77.192563446 debian:experimental: Ok
> 10 80.651363745 fedora:20: Ok
> 11 85.566954259 fedora:21: Ok
> 12 87.547437162 fedora:22: Ok
> 13 94.866327046 fedora:23: Ok
> 14 93.829320269 fedora:24: Ok
> 15 94.860933711 fedora:rawhide: Ok
> 16 88.890456556 mageia:5: Ok
> 17 85.622890293 opensuse:13.2: Ok
> 18 87.232034972 opensuse:42.1: Ok
> 19 94.807172866 opensuse:tumbleweed: Ok
> 20 72.189153053 ubuntu:12.04.5: Ok
> 21 86.275708891 ubuntu:14.04.4: Ok
> 22 90.743742216 ubuntu:15.10: Ok
> 23 86.931085419 ubuntu:16.04: Ok
> 24 67.823595709 ubuntu:16.04-x-arm: Ok
> 25 62.985390761 ubuntu:16.04-x-arm64: Ok
> 26 64.727635984 ubuntu:16.04-x-powerpc64: Ok
> 27 63.208264990 ubuntu:16.04-x-powerpc64el: Ok
> 28 64.685772233 ubuntu:16.04-x-s390: Ok
> 29 85.089091168 ubuntu:16.10: Ok
> 2224.88s
>
> real 37m6.200s
> user 0m1.830s
> sys 0m2.653s
> #
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-18 20:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-18 20:40 [GIT PULL 0/3] perf/urgent fixes Arnaldo Carvalho de Melo
2016-08-18 20:40 ` [PATCH 2/3] tools lib: Reinstate strlcpy() header guard with __UCLIBC__ Arnaldo Carvalho de Melo
2016-08-18 20:51 ` [GIT PULL 0/3] perf/urgent fixes Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).