From: wbx@uclibc-ng.org (Waldemar Brodkorb)
To: linux-snps-arc@lists.infradead.org
Subject: mman.h patch
Date: Fri, 2 Feb 2018 03:33:41 +0100 [thread overview]
Message-ID: <20180202023341.GO4279@waldemar-brodkorb.de> (raw)
In-Reply-To: <358b8834-7a51-5af2-b412-d80294c464ba@synopsys.com>
Hi,
Vineet Gupta wrote,
> On 02/01/2018 11:43 AM, Waldemar Brodkorb wrote:
> >Hi,
> >
> >I would like to push attached patch next week.
> >Any veto?
>
> So it seems there is code consolidation and additionally there's seems to be
> a semantical change to ldso mmap().
>
> Assuming __ARCH_USE_MMU__ is true for say ARC, now we have
> _MAP_UNINITIALIZED == 0 vs. before MAP_UNINITIALIZED == 0x4000000.
>
> So we won't be zero init ldso anon mmaps - which could be functionally OK,
> but I think better to split it out as a seperate patch just to call this out
> !
I believe MAP_UNINITIALIZED is only used by the Linux kernel for
noMMU cases, so the ARC definition was wrong.
Is it really a semantically change, if Linux kernel ignores it for
MMU targets?
May be a better commit log like the attached clarifies it?
best regards
Waldemar
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-bits-mman.h-consolidate-header-file.patch
Type: text/x-diff
Size: 70047 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-snps-arc/attachments/20180202/d9a9e740/attachment-0001.bin>
prev parent reply other threads:[~2018-02-02 2:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180201193623.GL4279@waldemar-brodkorb.de>
2018-02-01 22:31 ` mman.h patch Vineet Gupta
2018-02-02 2:33 ` Waldemar Brodkorb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202023341.GO4279@waldemar-brodkorb.de \
--to=wbx@uclibc-ng.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox