From: jhogan@kernel.org (James Hogan)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH] bug.h: Work around GCC PR82365 in BUG()
Date: Wed, 11 Apr 2018 11:19:27 +0100 [thread overview]
Message-ID: <20180411101927.GA29949@saruman> (raw)
In-Reply-To: <CAK8P3a2_ihWCuUvDz_SVA1TMomkO1d7pa6e2bOQkZcEVP+Ff-A@mail.gmail.com>
On Wed, Apr 11, 2018@12:08:51PM +0200, Arnd Bergmann wrote:
> On Wed, Apr 11, 2018@11:54 AM, James Hogan <jhogan@kernel.org> wrote:
> > On Wed, Apr 11, 2018@09:30:56AM +0200, Arnd Bergmann wrote:
> >> On Wed, Apr 11, 2018@12:48 AM, James Hogan <jhogan@kernel.org> wrote:
> >> > Before I forward port those patches to add .insn for MIPS, is that sort
> >> > of approach (an arch specific asm/compiler-gcc.h to allow MIPS to
> >> > override barrier_before_unreachable()) an acceptable fix?
> >>
> >> That sounds fine to me. However, I would suggest making that
> >> asm/compiler.h instead of asm/compiler-gcc.h, so we can also
> >> use the same file to include workarounds for clang if needed.
> >
> > Yes, though there are a few asm/compiler.h's already, and the alpha one
> > includes linux/compiler.h before undefining inline, so seems to have its
> > own specific purpose...
>
> Interesting. For the other ones, including asm/compiler.h from linux/compiler.h
> seems appropriate though, so the question would be what to do with the
> alpha case. I think we can simply remove that header file and replace
> it with this patch:
>
> diff --git a/arch/alpha/Kconfig b/arch/alpha/Kconfig
> index b2022885ced8..5502404f54cd 100644
> --- a/arch/alpha/Kconfig
> +++ b/arch/alpha/Kconfig
> @@ -81,6 +81,9 @@ config PGTABLE_LEVELS
> int
> default 3
>
> +config OPTIMIZE_INLINING
> + def_bool y
> +
> source "init/Kconfig"
> source "kernel/Kconfig.freezer"
>
> which should have the same effect.
Hmm yes, and I suppose alpha would need ARCH_SUPPORTS_OPTIMIZED_INLINING
too. I'll give it a try.
Cheers
James
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-snps-arc/attachments/20180411/99d026ca/attachment.sig>
prev parent reply other threads:[~2018-04-11 10:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 11:39 [PATCH] bug.h: Work around GCC PR82365 in BUG() Arnd Bergmann
2017-12-19 11:49 ` Geert Uytterhoeven
2017-12-19 16:57 ` Vineet Gupta
2017-12-19 20:13 ` Arnd Bergmann
2017-12-19 22:38 ` Vineet Gupta
2017-12-20 9:01 ` Arnd Bergmann
2017-12-20 18:52 ` Vineet Gupta
2017-12-20 20:12 ` Arnd Bergmann
2017-12-20 20:29 ` Vineet Gupta
2018-02-08 0:01 ` Andrew Morton
2018-02-08 0:51 ` Vineet Gupta
2018-02-08 1:20 ` Vineet Gupta
2018-02-21 21:23 ` Vineet Gupta
2018-04-10 22:48 ` James Hogan
2018-04-11 7:30 ` Arnd Bergmann
2018-04-11 9:54 ` James Hogan
2018-04-11 10:08 ` Arnd Bergmann
2018-04-11 10:19 ` James Hogan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411101927.GA29949@saruman \
--to=jhogan@kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox