linux-snps-arc.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: bsingharora@gmail.com (Balbir Singh)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 2/4] mm: speed up mremap by 500x on large regions (v2)
Date: Sat, 27 Oct 2018 21:21:02 +1100	[thread overview]
Message-ID: <20181027102102.GO8537@350D> (raw)
In-Reply-To: <20181025021350.GB13560@joelaf.mtv.corp.google.com>

On Wed, Oct 24, 2018@07:13:50PM -0700, Joel Fernandes wrote:
> On Wed, Oct 24, 2018@10:57:33PM +1100, Balbir Singh wrote:
> [...]
> > > > +		pmd_t pmd;
> > > > +
> > > > +		new_ptl = pmd_lockptr(mm, new_pmd);
> > 
> > 
> > Looks like this is largely inspired by move_huge_pmd(), I guess a lot of
> > the code applies, why not just reuse as much as possible? The same comments
> > w.r.t mmap_sem helping protect against lock order issues applies as well.
> 
> I thought about this and when I looked into it, it seemed there are subtle
> differences that make such sharing not worth it (or not possible).
>

Could you elaborate on them?

Thanks,
Balbir Singh. 

  reply	other threads:[~2018-10-27 10:21 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-13  1:31 [PATCH 0/4] Add support for fast mremap Joel Fernandes (Google)
2018-10-13  1:31 ` [PATCH 1/4] treewide: remove unused address argument from pte_alloc functions (v2) Joel Fernandes (Google)
2018-10-24  8:37   ` Peter Zijlstra
2018-10-25  2:21     ` Joel Fernandes
2018-10-26  8:52       ` Peter Zijlstra
2018-10-25 10:47     ` Kirill A. Shutemov
2018-10-26  8:50       ` Peter Zijlstra
2018-10-13  1:31 ` [PATCH 2/4] mm: speed up mremap by 500x on large regions (v2) Joel Fernandes (Google)
2018-10-15  9:42   ` Christoph Hellwig
2018-10-15 22:33     ` Joel Fernandes
2018-10-16 11:29       ` Vlastimil Babka
2018-10-16 19:43         ` Joel Fernandes
2018-10-17  7:38           ` Vlastimil Babka
2018-10-24 10:12   ` Kirill A. Shutemov
2018-10-24 11:57     ` Balbir Singh
2018-10-24 12:57       ` Kirill A. Shutemov
2018-10-25  2:09         ` Joel Fernandes
2018-10-25 10:19           ` Kirill A. Shutemov
2018-10-26 21:11             ` Joel Fernandes
2018-10-29 10:28               ` Will Deacon
2018-10-25  2:13       ` Joel Fernandes
2018-10-27 10:21         ` Balbir Singh [this message]
2018-10-27 19:39           ` Joel Fernandes
2018-10-28 22:40             ` Balbir Singh
2018-10-13  1:31 ` [PATCH 3/4] arm64: select HAVE_MOVE_PMD for faster mremap (v1) Joel Fernandes (Google)
2018-10-13  1:32 ` [PATCH 4/4] x86: " Joel Fernandes (Google)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181027102102.GO8537@350D \
    --to=bsingharora@gmail.com \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).