From: linux@roeck-us.net (Guenter Roeck)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH] mm: Generalize and rename notify_page_fault() as kprobe_page_fault()
Date: Sat, 29 Jun 2019 07:50:09 -0700 [thread overview]
Message-ID: <20190629145009.GA28613@roeck-us.net> (raw)
In-Reply-To: <1560420444-25737-1-git-send-email-anshuman.khandual@arm.com>
Hi,
On Thu, Jun 13, 2019@03:37:24PM +0530, Anshuman Khandual wrote:
> Architectures which support kprobes have very similar boilerplate around
> calling kprobe_fault_handler(). Use a helper function in kprobes.h to unify
> them, based on the x86 code.
>
> This changes the behaviour for other architectures when preemption is
> enabled. Previously, they would have disabled preemption while calling the
> kprobe handler. However, preemption would be disabled if this fault was
> due to a kprobe, so we know the fault was not due to a kprobe handler and
> can simply return failure.
>
> This behaviour was introduced in the commit a980c0ef9f6d ("x86/kprobes:
> Refactor kprobes_fault() like kprobe_exceptions_notify()")
>
With this patch applied, parisc:allmodconfig images no longer build.
In file included from arch/parisc/mm/fixmap.c:8:
include/linux/kprobes.h: In function 'kprobe_page_fault':
include/linux/kprobes.h:477:9: error:
implicit declaration of function 'kprobe_fault_handler'; did you mean 'kprobe_page_fault'?
Reverting the patch fixes the problem.
Guenter
next prev parent reply other threads:[~2019-06-29 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 10:07 [PATCH] mm: Generalize and rename notify_page_fault() as kprobe_page_fault() Anshuman Khandual
2019-06-13 17:57 ` Vineet Gupta
2019-06-18 15:56 ` Vineet Gupta
2019-06-20 7:19 ` Masami Hiramatsu
2019-06-13 20:04 ` Andrew Morton
2019-06-14 5:15 ` Anshuman Khandual
2019-06-29 14:50 ` Guenter Roeck [this message]
2019-06-30 4:41 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190629145009.GA28613@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox