From: Christoph Hellwig <hch@lst.de>
To: Sergey Matyukevich <geomatsi@gmail.com>
Cc: linux-snps-arc@lists.infradead.org,
Vineet Gupta <vgupta@kernel.org>,
Vladimir Isaev <isaev@synopsys.com>,
Christoph Hellwig <hch@lst.de>,
Sergey Matyukevich <sergey.matyukevich@synopsys.com>
Subject: Re: [RFC PATCH 2/3] arc: provide __{get,put}_kernel_nofault
Date: Tue, 1 Feb 2022 16:10:28 +0100 [thread overview]
Message-ID: <20220201151028.GB3731@lst.de> (raw)
In-Reply-To: <20220201145538.111192-3-geomatsi@gmail.com>
On Tue, Feb 01, 2022 at 05:55:37PM +0300, Sergey Matyukevich wrote:
> From: Sergey Matyukevich <sergey.matyukevich@synopsys.com>
>
> Implement the non-faulting kernel access helpers directly
> instead of using uaccess routines under set_fs(KERNEL_DS).
>
> Signed-off-by: Sergey Matyukevich <sergey.matyukevich@synopsys.com>
> ---
> arch/arc/include/asm/uaccess.h | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arc/include/asm/uaccess.h b/arch/arc/include/asm/uaccess.h
> index 9d1205bf90f1..c14b692a0a4e 100644
> --- a/arch/arc/include/asm/uaccess.h
> +++ b/arch/arc/include/asm/uaccess.h
> @@ -657,6 +657,28 @@ static inline unsigned long __arc_clear_user(void __user *to, unsigned long n)
> return res;
> }
>
> +#define HAVE_GET_KERNEL_NOFAULT
> +
> +#define __get_kernel_nofault(dst, src, type, err_label) \
> + do { \
Normal kernel style doesn't indent the do { } while inside of
function-like macros.
Otherwise this looks good.
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2022-02-01 15:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 14:55 [RFC PATCH 0/3] arc: remove CONFIG_SET_FS Sergey Matyukevich
2022-02-01 14:55 ` [RFC PATCH 1/3] arc: use BUILD_BUG for invalid sizes in get_user/put_user Sergey Matyukevich
2022-02-01 15:08 ` Christoph Hellwig
2022-02-01 14:55 ` [RFC PATCH 2/3] arc: provide __{get,put}_kernel_nofault Sergey Matyukevich
2022-02-01 15:10 ` Christoph Hellwig [this message]
2022-02-01 14:55 ` [RFC PATCH 3/3] arc: remove set_fs() Sergey Matyukevich
2022-02-01 15:11 ` Christoph Hellwig
2022-02-02 5:14 ` [RFC PATCH 0/3] arc: remove CONFIG_SET_FS Vineet Gupta
2022-02-15 21:04 ` Sergey Matyukevich
2022-02-18 4:03 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220201151028.GB3731@lst.de \
--to=hch@lst.de \
--cc=geomatsi@gmail.com \
--cc=isaev@synopsys.com \
--cc=linux-snps-arc@lists.infradead.org \
--cc=sergey.matyukevich@synopsys.com \
--cc=vgupta@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox