From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Vineet Gupta <vgupta@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-snps-arc@lists.infradead.org,
linux-serial <linux-serial@vger.kernel.org>,
kernel@pengutronix.de
Subject: Re: [PATCH] serial: arc_uart: Drop empty platform remove function
Date: Tue, 13 Dec 2022 12:26:33 +0200 (EET) [thread overview]
Message-ID: <2260aed-5ad1-a67-13b9-17b3ad8b3377@linux.intel.com> (raw)
In-Reply-To: <20221212212037.3773636-1-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]
On Mon, 12 Dec 2022, Uwe Kleine-König wrote:
> A remove callback just returning 0 is equivalent to no remove callback
> at all. So drop the useless function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
> ---
> drivers/tty/serial/arc_uart.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
> index 2a65ea2660e1..f1b6034addda 100644
> --- a/drivers/tty/serial/arc_uart.c
> +++ b/drivers/tty/serial/arc_uart.c
> @@ -632,12 +632,6 @@ static int arc_serial_probe(struct platform_device *pdev)
> return uart_add_one_port(&arc_uart_driver, &arc_uart_ports[dev_id].port);
> }
>
> -static int arc_serial_remove(struct platform_device *pdev)
> -{
> - /* This will never be called */
> - return 0;
> -}
> -
> static const struct of_device_id arc_uart_dt_ids[] = {
> { .compatible = "snps,arc-uart" },
> { /* Sentinel */ }
> @@ -646,7 +640,6 @@ MODULE_DEVICE_TABLE(of, arc_uart_dt_ids);
>
> static struct platform_driver arc_platform_driver = {
> .probe = arc_serial_probe,
> - .remove = arc_serial_remove,
> .driver = {
> .name = DRIVER_NAME,
> .of_match_table = arc_uart_dt_ids,
>
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
prev parent reply other threads:[~2022-12-13 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 21:20 [PATCH] serial: arc_uart: Drop empty platform remove function Uwe Kleine-König
2022-12-13 10:26 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2260aed-5ad1-a67-13b9-17b3ad8b3377@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-serial@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vgupta@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).