* [PATCH] serial: arc_uart: Drop empty platform remove function
@ 2022-12-12 21:20 Uwe Kleine-König
2022-12-13 10:26 ` Ilpo Järvinen
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2022-12-12 21:20 UTC (permalink / raw)
To: Vineet Gupta, Greg Kroah-Hartman, Jiri Slaby
Cc: linux-snps-arc, linux-serial, kernel
A remove callback just returning 0 is equivalent to no remove callback
at all. So drop the useless function.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/tty/serial/arc_uart.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
index 2a65ea2660e1..f1b6034addda 100644
--- a/drivers/tty/serial/arc_uart.c
+++ b/drivers/tty/serial/arc_uart.c
@@ -632,12 +632,6 @@ static int arc_serial_probe(struct platform_device *pdev)
return uart_add_one_port(&arc_uart_driver, &arc_uart_ports[dev_id].port);
}
-static int arc_serial_remove(struct platform_device *pdev)
-{
- /* This will never be called */
- return 0;
-}
-
static const struct of_device_id arc_uart_dt_ids[] = {
{ .compatible = "snps,arc-uart" },
{ /* Sentinel */ }
@@ -646,7 +640,6 @@ MODULE_DEVICE_TABLE(of, arc_uart_dt_ids);
static struct platform_driver arc_platform_driver = {
.probe = arc_serial_probe,
- .remove = arc_serial_remove,
.driver = {
.name = DRIVER_NAME,
.of_match_table = arc_uart_dt_ids,
--
2.38.1
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: arc_uart: Drop empty platform remove function
2022-12-12 21:20 [PATCH] serial: arc_uart: Drop empty platform remove function Uwe Kleine-König
@ 2022-12-13 10:26 ` Ilpo Järvinen
0 siblings, 0 replies; 2+ messages in thread
From: Ilpo Järvinen @ 2022-12-13 10:26 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Vineet Gupta, Greg Kroah-Hartman, Jiri Slaby, linux-snps-arc,
linux-serial, kernel
[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]
On Mon, 12 Dec 2022, Uwe Kleine-König wrote:
> A remove callback just returning 0 is equivalent to no remove callback
> at all. So drop the useless function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
> ---
> drivers/tty/serial/arc_uart.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
> index 2a65ea2660e1..f1b6034addda 100644
> --- a/drivers/tty/serial/arc_uart.c
> +++ b/drivers/tty/serial/arc_uart.c
> @@ -632,12 +632,6 @@ static int arc_serial_probe(struct platform_device *pdev)
> return uart_add_one_port(&arc_uart_driver, &arc_uart_ports[dev_id].port);
> }
>
> -static int arc_serial_remove(struct platform_device *pdev)
> -{
> - /* This will never be called */
> - return 0;
> -}
> -
> static const struct of_device_id arc_uart_dt_ids[] = {
> { .compatible = "snps,arc-uart" },
> { /* Sentinel */ }
> @@ -646,7 +640,6 @@ MODULE_DEVICE_TABLE(of, arc_uart_dt_ids);
>
> static struct platform_driver arc_platform_driver = {
> .probe = arc_serial_probe,
> - .remove = arc_serial_remove,
> .driver = {
> .name = DRIVER_NAME,
> .of_match_table = arc_uart_dt_ids,
>
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-13 10:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-12 21:20 [PATCH] serial: arc_uart: Drop empty platform remove function Uwe Kleine-König
2022-12-13 10:26 ` Ilpo Järvinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).