From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Vineet Gupta <vgupta@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"David S . Miller" <davem@davemloft.net>
Cc: Guenter Roeck <linux@roeck-us.net>,
linux-snps-arc@lists.infradead.org,
linux-m68k@lists.linux-m68k.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org,
Cezary Rojewski <cezary.rojewski@intel.com>
Subject: Re: [PATCH v2 3/3] sparc64: bitops: Change __fls to return unsigned long
Date: Wed, 3 Aug 2022 10:48:01 +0200 [thread overview]
Message-ID: <2d4fac14-eaf8-c899-dba2-b2ffb484358d@linux.intel.com> (raw)
In-Reply-To: <20220527115345.2588775-4-amadeuszx.slawinski@linux.intel.com>
On 5/27/2022 1:53 PM, Amadeusz Sławiński wrote:
> As per asm-generic definition and other architectures __fls should
> return unsigned long.
>
> No functional change is expected as return value should fit in unsigned
> long.
>
> Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
> ---
> arch/sparc/include/asm/bitops_64.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sparc/include/asm/bitops_64.h b/arch/sparc/include/asm/bitops_64.h
> index 005a8ae858f1..cdac39bd7b32 100644
> --- a/arch/sparc/include/asm/bitops_64.h
> +++ b/arch/sparc/include/asm/bitops_64.h
> @@ -24,7 +24,7 @@ void clear_bit(unsigned long nr, volatile unsigned long *addr);
> void change_bit(unsigned long nr, volatile unsigned long *addr);
>
> int fls(unsigned int word);
> -int __fls(unsigned long word);
> +unsigned long __fls(unsigned long word);
>
> #include <asm-generic/bitops/non-atomic.h>
>
Hi,
any chance this one could also get merged? Other two patches are already
in linux-next and I would like to remove it from list of things I have
to remember ;)
Amadeusz
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
prev parent reply other threads:[~2022-08-03 8:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 11:53 [PATCH v2 0/3] bitops: __fls adjustments Amadeusz Sławiński
2022-05-27 11:53 ` [PATCH v2 1/3] ARC: bitops: Change __fls to return unsigned long Amadeusz Sławiński
2022-05-27 11:53 ` [PATCH v2 2/3] m68k: bitops: Change __fls to return and accept " Amadeusz Sławiński
2022-07-06 9:30 ` Geert Uytterhoeven
2022-05-27 11:53 ` [PATCH v2 3/3] sparc64: bitops: Change __fls to return " Amadeusz Sławiński
2022-08-03 8:48 ` Amadeusz Sławiński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d4fac14-eaf8-c899-dba2-b2ffb484358d@linux.intel.com \
--to=amadeuszx.slawinski@linux.intel.com \
--cc=cezary.rojewski@intel.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=sparclinux@vger.kernel.org \
--cc=vgupta@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).