From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: "linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3 17/17] ARC: changes to enable 64-bit time_t, off_t, ino_t etc
Date: Sat, 7 Mar 2020 00:37:08 +0000 [thread overview]
Message-ID: <2e734388-b9f1-1e56-17c2-141acd87abe2@synopsys.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2003070016420.26274@digraph.polyomino.org.uk>
On 3/6/20 4:19 PM, Joseph Myers wrote:
> On Fri, 6 Mar 2020, Vineet Gupta wrote:
>
>> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
>> ---
>> .../sysv/linux/arc/bits/socket-constants.h | 4 +--
>
> There is a general principle for patch series: you should not have later
> patches fixing up things that were wrong with earlier patches. Each patch
> should add files in the form desired to be reviewed, not in a form that
> gets fixed up later.
>
> (Sometimes a patch series might change a file that was correct in an
> earlier patch in the series, as part of adding additional features, if the
> first M patches add feature X and the next N add feature Y on top of it.
> But that's not the case here - such later patches should not make
> incompatible changes to earlier ones.)
I agree and you've mentioned this fact before as well. The only reason I carved it
this way was to ease my testing. The 64-bit time code was based on RV32 which in
turn was based on bleeding edge upstream some of which needed additional work for
ARC but ininitial days of 64-bit work, it was hard to know if the fix was needed
for 64-bit or for upstream tracking. And that's exactly what I got bitten by -
when I missed the fixup for init constructor invocation from Florian, wasting 3
days [1]
Anyhow that's just to give you the context. I can split them up and add to
respective sections for next iteration. If we end up not doing another iteration
- hypothetically speaking :-) the whole port is anyhow committed as 1 patch so it
doesn't matter.
[1] http://lists.infradead.org/pipermail/linux-snps-arc/2020-February/006974.html
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2020-03-07 0:37 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 18:24 [PATCH v3 00/17] glibc port to ARC processors Vineet Gupta
2020-03-06 18:24 ` [PATCH v3 01/17] gcc PR 88409: miscompilation due to missing cc clobber in longlong.h macros Vineet Gupta
2020-03-07 0:12 ` Joseph Myers
2020-03-07 0:21 ` Vineet Gupta
2020-03-10 17:23 ` sourceware account access (was Re: [PATCH v3 01/17] gcc PR 88409: miscompilation due to missing cc clobber in longlong.h macros) Vineet Gupta
2020-03-10 17:57 ` Carlos O'Donell
2020-03-10 18:08 ` sourceware account access Vineet Gupta
2020-03-10 18:10 ` Carlos O'Donell
2020-03-11 2:00 ` [PATCH v3 01/17] gcc PR 88409: miscompilation due to missing cc clobber in longlong.h macros Vineet Gupta
[not found] ` <d3d2969f-4370-588b-b9be-a9ae0d38e10e@openwall.com>
2020-03-09 23:38 ` Vineet Gupta
2020-03-06 18:24 ` [PATCH v3 02/17] ARC: add definitions to elf/elf.h Vineet Gupta
2020-03-06 18:24 ` [PATCH v3 03/17] ARC: ABI Implementation Vineet Gupta
2020-03-06 18:24 ` [PATCH v3 04/17] ARC: startup and dynamic linking code Vineet Gupta
2020-03-06 18:24 ` [PATCH v3 05/17] ARC: Thread Local Storage support Vineet Gupta
2020-03-06 18:24 ` [PATCH v3 06/17] ARC: Atomics and Locking primitives Vineet Gupta
2020-03-06 18:24 ` [PATCH v3 07/17] ARC: math soft float support Vineet Gupta
2020-03-06 18:24 ` [PATCH v3 08/17] ARC: hardware floating point support Vineet Gupta
2020-03-06 18:24 ` [PATCH v3 09/17] ARC: Linux Syscall Interface Vineet Gupta
2020-03-06 18:24 ` [PATCH v3 10/17] ARC: Linux ABI Vineet Gupta
2020-03-06 18:24 ` [PATCH v3 11/17] ARC: Linux Startup and Dynamic Loading Vineet Gupta
2020-03-06 18:24 ` [PATCH v3 12/17] ARC: ABI lists Vineet Gupta
2020-03-07 15:20 ` Florian Weimer
2020-03-08 5:45 ` Vineet Gupta
2020-03-09 9:14 ` Florian Weimer
2020-03-06 18:24 ` [PATCH v3 13/17] ARC: Update syscall-names.list for ARC specific syscalls Vineet Gupta
2020-03-06 18:24 ` [PATCH v3 14/17] ARC: Build Infrastructure Vineet Gupta
2020-03-07 0:16 ` Joseph Myers
2020-03-07 0:24 ` Vineet Gupta
2020-03-06 18:24 ` [PATCH v3 15/17] build-many-glibcs.py: Enable ARC builds Vineet Gupta
2020-03-06 18:24 ` [PATCH v3 16/17] NEWS: mention ARC port Vineet Gupta
2020-03-07 0:14 ` Joseph Myers
2020-03-07 0:55 ` Vineet Gupta
2020-03-07 1:08 ` Joseph Myers
2020-03-07 1:26 ` Vineet Gupta
2020-03-07 1:29 ` Joseph Myers
2020-03-06 18:24 ` [PATCH v3 17/17] ARC: changes to enable 64-bit time_t, off_t, ino_t etc Vineet Gupta
2020-03-07 0:19 ` Joseph Myers
2020-03-07 0:37 ` Vineet Gupta [this message]
2020-03-07 0:21 ` [PATCH v3 00/17] glibc port to ARC processors Joseph Myers
2020-03-07 0:57 ` Vineet Gupta
2020-03-07 1:10 ` Joseph Myers
2020-03-12 21:23 ` Vineet Gupta
2020-03-12 21:46 ` Joseph Myers
2020-03-23 18:20 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e734388-b9f1-1e56-17c2-141acd87abe2@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox