From: Vineet.Gupta1@synopsys.com (Vineet Gupta)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH] ARC: Add PCIe support for ARC HSDK platform
Date: Mon, 18 Jun 2018 11:10:51 -0700 [thread overview]
Message-ID: <562939df-4c97-c19b-72e3-14196a651c40@synopsys.com> (raw)
In-Reply-To: <ba4b10e967fb39d18eba7a5c70abb167308481f5.camel@synopsys.com>
On 06/18/2018 08:20 AM, Alexey Brodkin wrote:
>> +static void __init hsdk_enable_gpio_intc_wire(void)
>> +{
>> + u32 val = GPIO_HAPS_INT;
>> +
>> + iowrite32(0xffffffff, (void __iomem *) GPIO_INTMASK);
>> + iowrite32(~val, (void __iomem *) GPIO_INTMASK);
>> + iowrite32(0x00000000, (void __iomem *) GPIO_INTTYPE_LEVEL);
>> + iowrite32(0xffffffff, (void __iomem *) GPIO_INT_POLARITY);
>> + iowrite32(val, (void __iomem *) GPIO_INTEN);
>> +}
> I would suggest to have a map of really used lines and enable all of them
> instead of adding one-by-one occasionally.
More importantly, adding any code in this file is an absolute abomination and only
desired if this is a platform specific hack which can't be added in the generic
driver and/or specified via the Device Tree. Here it seems like we are enabling
some gpio lines which likely could be done via the gpio driver paths ?
-Vineet
next prev parent reply other threads:[~2018-06-18 18:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 14:59 [PATCH] ARC: Add PCIe support for ARC HSDK platform Gustavo Pimentel
2018-06-18 15:20 ` Alexey Brodkin
2018-06-18 18:10 ` Vineet Gupta [this message]
2018-06-18 19:46 ` Alexey Brodkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562939df-4c97-c19b-72e3-14196a651c40@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox