From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joao.Pinto@synopsys.com (Joao Pinto)
Date: Thu, 26 Nov 2015 15:41:29 +0000
Subject: [PATCH 2/2] PCI support added to ARC
In-Reply-To: <20151125164636.GB1380@localhost>
References: <cover.1448375184.git.jpinto@synopsys.com>
 <9b80d6c1db4d7e2b5ee5dc0056a3d8284e7c2b9b.1448375184.git.jpinto@synopsys.com>
 <C2D7FE5348E1B147BCA15975FBA23075F44D3B42@IN01WEMBXA.internal.synopsys.com>
 <20151125164636.GB1380@localhost>
List-ID: <linux-snps-arc@lists.infradead.org>
Message-ID: <56572829.4090102@synopsys.com>
To: linux-snps-arc@lists.infradead.org

Hi Bjorn,

On 11/25/2015 4:46 PM, Bjorn Helgaas wrote:
> On Wed, Nov 25, 2015@05:25:37AM +0000, Vineet Gupta wrote:
>> On Tuesday 24 November 2015 08:02 PM, Joao Pinto wrote:
> 
>>> +			pr_err("PCI: Device %s not available because"/
>>> +			       " of resource collisions\n", pci_name(dev));
>>
>> Better not to break strings - even if they sometime exceed line sz limit of 80.
>> You could anyways reduce the string content herer.
> 
> Also use dev_err() instead of pr_err().
> 

Thanks for the review. Could you please check PATCH 1/2 regarding the new
platform driver? This way I would produce a v2 of the patch set.

Thanks,
Joao